Skip to contentSkip to conversation

remoteproc: qcom_adsp_pil: select qcom_scm

PATCH In review Arnd Bergmann 2 participants 3 messages Dec 9, 2016 Remote processor (remoteproc)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remoteproc: qcom_adsp_pil: select qcom_scm

The adsp-pil driver relies on SCM and causes a build error without it:

ERROR: "qcom_scm_pas_supported" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_is_available" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_auth_and_reset" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_shutdown" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_mem_setup" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_init_image" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!

This adds a 'select', as SCM is a silent Kconfig symbol that gets enabled implicitly by all its users.

Fixes b9e718e950c3 ("remoteproc: Introduce Qualcomm ADSP PIL")
---
 drivers/remoteproc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/remoteproc/Kconfig +1 -0
index 51d7ca0e10fc..1177329b7618 100644
@@ -85,6 +85,7 @@ config QCOM_ADSP_PIL
 	depends on QCOM_SMEM
 	select MFD_SYSCON
 	select QCOM_MDT_LOADER
+	select QCOM_SCM
 	help
 	  Say y here to support the TrustZone based Peripherial Image Loader
 	  for the Qualcomm ADSP remote processors.
Signature · 1 line
2.9.0
#1 lore raw
Quoted 9 lines · Arnd Bergmann

The adsp-pil driver relies on SCM and causes a build error without it:

ERROR: "qcom_scm_pas_supported" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_is_available" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_auth_and_reset" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_shutdown" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_mem_setup" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_init_image" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!

Quoted 3 lines

This adds a 'select', as SCM is a silent Kconfig symbol that gets enabled implicitly by all its users.

Thanks, sorry for giving you the opportunity for finding all these odd combinations.

Are you aware of any projects aiming to catch these through e.g. dependency analysis rather than random build testing (and my now growing manual checklist)?

Regards,
Bjorn

Quoted 21 lines
Fixes b9e718e950c3 ("remoteproc: Introduce Qualcomm ADSP PIL")
---
 drivers/remoteproc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/remoteproc/Kconfig +1 -0
index 51d7ca0e10fc..1177329b7618 100644
@@ -85,6 +85,7 @@ config QCOM_ADSP_PIL
 	depends on QCOM_SMEM
 	select MFD_SYSCON
 	select QCOM_MDT_LOADER
+	select QCOM_SCM
 	help
 	  Say y here to support the TrustZone based Peripherial Image Loader
 	  for the Qualcomm ADSP remote processors.
Signature · 1 line
2.9.0
#2 lore raw
Quoted 15 lines · CET Bjorn Andersson
Quoted 9 lines · Arnd Bergmann

The adsp-pil driver relies on SCM and causes a build error without it:

ERROR: "qcom_scm_pas_supported" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_is_available" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_auth_and_reset" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_shutdown" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_mem_setup" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!
ERROR: "qcom_scm_pas_init_image" [drivers/remoteproc/qcom_adsp_pil.ko] undefined!

Quoted 3 lines

This adds a 'select', as SCM is a silent Kconfig symbol that gets enabled implicitly by all its users.

Quoted 6 lines

Thanks, sorry for giving you the opportunity for finding all these odd combinations.

Are you aware of any projects aiming to catch these through e.g. dependency analysis rather than random build testing (and my now growing manual checklist)?

I think there is one project that tries to identify impossible constraints in Kconfig, but that would not have caught cases like this one.

Arnd