jffs2: check dstlen for jffs2_zlib_compress()
A message that is not in the archive (sent off-list or not yet received): [email protected]
Richard Weinberger
maintainerAm Montag, 21. Januar 2019, 09:59:10 CET schrieb [email protected]:
Quoted 2 lines
Thanks for reply.
But I think if (*dstlen < 2) is not good enough.
Not enough in terms of what?
My patch does what the commit message says, it fixes the out of bound access. What do I miss?
Quoted 6 lines
Because if the length of
data_inis equals to 2, the length of output compressed data is also 2. So there's no meaning to do all the compress calculates.And I had do an experiment:
If dstlen equals to 3, anddata_inhas 3 same bytes, the length of output compressed data will be 2. Which means compress is effective.
This is a different issue and a possible further optimization.
Thanks,
//richard