Skip to contentSkip to conversation

dt-bindings: Add vendor prefix for Vamrs Ltd.

PATCH Superseded Ezequiel Garcia 2 participants 6 messages Jun 28, 2018 – Jul 3, 2018

Subsystems (2)
Device tree bindings Arm Rockchip

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Ezequiel Garcia

author
#0 lore raw

PATCH v2 1/3 dt-bindings: Add vendor prefix for Vamrs Ltd.

Vamrs Ltd. is a hardware solutions provider based in China.

Website: http://vamrs.com/

Signed-off-by Ezequiel Garcia <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index b5f978a4cac6..6430a1818974 100644
@@ -383,6 +383,7 @@ urt	United Radiant Technology Corporation
 usi	Universal Scientific Industrial Co., Ltd.
 v3	V3 Semiconductor
 variscite	Variscite Ltd.
+vamrs	Vamrs Ltd.
 via	VIA Technologies, Inc.
 virtio	Virtual I/O Device Specification, developed by the OASIS consortium
 vivante	Vivante Corporation
Signature · 1 line
2.18.0.rc2
author
#1 lore raw

PATCH v2 2/3 arm64: dts: rockchip: add pin configurations for RK3399

Add pcfg_pull_none_18ma and pcfg_output_low to the dtsi file, as they are needed by some boards.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399.dtsi +9 -0
index 37fddec1dadf..27dd73d2b9f6 100644
@@ -1932,6 +1932,11 @@
 			drive-strength = <12>;
 		};
 
+		pcfg_pull_none_18ma: pcfg-pull-none-18ma {
+			bias-disable;
+			drive-strength = <18>;
+		};
+
 		pcfg_pull_up_8ma: pcfg-pull-up-8ma {
 			bias-pull-up;
 			drive-strength = <8>;

@@ -1957,6 +1962,10 @@
 			drive-strength = <13>;
 		};
 
+		pcfg_output_low: pcfg-output-low {
+			output-low;
+		};
+
 		clock {
 			clk_32k: clk-32k {
 				rockchip,pins = <0 0 RK_FUNC_2 &pcfg_pull_none>;
Signature · 1 line
2.18.0.rc2
maintainer
#2 lore raw

PATCH v2 2/3 arm64: dts: rockchip: add pin configurations for RK3399

Am Freitag, 29. Juni 2018, 00:08:29 CEST schrieb Ezequiel Garcia:

Quoted 4 lines

Add pcfg_pull_none_18ma and pcfg_output_low to the dtsi file, as they are needed by some boards.

Signed-off-by Ezequiel Garcia <[email protected]>

This looks similar to what Randy wants to do in [0].
As I'll probably apply his patch first, please check if anything is missing there and if possible base your series on it :-).

Thanks
Heiko

[0] https://patchwork.kernel.org/patch/10479923/

author
#3 lore raw

PATCH v2 3/3 arm64: dts: rockchip: add 96boards RK3399 Ficus board

In reply to Ezequiel Garcia

The RK3399 Ficus board is an Enterprise Edition board manufactured by Vamrs Ltd., based on the Rockchip RK3399 SoC.

The board exposes a bunch of nice peripherals, including SATA, HDMI, MIPI CSI, Ethernet, WiFi, and PCIe.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 .../devicetree/bindings/arm/rockchip.txt      |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 arch/arm64/boot/dts/rockchip/rk3399-ficus.dts | 517 ++++++++++++++++++
 3 files changed, 523 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-ficus.dts
Documentation/devicetree/bindings/arm/rockchip.txt +5 -0
index 1c1d62d03c4f..d46c5d43e27f 100644
@@ -1,5 +1,10 @@
 Rockchip platforms device tree bindings
 ---------------------------------------
+
+- 96boards RK3399 Ficus (ROCK960 Enterprise Edition)
+    Required root node properties:
+      - compatible = "vamrs,ficus", "rockchip,rk3399";
+
 - Amarula Vyasa RK3288 board
     Required root node properties:
       - compatible = "amarula,vyasa-rk3288", "rockchip,rk3288";
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 48a83f882947..2811fb701f12 100644
@@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-orion-r68-meta.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-ficus.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-firefly.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-kevin.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb
arch/arm64/boot/dts/rockchip/rk3399-ficus.dts new file +517 -0

517 lines not on this page · raw message

Signature · 1 line
2.18.0.rc2
maintainer
#4 lore raw

PATCH v2 3/3 arm64: dts: rockchip: add 96boards RK3399 Ficus board

Am Freitag, 29. Juni 2018, 00:08:30 CEST schrieb Ezequiel Garcia:

Quoted 19 lines

The RK3399 Ficus board is an Enterprise Edition board manufactured by Vamrs Ltd., based on the Rockchip RK3399 SoC.

The board exposes a bunch of nice peripherals, including SATA, HDMI, MIPI CSI, Ethernet, WiFi, and PCIe.

Signed-off-by Ezequiel Garcia <[email protected]>
---
 .../devicetree/bindings/arm/rockchip.txt      |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 arch/arm64/boot/dts/rockchip/rk3399-ficus.dts | 517 ++++++++++++++++++
 3 files changed, 523 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-ficus.dts
Documentation/devicetree/bindings/arm/rockchip.txt +0 -0
index 1c1d62d03c4f..d46c5d43e27f 100644

Documentation/devicetree/bindings/arm/rockchip.txt line 10

Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.txt +5 -0
@@ -1,5 +1,10 @@
 Rockchip platforms device tree bindings
 ---------------------------------------
+
+- 96boards RK3399 Ficus (ROCK960 Enterprise Edition)
+    Required root node properties:
+      - compatible = "vamrs,ficus", "rockchip,rk3399";
+
 - Amarula Vyasa RK3288 board
     Required root node properties:
       - compatible = "amarula,vyasa-rk3288", "rockchip,rk3288";

binding changes should Cc devicetree maintainers + lists

Quoted 18 lines
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 48a83f882947..2811fb701f12 100644
@@ -9,6 +9,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-orion-r68-meta.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-ficus.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-firefly.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-gru-kevin.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou.dtb
arch/arm64/boot/dts/rockchip/rk3399-ficus.dts new file +0 -0
new file mode 100644
index 000000000000..cc7976126d76

arch/arm64/boot/dts/rockchip/rk3399-ficus.dts line 9

Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3399-ficus.dts new file +9 -0
@@ -0,0 +1,517 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 Collabora Ltd.
+ * Copyright (c) 2018 Fuzhou Rockchip Electronics Co., Ltd.
+ */
+
+/*
+ * Schematics available at https://dl.vamrs.com/products/ficus/docs/hw
+ */

nice touch with the schematics link. Although small nit:
that could be part of the comment-block above it.

[...]

arch/arm64/boot/dts/rockchip/rk3399-ficus.dts line 502

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3399-ficus.dts new file +5 -0
+&uart2 {
+	status = "okay";
+};
+
+

nit: double empty line

arch/arm64/boot/dts/rockchip/rk3399-ficus.dts line 505

Quoted 3 lines
arch/arm64/boot/dts/rockchip/rk3399-ficus.dts new file +3 -0
+&vopb {
+	status = "okay";
+};

Overall the board dts looks great now.

If it weren't for the missing devicetree maintainers Cc's I'd just fix it up myself and just apply it, but we'll need a respin, so that dt-people at least have a chance to see the changes.

Thanks
Heiko