Skip to contentSkip to conversation

64bit archs doing incorrect magic for smbfs?

PATCH Petr Vandrovec 2 participants 2 messages Apr 22, 2002

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines · Urban Widmark

For smbfs the data part is now often sent as a normal ascii string (when using samba 2.2.0+) and should then not be modified at all. ncpfs defines two different formats (v3 and v4), don't know if both are used.

If you have recent (2.2.0.18/2.2.0.19) ncpfs, format v4 is used (it allows for 32bit uid/gid). I have no non-ia32 test environment, so if anybody finds that ncpfs does not work on any platform, feel free to send patches either to me or to arch maintainers...

Quoted 3 lines

Untested patch vs 2.4.19-pre7-ac2 below adds version number checks for the smbfs case (yes, it handles the ascii format too). Similar changes are needed in 2.5.

I plan using ASCII format too, but it is not high enough on my TODO list. If it will make life for Al or other architectures easier, I'll do it sooner...
Petr Vandrovec [email protected]

#1 lore raw
Quoted 4 lines · Petr Vandrovec

If you have recent (2.2.0.18/2.2.0.19) ncpfs, format v4 is used (it allows for 32bit uid/gid). I have no non-ia32 test environment, so if anybody finds that ncpfs does not work on any platform, feel free to send patches either to me or to arch maintainers...

Unless the v3 and v4 structs have the same layout (and they don't, although I may have developed a sudden cross-eydness [1]), the code can't possibly work for all ncpmounts. It may be unused on some arch's because they don't need 32->64 translation.

I suggest you put it on your list but below the ascii-fication, since that is another (better?) solution to the same problem.

/Urban

[1] http://www.anri.barc.usda.gov/emusnow/stereo/stereo.htm