generic sys_old_select

PATCH In review Christoph Hellwig 5 participants 9 messages Jan 6, 2010 – Jan 10, 2010

Subsystems (8)

Arm (32-bit) x86 VFS s390 +4 more subsystems

lore

Share & tools

lore

Christoph Hellwig

author

2010-01-06 17:21 UTC #0 lore raw

PATCH 1/3 generic sys_old_select

Add a generic implementation of the old select syscall, which expects it's argument in a memory block and switch all architectures over to use it.

Signed-off-by Christoph Hellwig <[email protected]>

arch/arm/kernel/calls.S +1 -1

Index: linux-2.6/arch/arm/kernel/calls.S
===================================================================
@@ -91,7 +91,7 @@
 		CALL(sys_settimeofday)
 /* 80 */	CALL(sys_getgroups16)
 		CALL(sys_setgroups16)
-		CALL(OBSOLETE(old_select))	/* used by libc4 */
+		CALL(OBSOLETE(sys_old_select))	/* used by libc4 */
 		CALL(sys_symlink)
 		CALL(sys_ni_syscall)		/* was sys_lstat */
 /* 85 */	CALL(sys_readlink)

arch/m68k/kernel/entry.S +1 -1

Index: linux-2.6/arch/m68k/kernel/entry.S
===================================================================
@@ -510,7 +510,7 @@ sys_call_table:
 	.long sys_settimeofday
 	.long sys_getgroups16	/* 80 */
 	.long sys_setgroups16
-	.long old_select
+	.long sys_old_select
 	.long sys_symlink
 	.long sys_lstat
 	.long sys_readlink	/* 85 */

arch/m68knommu/kernel/syscalltable.S +1 -1

Index: linux-2.6/arch/m68knommu/kernel/syscalltable.S
===================================================================
@@ -100,7 +100,7 @@ ENTRY(sys_call_table)
 	.long sys_settimeofday
 	.long sys_getgroups16	/* 80 */
 	.long sys_setgroups16
-	.long old_select
+	.long sys_old_select
 	.long sys_symlink
 	.long sys_lstat
 	.long sys_readlink	/* 85 */

arch/x86/kernel/syscall_table_32.S +1 -1

Index: linux-2.6/arch/x86/kernel/syscall_table_32.S
===================================================================
@@ -81,7 +81,7 @@ ENTRY(sys_call_table)
 	.long sys_settimeofday
 	.long sys_getgroups16	/* 80 */
 	.long sys_setgroups16
-	.long old_select
+	.long sys_old_select
 	.long sys_symlink
 	.long sys_lstat
 	.long sys_readlink	/* 85 */

arch/x86/include/asm/sys_ia32.h +0 -2

Index: linux-2.6/arch/x86/include/asm/sys_ia32.h
===================================================================
@@ -40,8 +40,6 @@ asmlinkage long sys32_rt_sigprocmask(int
 				     compat_sigset_t __user *, unsigned int);
 asmlinkage long sys32_alarm(unsigned int);
 
-struct sel_arg_struct;
-asmlinkage long sys32_old_select(struct sel_arg_struct __user *);
 asmlinkage long sys32_waitpid(compat_pid_t, unsigned int *, int);
 asmlinkage long sys32_sysfs(int, u32, u32);

arch/arm/include/asm/unistd.h +1 -0

Index: linux-2.6/arch/arm/include/asm/unistd.h
===================================================================
@@ -442,6 +442,7 @@
 #define __ARCH_WANT_SYS_SIGPROCMASK
 #define __ARCH_WANT_SYS_RT_SIGACTION
 #define __ARCH_WANT_SYS_RT_SIGSUSPEND
+#define __ARCH_WANT_SYS_OLD_SELECT
 
 #if !defined(CONFIG_AEABI) || defined(CONFIG_OABI_COMPAT)
 #define __ARCH_WANT_SYS_TIME

arch/h8300/include/asm/unistd.h +1 -0

Index: linux-2.6/arch/h8300/include/asm/unistd.h
===================================================================
@@ -348,6 +348,7 @@
 #define __ARCH_WANT_SYS_LLSEEK
 #define __ARCH_WANT_SYS_NICE
 #define __ARCH_WANT_SYS_OLD_GETRLIMIT
+#define __ARCH_WANT_SYS_OLD_SELECT
 #define __ARCH_WANT_SYS_OLDUMOUNT
 #define __ARCH_WANT_SYS_SIGPENDING
 #define __ARCH_WANT_SYS_SIGPROCMASK

arch/m68k/include/asm/unistd.h +1 -0

Index: linux-2.6/arch/m68k/include/asm/unistd.h
===================================================================
@@ -359,6 +359,7 @@
 #define __ARCH_WANT_SYS_LLSEEK
 #define __ARCH_WANT_SYS_NICE
 #define __ARCH_WANT_SYS_OLD_GETRLIMIT
+#define __ARCH_WANT_SYS_OLD_SELECT
 #define __ARCH_WANT_SYS_OLDUMOUNT
 #define __ARCH_WANT_SYS_SIGPENDING
 #define __ARCH_WANT_SYS_SIGPROCMASK

arch/x86/include/asm/unistd_32.h +1 -0

Index: linux-2.6/arch/x86/include/asm/unistd_32.h
===================================================================
@@ -366,6 +366,7 @@
 #define __ARCH_WANT_SYS_LLSEEK
 #define __ARCH_WANT_SYS_NICE
 #define __ARCH_WANT_SYS_OLD_GETRLIMIT
+#define __ARCH_WANT_SYS_OLD_SELECT
 #define __ARCH_WANT_SYS_OLDUMOUNT
 #define __ARCH_WANT_SYS_SIGPENDING
 #define __ARCH_WANT_SYS_SIGPROCMASK

arch/ia64/ia32/sys_ia32.c +0 ~~-19~~

Index: linux-2.6/arch/ia64/ia32/sys_ia32.c
===================================================================
@@ -1107,25 +1107,6 @@ sys32_alarm (unsigned int seconds)
 	return alarm_setitimer(seconds);
 }
 
-struct sel_arg_struct {
-	unsigned int n;
-	unsigned int inp;
-	unsigned int outp;
-	unsigned int exp;
-	unsigned int tvp;
-};
-
-asmlinkage long
-sys32_old_select (struct sel_arg_struct __user *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	return compat_sys_select(a.n, compat_ptr(a.inp), compat_ptr(a.outp),
-				 compat_ptr(a.exp), compat_ptr(a.tvp));
-}
-
 #define SEMOP		 1
 #define SEMGET		 2
 #define SEMCTL		 3

arch/x86/ia32/sys_ia32.c +0 ~~-18~~

Index: linux-2.6/arch/x86/ia32/sys_ia32.c
===================================================================
@@ -332,24 +332,6 @@ asmlinkage long sys32_alarm(unsigned int
 	return alarm_setitimer(seconds);
 }
 
-struct sel_arg_struct {
-	unsigned int n;
-	unsigned int inp;
-	unsigned int outp;
-	unsigned int exp;
-	unsigned int tvp;
-};
-
-asmlinkage long sys32_old_select(struct sel_arg_struct __user *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	return compat_sys_select(a.n, compat_ptr(a.inp), compat_ptr(a.outp),
-				 compat_ptr(a.exp), compat_ptr(a.tvp));
-}
-
 asmlinkage long sys32_waitpid(compat_pid_t pid, unsigned int *stat_addr,
 			      int options)
 {

fs/select.c +17 -0

Index: linux-2.6/fs/select.c
===================================================================
@@ -691,6 +691,23 @@ SYSCALL_DEFINE6(pselect6, int, n, fd_set
 }
 #endif /* HAVE_SET_RESTORE_SIGMASK */
 
+#ifdef __ARCH_WANT_SYS_OLD_SELECT
+struct sel_arg_struct {
+	unsigned long n;
+	fd_set __user *inp, *outp, *exp;
+	struct timeval __user *tvp;
+};
+
+SYSCALL_DEFINE1(old_select, struct sel_arg_struct __user *, arg)
+{
+	struct sel_arg_struct a;
+
+	if (copy_from_user(&a, arg, sizeof(a)))
+		return -EFAULT;
+	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
+}
+#endif
+
 struct poll_list {
 	struct poll_list *next;
 	int len;

arch/h8300/kernel/syscalls.S +1 -1

Index: linux-2.6/arch/h8300/kernel/syscalls.S
===================================================================
@@ -96,7 +96,7 @@ SYMBOL_NAME_LABEL(sys_call_table)	
 	.long SYMBOL_NAME(sys_settimeofday)
 	.long SYMBOL_NAME(sys_getgroups16)	/* 80 */
 	.long SYMBOL_NAME(sys_setgroups16)
-	.long SYMBOL_NAME(old_select)
+	.long SYMBOL_NAME(sys_old_select)
 	.long SYMBOL_NAME(sys_symlink)
 	.long SYMBOL_NAME(sys_lstat)
 	.long SYMBOL_NAME(sys_readlink)		/* 85 */

arch/mn10300/include/asm/unistd.h +1 -0

Index: linux-2.6/arch/mn10300/include/asm/unistd.h
===================================================================
@@ -374,6 +374,7 @@
 #define __ARCH_WANT_SYS_LLSEEK
 #define __ARCH_WANT_SYS_NICE
 #define __ARCH_WANT_SYS_OLD_GETRLIMIT
+#define __ARCH_WANT_SYS_OLD_SELECT
 #define __ARCH_WANT_SYS_OLDUMOUNT
 #define __ARCH_WANT_SYS_SIGPENDING
 #define __ARCH_WANT_SYS_SIGPROCMASK

arch/mn10300/kernel/entry.S +1 -1

Index: linux-2.6/arch/mn10300/kernel/entry.S
===================================================================
@@ -468,7 +468,7 @@ ENTRY(sys_call_table)
 	.long sys_settimeofday
 	.long sys_getgroups16	/* 80 */
 	.long sys_setgroups16
-	.long old_select
+	.long sys_old_select
 	.long sys_symlink
 	.long sys_lstat
 	.long sys_readlink	/* 85 */

include/linux/syscalls.h +2 -0

Index: linux-2.6/include/linux/syscalls.h
===================================================================
@@ -34,6 +34,7 @@ struct pollfd;
 struct rlimit;
 struct rusage;
 struct sched_param;
+struct sel_arg_struct;
 struct semaphore;
 struct sembuf;
 struct shmid_ds;

@@ -638,6 +639,7 @@ asmlinkage long sys_poll(struct pollfd _
 				long timeout);
 asmlinkage long sys_select(int n, fd_set __user *inp, fd_set __user *outp,
 			fd_set __user *exp, struct timeval __user *tvp);
+asmlinkage long sys_old_select(struct sel_arg_struct __user * arg);
 asmlinkage long sys_epoll_create(int size);
 asmlinkage long sys_epoll_create1(int flags);
 asmlinkage long sys_epoll_ctl(int epfd, int op, int fd,

arch/arm/kernel/sys_arm.c +0 ~~-21~~

Index: linux-2.6/arch/arm/kernel/sys_arm.c
===================================================================
@@ -54,27 +54,6 @@ out:
 	return error;
 }
 
-/*
- * Perform the select(nd, in, out, ex, tv) and mmap() system
- * calls.
- */
-
-struct sel_arg_struct {
-	unsigned long n;
-	fd_set __user *inp, *outp, *exp;
-	struct timeval __user *tvp;
-};
-
-asmlinkage int old_select(struct sel_arg_struct __user *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	/* sys_select() does the appropriate kernel locking */
-	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
-}
-
 #if !defined(CONFIG_AEABI) || defined(CONFIG_OABI_COMPAT)
 /*
  * sys_ipc() is the de-multiplexer for the SysV IPC calls..

arch/h8300/kernel/sys_h8300.c +0 ~~-16~~

Index: linux-2.6/arch/h8300/kernel/sys_h8300.c
===================================================================
@@ -60,22 +60,6 @@ out:
 	return error;
 }
 
-struct sel_arg_struct {
-	unsigned long n;
-	fd_set *inp, *outp, *exp;
-	struct timeval *tvp;
-};
-
-asmlinkage int old_select(struct sel_arg_struct *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	/* sys_select() does the appropriate kernel locking */
-	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
-}
-
 /*
  * sys_ipc() is the de-multiplexer for the SysV IPC calls..
  *

arch/m68k/kernel/sys_m68k.c +0 ~~-16~~

Index: linux-2.6/arch/m68k/kernel/sys_m68k.c
===================================================================
@@ -75,22 +75,6 @@ out:
 	return error;
 }
 
-struct sel_arg_struct {
-	unsigned long n;
-	fd_set __user *inp, *outp, *exp;
-	struct timeval __user *tvp;
-};
-
-asmlinkage int old_select(struct sel_arg_struct __user *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	/* sys_select() does the appropriate kernel locking */
-	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
-}
-
 /*
  * sys_ipc() is the de-multiplexer for the SysV IPC calls..
  *

arch/ia64/ia32/ia32_entry.S +1 -1

Index: linux-2.6/arch/ia64/ia32/ia32_entry.S
===================================================================
@@ -260,7 +260,7 @@ ia32_syscall_table:
 	data8 compat_sys_settimeofday
 	data8 sys32_getgroups16	  /* 80 */
 	data8 sys32_setgroups16
-	data8 sys32_old_select
+	data8 compat_sys_old_select
 	data8 sys_symlink
 	data8 sys_ni_syscall
 	data8 sys_readlink	  /* 85 */

arch/m68knommu/kernel/sys_m68k.c +0 ~~-16~~

Index: linux-2.6/arch/m68knommu/kernel/sys_m68k.c
===================================================================
@@ -61,22 +61,6 @@ out:
 	return error;
 }
 
-struct sel_arg_struct {
-	unsigned long n;
-	fd_set *inp, *outp, *exp;
-	struct timeval *tvp;
-};
-
-asmlinkage int old_select(struct sel_arg_struct *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	/* sys_select() does the appropriate kernel locking */
-	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
-}
-
 /*
  * sys_ipc() is the de-multiplexer for the SysV IPC calls..
  *

arch/mn10300/kernel/sys_mn10300.c +0 ~~-18~~

Index: linux-2.6/arch/mn10300/kernel/sys_mn10300.c
===================================================================
@@ -32,24 +32,6 @@ asmlinkage long old_mmap(unsigned long a
 	return sys_mmap_pgoff(addr, len, prot, flags, fd, offset >> PAGE_SHIFT);
 }
 
-struct sel_arg_struct {
-	unsigned long n;
-	fd_set *inp;
-	fd_set *outp;
-	fd_set *exp;
-	struct timeval *tvp;
-};
-
-asmlinkage int old_select(struct sel_arg_struct __user *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	/* sys_select() does the appropriate kernel locking */
-	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
-}
-
 /*
  * sys_ipc() is the de-multiplexer for the SysV IPC calls..
  *

arch/x86/ia32/ia32entry.S +1 -1

Index: linux-2.6/arch/x86/ia32/ia32entry.S
===================================================================
@@ -586,7 +586,7 @@ ia32_sys_call_table:
 	.quad compat_sys_settimeofday
 	.quad sys_getgroups16	/* 80 */
 	.quad sys_setgroups16
-	.quad sys32_old_select
+	.quad compat_sys_old_select
 	.quad sys_symlink
 	.quad sys_lstat
 	.quad sys_readlink		/* 85 */

arch/x86/include/asm/syscalls.h +0 -2

Index: linux-2.6/arch/x86/include/asm/syscalls.h
===================================================================
@@ -52,12 +52,10 @@ unsigned long sys_sigreturn(struct pt_re
 
 /* kernel/sys_i386_32.c */
 struct mmap_arg_struct;
-struct sel_arg_struct;
 struct oldold_utsname;
 struct old_utsname;
 
 asmlinkage int old_mmap(struct mmap_arg_struct __user *);
-asmlinkage int old_select(struct sel_arg_struct __user *);
 asmlinkage int sys_ipc(uint, int, int, int, void __user *, long);
 asmlinkage int sys_uname(struct old_utsname __user *);
 asmlinkage int sys_olduname(struct oldold_utsname __user *);

arch/x86/kernel/sys_i386_32.c +0 ~~-17~~

Index: linux-2.6/arch/x86/kernel/sys_i386_32.c
===================================================================
@@ -58,23 +58,6 @@ out:
 	return err;
 }
 
-
-struct sel_arg_struct {
-	unsigned long n;
-	fd_set __user *inp, *outp, *exp;
-	struct timeval __user *tvp;
-};
-
-asmlinkage int old_select(struct sel_arg_struct __user *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	/* sys_select() does the appropriate kernel locking */
-	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
-}
-
 /*
  * sys_ipc() is the de-multiplexer for the SysV IPC calls..
  *

fs/compat.c +18 -0

Index: linux-2.6/fs/compat.c
===================================================================
@@ -1795,6 +1795,24 @@ asmlinkage long compat_sys_select(int n,
 	return ret;
 }
 
+struct compat_sel_arg_struct {
+	compat_ulong_t n;
+	compat_ulong_t inp;
+	compat_ulong_t outp;
+	compat_ulong_t exp;
+	compat_ulong_t tvp;
+};
+
+asmlinkage long compat_sys_old_select(struct compat_sel_arg_struct __user *arg)
+{
+	struct compat_sel_arg_struct a;
+
+	if (copy_from_user(&a, arg, sizeof(a)))
+		return -EFAULT;
+	return compat_sys_select(a.n, compat_ptr(a.inp), compat_ptr(a.outp),
+				 compat_ptr(a.exp), compat_ptr(a.tvp));
+}
+
 #ifdef HAVE_SET_RESTORE_SIGMASK
 static long do_compat_pselect(int n, compat_ulong_t __user *inp,
 	compat_ulong_t __user *outp, compat_ulong_t __user *exp,

arch/s390/kernel/entry.h +0 -1

Index: linux-2.6/arch/s390/kernel/entry.h
===================================================================
@@ -28,7 +28,6 @@ struct new_utsname;
 struct mmap_arg_struct;
 struct fadvise64_64_args;
 struct old_sigaction;
-struct sel_arg_struct;
 
 long sys_mmap2(struct mmap_arg_struct __user  *arg);
 long sys_s390_old_mmap(struct mmap_arg_struct __user *arg);

arch/um/sys-i386/syscalls.c +0 ~~-18~~

Index: linux-2.6/arch/um/sys-i386/syscalls.c
===================================================================
@@ -44,24 +44,6 @@ long old_mmap_i386(struct mmap_arg_struc
 	return err;
 }
 
-struct sel_arg_struct {
-	unsigned long n;
-	fd_set __user *inp;
-	fd_set __user *outp;
-	fd_set __user *exp;
-	struct timeval __user *tvp;
-};
-
-long old_select(struct sel_arg_struct __user *arg)
-{
-	struct sel_arg_struct a;
-
-	if (copy_from_user(&a, arg, sizeof(a)))
-		return -EFAULT;
-	/* sys_select() does the appropriate kernel locking */
-	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
-}
-
 /*
  * The prototype on i386 is:
  *

include/linux/compat.h +3 -0

Index: linux-2.6/include/linux/compat.h
===================================================================
@@ -23,6 +23,7 @@
 typedef __compat_uid32_t	compat_uid_t;
 typedef __compat_gid32_t	compat_gid_t;
 
+struct compat_sel_arg_struct;
 struct rusage;
 
 struct compat_itimerspec {

@@ -249,6 +250,8 @@ asmlinkage long compat_sys_select(int n,
 		compat_ulong_t __user *outp, compat_ulong_t __user *exp,
 		struct compat_timeval __user *tvp);
 
+asmlinkage long compat_sys_old_select(struct compat_sel_arg_struct __user *arg);
+
 asmlinkage long compat_sys_wait4(compat_pid_t pid,
 				 compat_uint_t __user *stat_addr, int options,
 				 struct compat_rusage __user *ru);

Matthew Wilcox

2010-01-06 17:33 UTC #1 lore raw

Quoted 2 lines · Christoph Hellwig

Add a generic implementation of the old select syscall, which expects it's argument in a memory block and switch all architectures over to use it.

Don't we want an ifdef around compat_sys_old_select() like the one around sys_old_select()?

Quoted 57 lines

Index: linux-2.6/fs/select.c
===================================================================

fs/select.c +17 -0

@@ -691,6 +691,23 @@ SYSCALL_DEFINE6(pselect6, int, n, fd_set
 }
 #endif /* HAVE_SET_RESTORE_SIGMASK */
 
+#ifdef __ARCH_WANT_SYS_OLD_SELECT
+struct sel_arg_struct {
+	unsigned long n;
+	fd_set __user *inp, *outp, *exp;
+	struct timeval __user *tvp;
+};
+
+SYSCALL_DEFINE1(old_select, struct sel_arg_struct __user *, arg)
+{
+	struct sel_arg_struct a;
+
+	if (copy_from_user(&a, arg, sizeof(a)))
+		return -EFAULT;
+	return sys_select(a.n, a.inp, a.outp, a.exp, a.tvp);
+}
+#endif
+
 struct poll_list {
 	struct poll_list *next;
 	int len;

Index: linux-2.6/fs/compat.c
===================================================================

fs/compat.c +18 -0

@@ -1795,6 +1795,24 @@ asmlinkage long compat_sys_select(int n,
 	return ret;
 }
 
+struct compat_sel_arg_struct {
+	compat_ulong_t n;
+	compat_ulong_t inp;
+	compat_ulong_t outp;
+	compat_ulong_t exp;
+	compat_ulong_t tvp;
+};
+
+asmlinkage long compat_sys_old_select(struct compat_sel_arg_struct __user *arg)
+{
+	struct compat_sel_arg_struct a;
+
+	if (copy_from_user(&a, arg, sizeof(a)))
+		return -EFAULT;
+	return compat_sys_select(a.n, compat_ptr(a.inp), compat_ptr(a.outp),
+				 compat_ptr(a.exp), compat_ptr(a.tvp));
+}
+
 #ifdef HAVE_SET_RESTORE_SIGMASK
 static long do_compat_pselect(int n, compat_ulong_t __user *inp,
 	compat_ulong_t __user *outp, compat_ulong_t __user *exp,

Signature · 4 lines

Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

Christoph Hellwig

author

2010-01-06 17:35 UTC #2 lore raw

Quoted 6 lines · Matthew Wilcox

Quoted 2 lines · Christoph Hellwig
Add a generic implementation of the old select syscall, which expects it's argument in a memory block and switch all architectures over to use it.
Don't we want an ifdef around compat_sys_old_select() like the one around sys_old_select()?

Because nothing in compat.c does it. If we want to bother saving those few bites we should do it for more functions, and in a consistant way.

Al Viro

maintainer

2010-01-06 17:41 UTC #3 lore raw

Quoted 10 lines · Christoph Hellwig

Quoted 6 lines · Matthew Wilcox
Quoted 2 lines · Christoph Hellwig
Add a generic implementation of the old select syscall, which expects it's argument in a memory block and switch all architectures over to use it.
Don't we want an ifdef around compat_sys_old_select() like the one around sys_old_select()?
Because nothing in compat.c does it. If we want to bother saving those few bites we should do it for more functions, and in a consistant way.

Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead of cluttering fs/select.c with that. Objections?

H. Peter Anvin

reviewer

2010-01-06 17:54 UTC #4 lore raw

Quoted 6 lines · Al Viro

Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · Matthew Wilcox
Quoted 2 lines · Christoph Hellwig
Add a generic implementation of the old select syscall, which expects it's argument in a memory block and switch all architectures over to use it.

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Don't we want an ifdef around compat_sys_old_select() like the one around sys_old_select()?
Because nothing in compat.c does it. If we want to bother saving those few bites we should do it for more functions, and in a consistant way.
Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead of cluttering fs/select.c with that. Objections?

I'd prefer a toplevel directory, syscall/ or libsyscall/, instead of hiding it under lib/ -- I really wouldn't expect to find full syscall implementations under lib/ -- but otherwise the idea makes sense.

-hpa

Signature · 2 lines

H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

Christoph Hellwig

author

2010-01-08 09:33 UTC #5 lore raw

In reply to Al Viro

Quoted 2 lines · Al Viro

Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead of cluttering fs/select.c with that. Objections?

If we do that let's do it consistantly for various old syscalls, not an odd one out.

H. Peter Anvin

reviewer

2010-01-08 22:28 UTC #6 lore raw

Quoted 6 lines · Christoph Hellwig

Quoted 2 lines · Al Viro
Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead of cluttering fs/select.c with that. Objections?
If we do that let's do it consistantly for various old syscalls, not an odd one out.

Yes, and it would be a good idea to do so, rather than hiding all these compatibility calls in all kind of random places.

There is, however, a reason *not* to do it which should be carefully
considered: by co-locating the compatibility version with the modern version, it gets access to static functions that are part of the implementation of the modern version. If we move the compatibility versions out, it may entail having to export those statics.

-hpa

Al Viro

maintainer

2010-01-10 04:50 UTC #7 lore raw

Quoted 11 lines · H. Peter Anvin

Quoted 2 lines
If we do that let's do it consistantly for various old syscalls, not an odd one out.
Yes, and it would be a good idea to do so, rather than hiding all these compatibility calls in all kind of random places.
There is, however, a reason *not* to do it which should be carefully
considered: by co-locating the compatibility version with the modern version, it gets access to static functions that are part of the implementation of the modern version. If we move the compatibility versions out, it may entail having to export those statics.

So we don't move such ones... I agree that it's a separate patch queue, BTW.

David Howells

Acked-by on v1 1/3

2010-01-06 17:45 UTC #8 lore raw

In reply to Christoph Hellwig

Quoted 5 lines · Christoph Hellwig

Add a generic implementation of the old select syscall, which expects it's argument in a memory block and switch all architectures over to use it.
Signed-off-by Christoph Hellwig <[email protected]>

Acked-by David Howells <[email protected]> [for MN10300]