why ms->pmsa_xip is used?
Hi,
I have a question about how to restore cr_{iip,ipsr,ifs} register in the INIT handler.
This is a part of ia64_mca_modify_original_stack().
/* If ipsr.ic then use pmsa_{iip,ipsr,ifs}, else use
* pmsa_{xip,xpsr,xfs}
*/
if (ia64_psr(regs)->ic) {
old_regs->cr_iip = ms->pmsa_iip;
old_regs->cr_ipsr = ms->pmsa_ipsr;
old_regs->cr_ifs = ms->pmsa_ifs;
} else {
old_regs->cr_iip = ms->pmsa_xip;
old_regs->cr_ipsr = ms->pmsa_xpsr;
old_regs->cr_ifs = ms->pmsa_xfs;
}Does anybody know why ms->pmsa_{xip,xpsr,xfs} are used instead of ms->pmsa_{iip,ipsr,ifs} when PSR.ic is 0?
What we want to do here is to modify the original stack so it looks as if it's interrupted by INIT, right? In my understainding, if PSR.ic is 0, pmsa_iip has the value of IP register and pmsa_xip has the value of IIP register. In other words, the value of pmsa_iip is where INIT handler returns to, and the value of pmsa_xip is where interruption handler (not INIT handler) returns to. So, to create pt_regs which has the state at the time of interrupt by INIT, ms->pmsa_iip should be used when PSR.ic is 0, I think. My understanding is correct?
Thanks,
Takao Indoh
Quoted 20 lines · Takao Indoh
Hi,
I have a question about how to restore cr_{iip,ipsr,ifs} register in the INIT handler.
This is a part of
ia64_mca_modify_original_stack()./* If ipsr.ic then use pmsa_{iip,ipsr,ifs}, else use * pmsa_{xip,xpsr,xfs} */ if (ia64_psr(regs)->ic) { old_regs->cr_iip = ms->pmsa_iip; old_regs->cr_ipsr = ms->pmsa_ipsr; old_regs->cr_ifs = ms->pmsa_ifs; } else { old_regs->cr_iip = ms->pmsa_xip; old_regs->cr_ipsr = ms->pmsa_xpsr; old_regs->cr_ifs = ms->pmsa_xfs; }
Quoted 2 lines
Does anybody know why ms->pmsa_{xip,xpsr,xfs} are used instead of ms->pmsa_{iip,ipsr,ifs} when PSR.ic is 0?
That's my code. Take a look at "OS Machine Check Recovery on Itanium Based Systems", http://download.intel.com/design/itanium/320482.pdf.
Section 2.5, Min-State Save Area I-Resources and X-Resources.
On an interruption (either PAL-based or IVA-based), the processor stores architectural state to the I-resources (IIP, IPSR, IIM, and IFS). During interrupt handling, interrupt collection is masked with PSR.ic = 0, but PSR.mc = 1 and machine check aborts can be delivered.
To permit error recovery when PSR.ic = 0, current Itanium processor implementations provide optional X-resources (XIP, XPSR, XFS, XR0 Â XR4). (Availability of X-resources on a processor implementation can be identified using PAL_PROC_GET_FEATURE bits 41 and 42.) If an MCA occurs while PSR.ic = 0, the I-resources are saved to the X-resources and the processor state at the time of the MCA is stored to the I-resources.
The PAL MCA handler will copy I-resources and X-resources to the min-state save area. SAL_CHECK saves the min-state save area to NVRAM in the processor error section and provides the error record to OS_MCA when SAL_GET_STATE_INFO is called. OS_MCA can determine if an interruption was in progress at the time of the MCA by examining IPSR.ic. If IPSR.ic = 0, the X-resources provide information about the processor state at the time the original interruption was taken. If IPSR.ic = 1, the X-resources are undefined.
Quoted 8 lines
What we want to do here is to modify the original stack so it looks as if it's interrupted by INIT, right? In my understainding, if PSR.ic is 0,
pmsa_iiphas the value of IP register andpmsa_xiphas the value of IIP register. In other words, the value ofpmsa_iipis where INIT handler returns to, and the value ofpmsa_xipis where interruption handler (not INIT handler) returns to. So, to creatept_regswhich has the state at the time of interrupt by INIT,ms->pmsa_iipshould be used when PSR.ic is 0, I think. My understanding is correct?
According to the extract above, ia64 MCA handler should always be using pmsa_iip, it is meant to be the IP at the time of the MCA. I vaguely remember a test where I created an MCA with interrupts disabled and finding that I needed to use pmsa_xip, but that was a long time ago and I could be remembering it wrong. I no longer have access to ia64 equipment so I cannot test this. If your tests show that pmsa_iip is valid when psr.ic = 0 then please change the code.
Quoted 60 lines · Keith Owens
Quoted 20 lines · Takao Indoh
Hi,
I have a question about how to restore cr_{iip,ipsr,ifs} register in the INIT handler.
This is a part of
ia64_mca_modify_original_stack()./* If ipsr.ic then use pmsa_{iip,ipsr,ifs}, else use * pmsa_{xip,xpsr,xfs} */ if (ia64_psr(regs)->ic) { old_regs->cr_iip = ms->pmsa_iip; old_regs->cr_ipsr = ms->pmsa_ipsr; old_regs->cr_ifs = ms->pmsa_ifs; } else { old_regs->cr_iip = ms->pmsa_xip; old_regs->cr_ipsr = ms->pmsa_xpsr; old_regs->cr_ifs = ms->pmsa_xfs; }Quoted 2 lines
Does anybody know why ms->pmsa_{xip,xpsr,xfs} are used instead of ms->pmsa_{iip,ipsr,ifs} when PSR.ic is 0?
That's my code. Take a look at "OS Machine Check Recovery on Itanium Based Systems", http://download.intel.com/design/itanium/320482.pdf.
Section 2.5, Min-State Save Area I-Resources and X-Resources.On an interruption (either PAL-based or IVA-based), the processor stores architectural state to the I-resources (IIP, IPSR, IIM, and IFS). During interrupt handling, interrupt collection is masked with PSR.ic = 0, but PSR.mc = 1 and machine check aborts can be delivered.
To permit error recovery when PSR.ic = 0, current Itanium processor implementations provide optional X-resources (XIP, XPSR, XFS, XR0 - XR4). (Availability of X-resources on a processor implementation can be identified using
PAL_PROC_GET_FEATUREbits 41 and 42.) If an MCA occurs while PSR.ic = 0, the I-resources are saved to the X-resources and the processor state at the time of the MCA is stored to the I-resources.The PAL MCA handler will copy I-resources and X-resources to the min-state save area.
SAL_CHECKsaves the min-state save area to NVRAM in the processor error section and provides the error record toOS_MCAwhenSAL_GET_STATE_INFOis called.OS_MCAcan determine if an interruption was in progress at the time of the MCA by examining IPSR.ic. If IPSR.ic = 0, the X-resources provide information about the processor state at the time the original interruption was taken. If IPSR.ic = 1, the X-resources are undefined.Quoted 8 lines
What we want to do here is to modify the original stack so it looks as if it's interrupted by INIT, right? In my understainding, if PSR.ic is 0,
pmsa_iiphas the value of IP register andpmsa_xiphas the value of IIP register. In other words, the value ofpmsa_iipis where INIT handler returns to, and the value ofpmsa_xipis where interruption handler (not INIT handler) returns to. So, to creatept_regswhich has the state at the time of interrupt by INIT,ms->pmsa_iipshould be used when PSR.ic is 0, I think. My understanding is correct?
Quoted 7 lines
According to the extract above, ia64 MCA handler should always be using
pmsa_iip, it is meant to be the IP at the time of the MCA. I vaguely remember a test where I created an MCA with interrupts disabled and finding that I needed to usepmsa_xip, but that was a long time ago and I could be remembering it wrong. I no longer have access to ia64 equipment so I cannot test this. If your tests show thatpmsa_iipis valid when psr.ic = 0 then please change the code.
To confirm this, I inserted debug code like this:
arch/ia64/kernel/irq_ia64.c 2009-10-23 11:32:03.000000000 -0400 renamed from arch/ia64/kernel/irq_ia64.c 2009-10-22 12:28:07.000000000 -0400 +5 -0
@@ -453,7 +453,12 @@ ia64_handle_irq (ia64_vector vector, str { struct pt_regs *old_regs = set_irq_regs(regs); unsigned long saved_tpr; + extern int debug; + if (debug) { + ia64_clear_ic(); + while(1); + } #if IRQ_DEBUG { unsigned long bsp, sp;
After kernel hung, I sent INIT and took a vmcore by kdump to check a value of pmsa_iip and pmsa_xip. Here is the result.
CPU0
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0xa000000100183800 <vfs_write+704>
CPU1
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0xa0000001006c3430 <_spin_unlock_irqrestore+48>
CPU2
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0xa00000010032ab20 <__copy_user+288>
CPU3
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0xa00000010010dff0 <find_get_page+208>
CPU4
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0x4000000000003180 <IN USER SPACE>
CPU5
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0xa000000000010720 <__kernel_syscall_via_break>
CPU6
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0xa00000010028e460 <cap_file_permission>
CPU7
pmsa_iip = 0xa000000100013270 <ia64_handle_irq+144>
pmsa_xip = 0xa000000100194ba0 <path_put>As Intel manual says, it seems that pmsa_iip has a value of ip register where INIT interrupted when psr.ic is 0. Ok, I'll make a patch so that pmsa_iip is used irrespective of a value of psr.ic.
Please let me know if I need to confirm something else before I make a patch.
Thanks,
Takao Indoh
Quoted 6 lines · Takao Indoh
As Intel manual says, it seems that
pmsa_iiphas a value of ip register where INIT interrupted when psr.ic is 0. Ok, I'll make a patch so thatpmsa_iipis used irrespective of a value of psr.ic.Please let me know if I need to confirm something else before I make a patch.
That looks good. The only problem I can think of is an MCA/INIT arriving while code like SAVE_MIN or SAVE_REST is executing. Back tracing at that point using pmsa_iip is going to be a problem, you have no idea what state the registers or stack are in.
Quoted 6 lines · Keith Owens
Quoted 4 lines · Takao Indoh
As Intel manual says, it seems that
pmsa_iiphas a value of ip register where INIT interrupted when psr.ic is 0. Ok, I'll make a patch so thatpmsa_iipis used irrespective of a value of psr.ic.
Quoted 7 lines
Quoted 2 lines
Please let me know if I need to confirm something else before I make a patch.
That looks good. The only problem I can think of is an MCA/INIT arriving while code like
SAVE_MINorSAVE_RESTis executing. Back tracing at that point usingpmsa_iipis going to be a problem, you have no idea what state the registers or stack are in.
I inserted another debug code into IA64_NATIVE_DO_SAVE_MIN to send INIT during SAVE_MIN.
arch/ia64/kernel/minstate.h 2009-10-27 12:42:02.000000000 -0400 renamed from arch/ia64/kernel/minstate.h 2009-10-22 12:28:07.000000000 -0400 +8 -0
@@ -55,6 +55,14 @@ mov r21=ar.fpsr; /* M */ \ __COVER; /* B;; (or nothing) */ \ ;; \ + movl r24Þbug_flag; \ + ;; \ + ld8 r23=[r24]; \ + ;; \ + cmp.eq p2,p3=0,r23; \ +(p2) br.sptk 2f; \ +1: br.sptk 1b; \ +2: \ adds r16=IA64_TASK_THREAD_ON_USTACK_OFFSET,r16; \ ;; \ ld1 r17=[r16]; /* load current->thread.on_ustack flag */ \
As a result, backtrace in the case using xip works, and backtrace in the case using iip does NOT work, as you said. Hm, it seems that I have to reconsider how to fix.
Thanks,
Takao Indoh
Quoted 38 lines · Takao Indoh
Quoted 6 lines · Keith Owens
Quoted 4 lines · Takao Indoh
As Intel manual says, it seems that
pmsa_iiphas a value of ip register where INIT interrupted when psr.ic is 0. Ok, I'll make a patch so thatpmsa_iipis used irrespective of a value of psr.ic.Quoted 7 lines
Quoted 2 lines
Please let me know if I need to confirm something else before I make a patch.
That looks good. The only problem I can think of is an MCA/INIT arriving while code like
SAVE_MINorSAVE_RESTis executing. Back tracing at that point usingpmsa_iipis going to be a problem, you have no idea what state the registers or stack are in.I inserted another debug code into
IA64_NATIVE_DO_SAVE_MINto send INIT duringSAVE_MIN.diff -Nurp
a/arch/ia64/kernel/minstate.hb/arch/ia64/kernel/minstate.harch/ia64/kernel/minstate.h 2009-10-27 12:42:02.000000000 -0400 renamed from arch/ia64/kernel/minstate.h 2009-10-22 12:28:07.000000000 -0400 +8
-0@@ -55,6 +55,14 @@ mov r21=ar.fpsr; /* M */ \ __COVER; /* B;; (or nothing) */ \ ;; \ + movl r24Þbug_flag; \ + ;; \ + ld8 r23=[r24]; \ + ;; \ + cmp.eq p2,p3=0,r23; \ +(p2) br.sptk 2f; \ +1: br.sptk 1b; \ +2: \ adds r16=IA64_TASK_THREAD_ON_USTACK_OFFSET,r16; \ ;; \ ld1 r17=[r16]; /* load current->thread.on_ustack flag */ \
Quoted 3 lines
As a result, backtrace in the case using xip works, and backtrace in the case using iip does NOT work, as you said. Hm, it seems that I have to reconsider how to fix.
Now I think it's better to keep it as-is, I mean, use pmsa_{xip,xpsr,xfs} if PSR.ic is 0. Instead of that, I'd like to save pmsa_{iip,ipsr,ifs} somewhere for debugging. For example,
arch/ia64/include/asm/mca.h +5 -0
@@ -106,6 +106,11 @@ struct ia64_sal_os_state {unsigned long os_status;/* OS status to SAL, enum below */ unsigned long context;/* 0 if return to same context 1 if return to new context */ + +/* I-resources */ +unsigned long iip; +unsigned long ipsr; +unsigned long ifs; };enum {
arch/ia64/kernel/mca.c +6 -1
@@ -888,9 +888,10 @@ ia64_mca_modify_comm(const struct task_s }static void -finish_pt_regs (struct pt_regs *regs,const pal_min_state_area_t *ms, +finish_pt_regs (struct pt_regs *regs,struct ia64_sal_os_state *sos,unsigned long *nat) { +const pal_min_state_area_t *ms = sos->pal_min_state;const u64 *bank;/* If ipsr.ic then use pmsa_{iip,ipsr,ifs}, else use
@@ -904,6 +905,10 @@ finish_pt_regs(struct pt_regs *regs, con regs->cr_iip = ms->pmsa_xip; regs->cr_ipsr = ms->pmsa_xpsr; regs->cr_ifs = ms->pmsa_xfs; + + sos->iip = ms->pmsa_iip; + sos->ipsr = ms->pmsa_ipsr; + sos->ifs = ms->pmsa_ifs; } regs->pr = ms->pmsa_pr; regs->b0 = ms->pmsa_br0;
(snip)
Any idea or comments?
Thanks,
Takao Indoh
Quoted 47 lines · Takao Indoh
Now I think it's better to keep it as-is, I mean, use pmsa_{xip,xpsr,xfs} if PSR.ic is 0. Instead of that, I'd like to save pmsa_{iip,ipsr,ifs} somewhere for debugging. For example,
diff -Nurp
a/arch/ia64/include/asm/mca.hb/arch/ia64/include/asm/mca.harch/ia64/include/asm/mca.h +5
-0@@ -106,6 +106,11 @@ struct ia64_sal_os_state {unsigned long os_status;/* OS status to SAL, enum below */ unsigned long context;/* 0 if return to same context 1 if return to new context */ + +/* I-resources */ +unsigned long iip; +unsigned long ipsr; +unsigned long ifs; };enum {diff -Nurp
a/arch/ia64/kernel/mca.cb/arch/ia64/kernel/mca.carch/ia64/kernel/mca.c +0
-0@@ -888,9 +888,10 @@ ia64_mca_modify_comm(const struct task_s }static void
arch/ia64/kernel/mca.c +1
-1-finish_pt_regs(struct pt_regs *regs, const pal_min_state_area_t *ms, +finish_pt_regs(struct pt_regs *regs, struct ia64_sal_os_state *sos,unsigned long *nat)
{arch/ia64/kernel/mca.c +1
-0+const pal_min_state_area_t *ms = sos->pal_min_state;const u64 *bank; /* If ipsr.ic then use pmsa_{iip,ipsr,ifs}, else usearch/ia64/kernel/mca.c +4
-0@@ -904,6 +905,10 @@ finish_pt_regs(struct pt_regs *regs, con regs->cr_iip = ms->pmsa_xip; regs->cr_ipsr = ms->pmsa_xpsr; regs->cr_ifs = ms->pmsa_xfs; + + sos->iip = ms->pmsa_iip; + sos->ipsr = ms->pmsa_ipsr; + sos->ifs = ms->pmsa_ifs; } regs->pr = ms->pmsa_pr; regs->b0 = ms->pmsa_br0;
Quoted 1 line
Any idea or comments?
Looks good to me.