ACPI: GTDT: Get rid of acpi_arch_timer_mem_init()
Subsystems (2)
PATCH 1/1 ACPI: GTDT: Get rid of acpi_arch_timer_mem_init()
Since 0f67b56d84b4c ("clocksource/drivers/arm_arch_timer_mmio: Switch over to standalone driver"), acpi_arch_timer_mem_init() is unused.
Remove it.
--- drivers/acpi/arm64/gtdt.c | 34 ---------------------------------- include/linux/acpi.h | 1 - 2 files changed, 35 deletions(-)
drivers/acpi/arm64/gtdt.c +0 -34
@@ -303,40 +303,6 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,return -EINVAL ; } -/** -* acpi_arch_timer_mem_init() - Get the info of all GT blocks in GTDT table. -* @timer_mem: The pointer to the array of struct arch_timer_mem for returning -* the result of parsing. The element number of this array should -* be platform_timer_count(the total number of platform timers). -* @timer_count: It points to a integer variable which is used for storing the -* number of GT blocks we have parsed. -* -* Return: 0 if success, -EINVAL/-ENODEV if error. -*/ -int __init acpi_arch_timer_mem_init (struct arch_timer_mem *timer_mem, -int *timer_count) -{ -int ret; -void *platform_timer; - - *timer_count =0 ; -for_each_platform_timer (platform_timer) { -if (is_timer_block (platform_timer)) { - ret =gtdt_parse_timer_block (platform_timer, timer_mem); -if (ret) -return ret; - timer_mem++; - (*timer_count)++; - } - } - -if (*timer_count) -pr_info ("found %d memory-mapped timer block(s).\n" , - *timer_count); - -return 0 ; -} -/* * Initialize a SBSA generic Watchdog platform device info from GTDT */
include/linux/acpi.h +0 -1
@@ -755,7 +755,6 @@ int acpi_reconfig_notifier_unregister(struct notifier_block *nb);int acpi_gtdt_init (struct acpi_table_header *table,int *platform_timer_count);int acpi_gtdt_map_ppi (int type);bool acpi_gtdt_c3stop (int type); -int acpi_arch_timer_mem_init (struct arch_timer_mem *timer_mem,int *timer_count);#endif #ifndef ACPI_HAVE_ARCH_SET_ROOT_POINTER
Signature · 1 line
2.47.3
Quoted 80 lines · Marc Zyngier
Since
0f67b56d84b4c("clocksource/drivers/arm_arch_timer_mmio: Switch over to standalone driver"),acpi_arch_timer_mem_init()is unused.Remove it.
Signed-off-by Marc Zyngier <[email protected]>Cc Hanjun Guo <[email protected]>Cc Sudeep Holla <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Daniel Lezcano <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Mark Rutland <[email protected]>--- drivers/acpi/arm64/gtdt.c | 34 ---------------------------------- include/linux/acpi.h | 1 - 2 files changed, 35 deletions(-)drivers/acpi/arm64/gtdt.c +0
-2@@ -303,40 +303,6 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block, return -EINVAL ; } -/** -* acpi_arch_timer_mem_init() - Get the info of all GT blocks in GTDT table.
- * @timer_mem: The pointer to the array of structarch_timer_memfor
returning
- * the result of parsing. The element number of this array should
- * beplatform_timer_count(the total number of platform timers).
- * @timer_count: It points to a integer variable which is used for storing the
- * number of GT blocks we have parsed.
- *
- * Return: 0 if success, -EINVAL/-ENODEV if error.
- */drivers/acpi/arm64/gtdt.c +0
-24-int __init acpi_arch_timer_mem_init (struct arch_timer_mem *timer_mem, -int *timer_count) -{ -int ret; -void *platform_timer; - - *timer_count =0 ; -for_each_platform_timer (platform_timer) { -if (is_timer_block (platform_timer)) { - ret =gtdt_parse_timer_block (platform_timer, timer_mem); -if (ret) -return ret; - timer_mem++; - (*timer_count)++; - } - } - -if (*timer_count) -pr_info ("found %d memory-mapped timer block(s).\n" , - *timer_count); - -return 0 ; -} -/* * Initialize a SBSA generic Watchdog platform device info from GTDT */ include/linux/acpi.h +0
-1@@ -755,7 +755,6 @@ int acpi_reconfig_notifier_unregister(struct notifier_block *nb);int acpi_gtdt_init (struct acpi_table_header *table,int *platform_timer_count);int acpi_gtdt_map_ppi (int type);bool acpi_gtdt_c3stop (int type); -int acpi_arch_timer_mem_init (struct arch_timer_mem *timer_mem,int *timer_count);#endif
Quoted 1 line
#ifndef
ACPI_HAVE_ARCH_SET_ROOT_POINTER
This isn't urgent, but would be a good 6.19 candidate.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Quoted 7 lines · Marc Zyngier
Since
0f67b56d84b4c("clocksource/drivers/arm_arch_timer_mmio: Switch over to standalone driver"),acpi_arch_timer_mem_init()is unused.Remove it.
Signed-off-by Marc Zyngier <[email protected]>Cc Hanjun Guo <[email protected]>
Thanks
Hanjun
Quoted 6 lines · Marc Zyngier
Since
0f67b56d84b4c("clocksource/drivers/arm_arch_timer_mmio: Switch over to standalone driver"),acpi_arch_timer_mem_init()is unused.Remove it.
Applied to arm64 (for-next/acpi), thanks!
[1/1] ACPI: GTDT: Get rid of acpi_arch_timer_mem_init()
https://git.kernel.org/arm64/c/155f8d4ef0b7
Signature · 5 lines
Catalin -- Catalin