Skip to contentSkip to conversation

defer/rcuintro: Tweak appearance of new Table 9.1

PATCH In review Akira Yokosawa 2 participants 2 messages Jan 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 defer/rcuintro: Tweak appearance of new Table 9.1

Shrink the table width so that it can fit in 1c and eb builds. Overall appearance is based on Table D.8 in Style Guide.

---
 defer/rcuintro.tex | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
defer/rcuintro.tex +9 -6
index dbea667f..db87b9f6 100644
@@ -235,22 +235,24 @@ to initialize the pointed-to structure.
 }\QuickQuizEnd
 
 \begin{table*}
-\renewcommand*{\arraystretch}{1.15}
-\footnotesize
+\renewcommand*{\arraystretch}{1.25}
+\rowcolors{2}{}{lightgray}
+\small
 \centering
-\begin{tabular}{lll}
+\ebresizewidth{
+\begin{tabular}{llp{2.4in}}
 \toprule
 &
 	Primitive &
 		Purpose \\
 \midrule
-\emph{Readers} &
+\cellcolor{white}\emph{Readers} &
 	\tco{rcu_read_lock()} &
 		Start an RCU read-side critical section. \\
 &
 	\tco{rcu_read_unlock()} &
 		End an RCU read-side critical section. \\
-&
+\cellcolor{white}&
 	\tco{rcu_dereference()} &
 		Safely load an RCU-protected pointer. \\
 \midrule
@@ -258,7 +260,7 @@ to initialize the pointed-to structure.
 	\tco{synchronize_rcu()} &
 		Wait for all pre-existing RCU read-side critical sections to
 		complete. \\
-&
+\cellcolor{white}&
 	\tco{call_rcu()} &
 		Invoke the specified function after all pre-existing RCU read-side
 		critical sections complete. \\
@@ -267,6 +269,7 @@ to initialize the pointed-to structure.
 		Safely update an RCU-protected pointer. \\
 \bottomrule
 \end{tabular}
+}
 \caption{RCU Core API}
 \label{tab:defer:RCU Core API}
 \end{table*}

base-commit: f21271f0939bb620a95b1bb3d76ac0259c4bb54c

Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Akira Yokosawa

Shrink the table width so that it can fit in 1c and eb builds. Overall appearance is based on Table D.8 in Style Guide.

The addition of the grey highlighting is also nice, thank you!

Queued and pushed.

Thanx, Paul

Quoted 60 lines
---
 defer/rcuintro.tex | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
defer/rcuintro.tex +9 -6
index dbea667f..db87b9f6 100644
@@ -235,22 +235,24 @@ to initialize the pointed-to structure.
 }\QuickQuizEnd
 
 \begin{table*}
-\renewcommand*{\arraystretch}{1.15}
-\footnotesize
+\renewcommand*{\arraystretch}{1.25}
+\rowcolors{2}{}{lightgray}
+\small
 \centering
-\begin{tabular}{lll}
+\ebresizewidth{
+\begin{tabular}{llp{2.4in}}
 \toprule
 &
 	Primitive &
 		Purpose \\
 \midrule
-\emph{Readers} &
+\cellcolor{white}\emph{Readers} &
 	\tco{rcu_read_lock()} &
 		Start an RCU read-side critical section. \\
 &
 	\tco{rcu_read_unlock()} &
 		End an RCU read-side critical section. \\
-&
+\cellcolor{white}&
 	\tco{rcu_dereference()} &
 		Safely load an RCU-protected pointer. \\
 \midrule
@@ -258,7 +260,7 @@ to initialize the pointed-to structure.
 	\tco{synchronize_rcu()} &
 		Wait for all pre-existing RCU read-side critical sections to
 		complete. \\
-&
+\cellcolor{white}&
 	\tco{call_rcu()} &
 		Invoke the specified function after all pre-existing RCU read-side
 		critical sections complete. \\
@@ -267,6 +269,7 @@ to initialize the pointed-to structure.
 		Safely update an RCU-protected pointer. \\
 \bottomrule
 \end{tabular}
+}
 \caption{RCU Core API}
 \label{tab:defer:RCU Core API}
 \end{table*}

base-commit: f21271f0939bb620a95b1bb3d76ac0259c4bb54c

Signature · 1 line
2.17.1