spi: bcm53xx: add BCMA dependency
PATCH 1/1 spi: bcm53xx: add BCMA dependency
The BCMA bus framework can be disabled on bcm53xx, which leads to a link error when building the SPI driver:
drivers/built-in.o: In function `bcm53xxspi_module_init':
:(.init.text+0x76d4): undefined reference to __bcma_driver_register' drivers/built-in.o: In function bcm53xxspi_module_exit':
:(.exit.text+0x10fe): undefined reference to `bcma_driver_unregister'
To avoid that, this adds an explicit dependency on BCMA. While we're changing the dependencies, let's also add a COMPILE_TEST option, which will of course not have any effect unless building on another machine that has BCMA enabled.
drivers/spi/Kconfig +2 -1
@@ -115,7 +115,8 @@ config SPI_AU1550 config SPI_BCM53XX tristate "Broadcom BCM53xx SPI controller" - depends on ARCH_BCM_5301X + depends on ARCH_BCM_5301X || COMPILE_TEST + depends on BCMA help Enable support for the SPI controller on Broadcom BCM53xx ARM SoCs.
Quoted 2 lines · Arnd Bergmann
The BCMA bus framework can be disabled on bcm53xx, which leads to a link error when building the SPI driver:
You missed this one:
https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=933fc7b06ca62741fd5067edab13068d13b3cb35
Quoted 7 lines · On Tuesday 30 September 2014 14:13:35 Rafa? Mi?ecki wrote:
Quoted 2 lines · Arnd Bergmann
The BCMA bus framework can be disabled on bcm53xx, which leads to a link error when building the SPI driver:
You missed this one:
https://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=933fc7b06ca62741fd5067edab13068d13b3cb35
Right, I'm still catching up with last week's build regressions.
Arnd