Skip to contentSkip to conversation

OneNAND: Use address instead block, page in bufferram

PATCH In review Kyungmin Park 2 participants 2 messages Jan 9, 2007 – Jan 10, 2007

Subsystems (3)
lore
Share & tools
lore

Kyungmin Park

author maintainer
#0 lore raw

PATCH 1/1 OneNAND: Use address instead block, page in bufferram

[PATCH] OneNAND: Use address instead of block, page in bufferram

we use the address itself instead of block, page in bufferam.

--

@@ -587,19 +601,18 @@ static int onenand_write_bufferram(struct mtd_info *mtd, int area,
static int onenand_check_bufferram(struct mtd_info *mtd, loff_t addr)
{
struct onenand_chip *this = mtd->priv;
- int block, page;
int i;
+#ifdef DEBUG_BUFFERRAM
+ int block, page;

block = (int) (addr >> this->erase_shift);
- page = (int) (addr >> this->page_shift);
- page &= this->page_mask;
+ page = (int) (addr >> this->page_shift) & this->page_mask;
+#endif

i = ONENAND_CURRENT_BUFFERRAM(this);

/* Is there valid data? */
- if (this->bufferram[i].block == block &&
- this->bufferram[i].page == page &&
- this->bufferram[i].valid)
+ if (this->bufferram[i].addr == addr && this->bufferram[i].valid)
return 1;

return 0;
@@ -617,24 +630,25 @@ static int onenand_update_bufferram(struct mtd_info *mtd, loff_t addr,
int valid)
{
struct onenand_chip *this = mtd->priv;
- int block, page;
int i;
+#ifdef DEBUG_BUFFERRAM
+ int block, page;

block = (int) (addr >> this->erase_shift);
- page = (int) (addr >> this->page_shift);
- page &= this->page_mask;
+ page = (int) (addr >> this->page_shift) & this->page_mask;
+#endif

/* Invalidate BufferRAM */
for (i = 0; i < MAX_BUFFERRAM; i++) {
- if (this->bufferram[i].block == block &&
- this->bufferram[i].page == page)
+ if (this->bufferram[i].addr == addr) {
this->bufferram[i].valid = 0;
+ break;
+ }
}

/* Update BufferRAM */
i = ONENAND_CURRENT_BUFFERRAM(this);
- this->bufferram[i].block = block;
- this->bufferram[i].page = page;
+ this->bufferram[i].addr = addr;
this->bufferram[i].valid = valid;

return 0;

include/linux/mtd/onenand.h +2 -3
index f775a7a..46e052f 100644
@@ -47,9 +47,8 @@ typedef enum {
  * @valid:		valid flag
  */
 struct onenand_bufferram {
-	int block;
-	int page;
-	int valid;
+	loff_t		addr;
+	int		valid;
 };
 
 /**
#1 lore raw
Quoted 83 lines · ext Kyungmin Park

[PATCH] OneNAND: Use address instead of block, page in bufferram

we use the address itself instead of block, page in bufferam.

--

(quoted diff) +13 -13
@@ -587,19 +601,18 @@ static int onenand_write_bufferram(struct mtd_info *mtd, int area,
 static int onenand_check_bufferram(struct mtd_info *mtd, loff_t addr)
 {
 	struct onenand_chip *this = mtd->priv;
-	int block, page;
 	int i;
+#ifdef DEBUG_BUFFERRAM
+	int block, page;
 
 	block = (int) (addr >> this->erase_shift);
-	page = (int) (addr >> this->page_shift);
-	page &= this->page_mask;
+	page = (int) (addr >> this->page_shift) & this->page_mask;
+#endif
 
 	i = ONENAND_CURRENT_BUFFERRAM(this);
 
 	/* Is there valid data? */
-	if (this->bufferram[i].block == block &&
-	    this->bufferram[i].page == page &&
-	    this->bufferram[i].valid)
+	if (this->bufferram[i].addr == addr && this->bufferram[i].valid)
 		return 1;
 
 	return 0;
@@ -617,24 +630,25 @@ static int onenand_update_bufferram(struct mtd_info *mtd, loff_t addr,
 		int valid)
 {
 	struct onenand_chip *this = mtd->priv;
-	int block, page;
 	int i;
+#ifdef DEBUG_BUFFERRAM
+	int block, page;
 
 	block = (int) (addr >> this->erase_shift);
-	page = (int) (addr >> this->page_shift);
-	page &= this->page_mask;
+	page = (int) (addr >> this->page_shift) & this->page_mask;
+#endif
 
 	/* Invalidate BufferRAM */
 	for (i = 0; i < MAX_BUFFERRAM; i++) {
-		if (this->bufferram[i].block == block &&
-		    this->bufferram[i].page == page)
+		if (this->bufferram[i].addr == addr) {
 			this->bufferram[i].valid = 0;
+			break;
+		}
 	}
 
 	/* Update BufferRAM */
 	i = ONENAND_CURRENT_BUFFERRAM(this);
-	this->bufferram[i].block = block;
-	this->bufferram[i].page = page;
+	this->bufferram[i].addr = addr;
 	this->bufferram[i].valid = valid;
 
 	return 0;
include/linux/mtd/onenand.h +2 -3
index f775a7a..46e052f 100644
@@ -47,9 +47,8 @@ typedef enum {
  * @valid:		valid flag
  */
 struct onenand_bufferram {
-	int block;
-	int page;
-	int valid;
+	loff_t		addr;
+	int		valid;
 };
 
 /**
Quoted 4 lines

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

It seems to me that this patch would cause un-necessary loads. For example:

first read at address 0x00000000
then read at address 0x00000010

The second read would load to bufferRAM because the address is different, even though the page is already there because of the first read.

I am not sure this patch is needed.

Regards
Adrian