Skip to contentSkip to conversation

remote/memory: Replace share parameter with ram_flags

PATCH In review Yang Zhong 2 participants 2 messages Jul 9, 2021

lore
Share & tools
lore

Yang Zhong

author
#0 lore raw

PATCH v3 1/1 remote/memory: Replace share parameter with ram_flags

Fixes d5015b801340 ("softmmu/memory: Pass ram_flags to

qemu_ram_alloc_from_fd()")

---
 hw/remote/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/remote/memory.c +1 -1
index 472ed2a272..6e21ab1a45 100644
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
         subregion = g_new(MemoryRegion, 1);
         memory_region_init_ram_from_fd(subregion, NULL,
                                        name, sysmem_info->sizes[region],
-                                       true, msg->fds[region],
+                                       RAM_SHARED, msg->fds[region],
                                        sysmem_info->offsets[region],
                                        errp);
 
Signature · 1 line
2.29.2.334.gfaefdd61ec
#1 lore raw
Quoted 18 lines · Yang Zhong
Fixes d5015b801340 ("softmmu/memory: Pass ram_flags to

qemu_ram_alloc_from_fd()")

---
  hw/remote/memory.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/remote/memory.c +0 -0
index 472ed2a272..6e21ab1a45 100644

hw/remote/memory.c void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp) · line 52

Quoted 8 lines
hw/remote/memory.c +1 -1
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
          subregion = g_new(MemoryRegion, 1);
          memory_region_init_ram_from_fd(subregion, NULL,
                                         name, sysmem_info->sizes[region],
-                                       true, msg->fds[region],
+                                       RAM_SHARED, msg->fds[region],
                                         sysmem_info->offsets[region],
                                         errp);
 

Just an info: no need to resend for added RBs or ACKs. The maintainer will usually simply pick them up while picking up your patch. :)

Signature · 3 lines
Thanks,

David / dhildenb