Skip to contentSkip to conversation

net/mlx5: fix the counters resource leak

PATCH In review Bing Zhao 2 participants 2 messages Jan 5 – Jan 6 Network drivers

lore
Share & tools
lore

Bing Zhao

author
#0 lore raw

PATCH 1/1 net/mlx5: fix the counters resource leak

The counters that are used to record the dropped packets (including hairpin) are created firstly. Then the counter objects are provided to the command to create the Rx queues, and they are used for the global drop and hairpin queues drop statistics. One counter can be associated with more than one queue in hairpin case.

So the reference count of a counter will be increased once attached to a queue. When closing the device, the queues and counters should be destroyed in the reverse order. The queues should be destroyed firstly in order to decrease the reference count of attached counter properlly. Then the counter can be recycled successfully. Or else the resource will be leaked before the application quits when doing port attach / detach rerepeatedly.

Fixes f0c0731b6d40 ("net/mlx5: add counters for hairpin drop")
---
 drivers/net/mlx5/mlx5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/mlx5.c +1 -1
index decf540c51..bde4d01e48 100644
@@ -2404,7 +2404,6 @@ mlx5_dev_close(struct rte_eth_dev *dev)
 		priv->ptype_rss_groups = NULL;
 	}
 #endif
-	mlx5_q_counters_destroy(dev);
 	if (priv->rxq_privs != NULL) {
 		/* XXX race condition if mlx5_rx_burst() is still running. */
 		rte_delay_us_sleep(1000);
@@ -2425,6 +2424,7 @@ mlx5_dev_close(struct rte_eth_dev *dev)
 	mlx5_proc_priv_uninit(dev);
 	if (priv->drop_queue.hrxq)
 		mlx5_drop_action_destroy(dev);
+	mlx5_q_counters_destroy(dev);
 	mlx5_mprq_free_mp(dev);
 	mlx5_os_free_shared_dr(priv);
 #ifdef HAVE_MLX5_HWS_SUPPORT
Signature · 1 line
2.34.1
#1 lore raw

Hi,

Quoted 14 lines · Bing Zhao

The counters that are used to record the dropped packets (including hairpin) are created firstly. Then the counter objects are provided to the command to create the Rx queues, and they are used for the global drop and hairpin queues drop statistics. One counter can be associated with more than one queue in hairpin case.

So the reference count of a counter will be increased once attached to a queue. When closing the device, the queues and counters should be destroyed in the reverse order. The queues should be destroyed firstly in order to decrease the reference count of attached counter properlly. Then the counter can be recycled successfully. Or else the resource will be leaked before the application quits when doing port attach / detach rerepeatedly.

Quoted 6 lines
Fixes f0c0731b6d40 ("net/mlx5: add counters for hairpin drop")

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh