arm64: dts: kill skeleton.dtsi

PATCH RESEND New Mark Rutland 2 participants 2 messages May 7, 2015 – May 12, 2015 Device tree bindings

Share & tools

Mark Rutland

author

2015-05-07 15:14 UTC #0 lore raw

PATCH RESEND 1/1 arm64: dts: kill skeleton.dtsi

While skeleton.dtsi was initially conceived as a simple way to bootstrap writing a dts, it has proven to be problematic:

* The #address-cells and #size-cells values used in skeleton.dtsi may not match what a user wants (e.g. when they need to describe a range larger than 4GB).

* For dts files where memory nodes have unit-addresses, it adds a redundant /memory node, for which the reg entry may not be appropriately sized (e.g. where #size-cells has been overridden).

* For dts files which assume that a bootloader will fill in the memory node(s), no node is present in the dts (and hence there is no attached comment), making it hard to distinguish these cases from bad dts files, and masking any warnings dtc may produce w.r.t. missing nodes.

* The default empty /chosen and /aliases are somewhat useless, and it would be preferable for dts to fill these in (e.g. for /aliases/serial0 and /chosen/stdout-path).

This patch removes skeleton.dtsi from arm64. There are currently no users, so we can remove it before any appear.

Signed-off-by Mark Rutland <[email protected]>

Acked-by Rob Herring <[email protected]>

Cc Arnd Bergmann <[email protected]>

Cc Catalin Marinas <[email protected]>

Cc Olof Johansson <[email protected]>

Cc Will Deacon <[email protected]>

---
 arch/arm64/boot/dts/skeleton.dtsi | 13 -------------
 1 file changed, 13 deletions(-)
 delete mode 100644 arch/arm64/boot/dts/skeleton.dtsi

Arnd, Olof, are you happy to pick this up for v4.2?

Mark.

arch/arm64/boot/dts/skeleton.dtsi deleted +0 ~~-13~~

deleted file mode 100644
index 38ead82..0000000
@@ -1,13 +0,0 @@
-/*
- * Skeleton device tree; the bare minimum needed to boot; just include and
- * add a compatible value.  The bootloader will typically populate the memory
- * node.
- */
-
-/ {
-	#address-cells = <2>;
-	#size-cells = <1>;
-	chosen { };
-	aliases { };
-	memory { device_type = "memory"; reg = <0 0 0>; };
-};

Signature · 1 line

1.9.1

Arnd Bergmann

Applied

2015-05-12 15:16 UTC #1 lore raw

PATCH RESEND 1/1 arm64: dts: kill skeleton.dtsi

Quoted 29 lines · On Thursday 07 May 2015 16:14:59 Mark Rutland wrote:

While skeleton.dtsi was initially conceived as a simple way to bootstrap writing a dts, it has proven to be problematic:
* The #address-cells and #size-cells values used in skeleton.dtsi may not match what a user wants (e.g. when they need to describe a range larger than 4GB).
* For dts files where memory nodes have unit-addresses, it adds a redundant /memory node, for which the reg entry may not be appropriately sized (e.g. where #size-cells has been overridden).
* For dts files which assume that a bootloader will fill in the memory node(s), no node is present in the dts (and hence there is no attached comment), making it hard to distinguish these cases from bad dts files, and masking any warnings dtc may produce w.r.t. missing nodes.
* The default empty /chosen and /aliases are somewhat useless, and it would be preferable for dts to fill these in (e.g. for /aliases/serial0 and /chosen/stdout-path).
This patch removes skeleton.dtsi from arm64. There are currently no users, so we can remove it before any appear.
Signed-off-by Mark Rutland <[email protected]>
Acked-by Rob Herring <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Olof Johansson <[email protected]>
Cc Will Deacon <[email protected]>

Quoted 8 lines

---
 arch/arm64/boot/dts/skeleton.dtsi | 13 -------------
 1 file changed, 13 deletions(-)
 delete mode 100644 arch/arm64/boot/dts/skeleton.dtsi

Arnd, Olof, are you happy to pick this up for v4.2?

Applied to next/cleanup now, thanks!

Arnd