board: Add Kontron SMARC-sAL28 support
PATCH 1/1 board: Add Kontron SMARC-sAL28 support
From: Michael Walle <[email protected]>
Now that upstream supports this board add buildroot support for it, too.
This supports:
- upstream linux kernel, 5.7-rc4 for now. Once 5.7 is released and buildroot will switch to this kernel BR2_LINUX_KERNEL_CUSTOM_VERSION=y
can be removed.
- building an image which can be installed to eMMC or SD card.
- upstream u-boot patches are pending, therefore no support for building a bootloader for now.
--- DEVELOPERS | 2 ++ board/kontron/smarc-sal28/boot.cmd | 8 ++++++++ board/kontron/smarc-sal28/genimage.cfg | 10 ++++++++++ board/kontron/smarc-sal28/linux.fragment | 14 ++++++++++++++ board/kontron/smarc-sal28/post-build.sh | 9 +++++++++ configs/kontron_smarc_sal28_defconfig | 18 ++++++++++++++++++ 6 files changed, 61 insertions(+) create mode 100644 board/kontron/smarc-sal28/boot.cmd create mode 100644 board/kontron/smarc-sal28/genimage.cfg create mode 100644 board/kontron/smarc-sal28/linux.fragment create mode 100755 board/kontron/smarc-sal28/post-build.sh create mode 100644 configs/kontron_smarc_sal28_defconfig
DEVELOPERS +2 -0
@@ -1837,6 +1837,8 @@ F: package/jasper/ F: package/libstrophe/ N: Michael Walle <[email protected]> +F: board/kontron/smarc-sal28/ +F: configs/kontron_smarc_sal28_defconfig F: package/libavl/ N: Micha? ?yszczek <[email protected]>
board/kontron/smarc-sal28/boot.cmd new file +8 -0
@@ -0,0 +1,8 @@ +setenv bootargs root=/dev/mmcblk${devnum}p1 rootwait ${extrabootargs} +if test -z "${dtb}"; then + setenv dtb fsl-ls1028a-kontron-sl28.dtb +fi + +load ${devtype} ${devnum} ${kernel_addr_r} /boot/Image +load ${devtype} ${devnum} ${fdt_addr_r} /boot/${dtb} +booti ${kernel_addr_r} - ${fdt_addr_r}
board/kontron/smarc-sal28/genimage.cfg new file +10 -0
@@ -0,0 +1,10 @@ +image sdcard-emmc.img { + hdimage { + } + + partition rootfs { + partition-type = 0x83 + offset = 2M + image = rootfs.ext4 + } +}
board/kontron/smarc-sal28/linux.fragment new file +14 -0
@@ -0,0 +1,14 @@ +CONFIG_NET_DSA=m +CONFIG_NET_DSA_TAG_OCELOT=m +CONFIG_NET_DSA_MSCC_FELIX=m +CONFIG_CAN_FLEXCAN=m +CONFIG_FSL_ENETC=y +CONFIG_FSL_ENETC_VF=y +CONFIG_FSL_ENETC_HW_TIMESTAMPING=y +CONFIG_MSCC_OCELOT_SWITCH=m +CONFIG_PCIE_DW_PLAT_HOST=y +CONFIG_GPIO_MPC8XXX=y +CONFIG_SND_SOC_FSL_SAI=m +CONFIG_SND_SOC_WM8904=m +CONFIG_RTC_DRV_RV8803=y +CONFIG_COMMON_CLK_FSL_SAI=y
board/kontron/smarc-sal28/post-build.sh new file +9 -0
@@ -0,0 +1,9 @@ +#!/bin/sh + +MKIMAGE=$HOST_DIR/bin/mkimage +BOARD_DIR="$(dirname $0)" + +# There is a BR2_TARGET_UBOOT_BOOT_SCRIPT option but it is only available +# if we are building u-boot :( Therefore, create the bootsript manually for +# now. +$MKIMAGE -C none -T script -d $BOARD_DIR/boot.cmd $TARGET_DIR/boot/boot.scr
configs/kontron_smarc_sal28_defconfig new file +18 -0
@@ -0,0 +1,18 @@ +BR2_aarch64=y +BR2_cortex_a72=y +BR2_ROOTFS_POST_BUILD_SCRIPT="board/kontron/smarc-sal28/post-build.sh" +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh" +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/kontron/smarc-sal28/genimage.cfg" +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_VERSION=y +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="v5.7-rc4" +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/kontron/smarc-sal28/linux.fragment" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-ls1028a-kontron-sl28 freescale/fsl-ls1028a-kontron-sl28-var3-ads2 freescale/fsl-ls1028a-kontron-sl28-var4 freescale/fsl-ls1028a-kontron-kbox-a-230-ls" +BR2_LINUX_KERNEL_INSTALL_TARGET=y +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y +BR2_TARGET_ROOTFS_EXT2_SIZE="128M" +BR2_PACKAGE_HOST_GENIMAGE=y +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
Signature · 1 line
2.20.1
PATCH 1/1 board: Add Kontron SMARC-sAL28 support
Am 2020-05-10 15:31, schrieb Michael Walle:
Quoted 14 lines
From: Michael Walle <[email protected]>
Now that upstream supports this board add buildroot support for it, too.
This supports:
- upstream linux kernel, 5.7-rc4 for now. Once 5.7 is released and buildroot will switch to this kernel BR2_LINUX_KERNEL_CUSTOM_VERSION=y
can be removed.
- building an image which can be installed to eMMC or SD card.
- upstream u-boot patches are pending, therefore no support for building a bootloader for now.
Quoted 8 lines
Signed-off-by Michael Walle <[email protected]>--- DEVELOPERS | 2 ++ board/kontron/smarc-sal28/boot.cmd | 8 ++++++++ board/kontron/smarc-sal28/genimage.cfg | 10 ++++++++++ board/kontron/smarc-sal28/linux.fragment | 14 ++++++++++++++ board/kontron/smarc-sal28/post-build.sh | 9 +++++++++ configs/kontron_smarc_sal28_defconfig | 18 ++++++++++++++++++
A board readme is missing, I'll add that in the next patch version. But for now, I'm waiting for further feedback.
-michael
PATCH 1/1 board: Add Kontron SMARC-sAL28 support
In reply to Michael WalleOn 2020-05-10 15:31 +0200, Michael Walle spake thusly:
Quoted 9 lines
From: Michael Walle <[email protected]>
Now that upstream supports this board add buildroot support for it, too.
This supports:
- upstream linux kernel, 5.7-rc4 for now. Once 5.7 is released and buildroot will switch to this kernel BR2_LINUX_KERNEL_CUSTOM_VERSION=y
can be removed.
Not necessarily. We have defconfigs that are using a speicifc version of the mainstream kernel:
configs/aarch64_efi_defconfig:BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.18.10"
configs/warp7_defconfig:BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.6.3"So, it is also good to stick to a known-working version.
However, since we have weekly builds of the defconfigs, I believe that it is also good to have to version choice, so that the latest kernel is used, and so that we can detect build breakage.
Your pick.
Quoted 6 lines
- building an image which can be installed to eMMC or SD card.
- upstream u-boot patches are pending, therefore no support for building a bootloader for now.Signed-off-by Michael Walle <[email protected]>---
[--SNIP--]
board/kontron/smarc-sal28/linux.fragment line 7
Quoted 13 lines
board/kontron/smarc-sal28/linux.fragment new file +7
-0@@ -0,0 +1,14 @@ +CONFIG_NET_DSA=m +CONFIG_NET_DSA_TAG_OCELOT=m +CONFIG_NET_DSA_MSCC_FELIX=m +CONFIG_CAN_FLEXCAN=m +CONFIG_FSL_ENETC=y +CONFIG_FSL_ENETC_VF=y +CONFIG_FSL_ENETC_HW_TIMESTAMPING=y
Thhat one is neither in 5.7-rc4, nor in master...
board/kontron/smarc-sal28/post-build.sh
Quoted 12 lines
board/kontron/smarc-sal28/linux.fragment new file +7
-0+CONFIG_MSCC_OCELOT_SWITCH=m +CONFIG_PCIE_DW_PLAT_HOST=y +CONFIG_GPIO_MPC8XXX=y +CONFIG_SND_SOC_FSL_SAI=m +CONFIG_SND_SOC_WM8904=m +CONFIG_RTC_DRV_RV8803=y +CONFIG_COMMON_CLK_FSL_SAI=yboard/kontron/smarc-sal28/post-build.sh new file +0
-0
Naming a post-build script 'post-build.sh' is not very meaningful; instead, it is better when the name of the script hints at what the script does, like the genimage.sh script we use as a post-image script.
Maybe: 'gen-bootscript' ?
Also, adding the '.sh' extension is totally superfluous, and I tend to dislike it for new scripts.
board/kontron/smarc-sal28/post-build.sh line 8
Quoted 9 lines
board/kontron/smarc-sal28/post-build.sh new file +8
-0@@ -0,0 +1,9 @@ +#!/bin/sh + +MKIMAGE=$HOST_DIR/bin/mkimage +BOARD_DIR="$(dirname $0)" + +# There is a BR2_TARGET_UBOOT_BOOT_SCRIPT option but it is only available +# if we are building u-boot :( Therefore, create the bootsript manually for +# now.
This comment is not very valuable in the script itself, where it is destined to bit-rot. It makes sense to have it in the commit log, though.
Quoted 7 lines
board/kontron/smarc-sal28/post-build.sh new file +1
-0+$MKIMAGE -C none -T script -d $BOARD_DIR/boot.cmd $TARGET_DIR/boot/boot.scrconfigs/kontron_smarc_sal28_defconfig new file +0
-0
configs/kontron_smarc_sal28_defconfig line 8
Quoted 8 lines
configs/kontron_smarc_sal28_defconfig new file +8
-0@@ -0,0 +1,18 @@ +BR2_aarch64=y +BR2_cortex_a72=y +BR2_ROOTFS_POST_BUILD_SCRIPT="board/kontron/smarc-sal28/post-build.sh" +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh" +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/kontron/smarc-sal28/genimage.cfg" +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_VERSION=y +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="v5.7-rc4"
So, when 5.7 is tagged, you have two options:
- drop the custom version, so the latest kernel is always used, both
for the headers and the kernel itself;
- stick to a known version (likely. 5.7!) and also force the headers to that version, with BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_7 (to be introduced first, of course).
As I said above, I'm fine either way.
Quoted 17 lines
configs/kontron_smarc_sal28_defconfig new file +10
-0+BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y +BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/kontron/smarc-sal28/linux.fragment" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/fsl-ls1028a-kontron-sl28 freescale/fsl-ls1028a-kontron-sl28-var3-ads2 freescale/fsl-ls1028a-kontron-sl28-var4 freescale/fsl-ls1028a-kontron-kbox-a-230-ls" +BR2_LINUX_KERNEL_INSTALL_TARGET=y +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y +BR2_TARGET_ROOTFS_EXT2_SIZE="128M" +BR2_PACKAGE_HOST_GENIMAGE=y +BR2_PACKAGE_HOST_UBOOT_TOOLS=ySignature · 6 lines
2.20.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'