f2fs: remove unused PAGE_PRIVATE_ATOMIC_WRITE
Chao Yu
maintainerPATCH 1/1 f2fs: remove unused PAGE_PRIVATE_ATOMIC_WRITE
Commit 3db1de0e582c ("f2fs: change the current atomic write way") has removed all users of PAGE_PRIVATE_ATOMIC_WRITE, remove its definition and related functions.
--- fs/f2fs/f2fs.h | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)
fs/f2fs/f2fs.h +5 -10
@@ -1401,19 +1401,17 @@ static inline void f2fs_clear_bit(unsigned int nr, char *addr);* Layout A: lowest bit should be 1 * | bit0 = 1 | bit1 | bit2 | ... | bit MAX | private data .... | * bit 0 PAGE_PRIVATE_NOT_POINTER -* bit 1 PAGE_PRIVATE_ATOMIC_WRITE -* bit 2 PAGE_PRIVATE_DUMMY_WRITE -* bit 3 PAGE_PRIVATE_ONGOING_MIGRATION -* bit 4 PAGE_PRIVATE_INLINE_INODE -* bit 5 PAGE_PRIVATE_REF_RESOURCE -* bit 6- f2fs private data +* bit 1 PAGE_PRIVATE_DUMMY_WRITE +* bit 2 PAGE_PRIVATE_ONGOING_MIGRATION +* bit 3 PAGE_PRIVATE_INLINE_INODE +* bit 4 PAGE_PRIVATE_REF_RESOURCE +* bit 5- f2fs private data * * Layout B: lowest bit should be 0 * page.private is a wrapped pointer. */ enum {PAGE_PRIVATE_NOT_POINTER ,/* private contains non-pointer data */ -PAGE_PRIVATE_ATOMIC_WRITE ,/* data page from atomic write path */ PAGE_PRIVATE_DUMMY_WRITE ,/* data page for padding aligned IO */ PAGE_PRIVATE_ONGOING_MIGRATION ,/* data page which is on-going migrating */ PAGE_PRIVATE_INLINE_INODE ,/* inode page contains inline data */
@@ -1458,19 +1456,16 @@ PAGE_PRIVATE_GET_FUNC(nonpointer, NOT_POINTER);PAGE_PRIVATE_GET_FUNC (reference,REF_RESOURCE );PAGE_PRIVATE_GET_FUNC (inline,INLINE_INODE );PAGE_PRIVATE_GET_FUNC (gcing,ONGOING_MIGRATION ); -PAGE_PRIVATE_GET_FUNC (atomic,ATOMIC_WRITE );PAGE_PRIVATE_GET_FUNC (dummy,DUMMY_WRITE );PAGE_PRIVATE_SET_FUNC (reference,REF_RESOURCE );PAGE_PRIVATE_SET_FUNC (inline,INLINE_INODE );PAGE_PRIVATE_SET_FUNC (gcing,ONGOING_MIGRATION ); -PAGE_PRIVATE_SET_FUNC (atomic,ATOMIC_WRITE );PAGE_PRIVATE_SET_FUNC (dummy,DUMMY_WRITE );PAGE_PRIVATE_CLEAR_FUNC (reference,REF_RESOURCE );PAGE_PRIVATE_CLEAR_FUNC (inline,INLINE_INODE );PAGE_PRIVATE_CLEAR_FUNC (gcing,ONGOING_MIGRATION ); -PAGE_PRIVATE_CLEAR_FUNC (atomic,ATOMIC_WRITE );PAGE_PRIVATE_CLEAR_FUNC (dummy,DUMMY_WRITE );static inline unsigned long get_page_private_data (struct page *page)
Signature · 1 line
2.36.1
Quoted 3 lines
PAGE_PRIVATE_GET_FUNC(reference, REF_RESOURCE);
PAGE_PRIVATE_CLEAR_FUNC(reference, REF_RESOURCE);
Delete those two too?
Otherwise, looks good to me.
Thx,
Yangtao
Chao Yu
maintainerQuoted 5 lines · Yangtao Li
Quoted 3 lines
PAGE_PRIVATE_GET_FUNC(reference, REF_RESOURCE); PAGE_PRIVATE_CLEAR_FUNC(reference, REF_RESOURCE);Delete those two too?
Oh, thank for checking PAGE_PRIVATE_REF_RESOURCE's usage, I found we need clear_page_private_reference(), see “[PATCH] f2fs: fix to call clear_page_private_reference in .{release,invalid}_folio”
Thanks,
Quoted 5 lines
Otherwise, looks good to me.
Thx,
Yangtao
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 8 lines · On Tue, 20 Dec 2022 19:56:02 +0800 you wrote:
Commit
3db1de0e582c("f2fs: change the current atomic write way") has removed all users ofPAGE_PRIVATE_ATOMIC_WRITE, remove its definition and related functions.Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/f2fs.h | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-)
Here is the summary with links:
- [f2fs-dev] f2fs: remove unused PAGE_PRIVATE_ATOMIC_WRITE
https://git.kernel.org/jaegeuk/f2fs/c/b3107b3854c9
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html