Skip to contentSkip to conversation

riscv: dts: microchip: Drop "clock-frequency" property of cpu nodes

PATCH In review Bin Meng 2 participants 6 messages Jun 16, 2021 – Jul 13, 2021

Subsystems (3)
lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/2 riscv: dts: microchip: Drop "clock-frequency" property of cpu nodes

From: Bin Meng <[email protected]>

The "clock-frequency" property of cpu nodes isn't required. Drop it.

---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 5 -----
 1 file changed, 5 deletions(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -5
index b9819570a7d1..ee54878b3f89 100644
@@ -17,7 +17,6 @@ cpus {
 		#size-cells = <0>;
 
 		cpu@0 {
-			clock-frequency = <0>;
 			compatible = "sifive,e51", "sifive,rocket0", "riscv";
 			device_type = "cpu";
 			i-cache-block-size = <64>;
@@ -35,7 +34,6 @@ cpu0_intc: interrupt-controller {
 		};
 
 		cpu@1 {
-			clock-frequency = <0>;
 			compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
 			d-cache-block-size = <64>;
 			d-cache-sets = <64>;
@@ -62,7 +60,6 @@ cpu1_intc: interrupt-controller {
 		};
 
 		cpu@2 {
-			clock-frequency = <0>;
 			compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
 			d-cache-block-size = <64>;
 			d-cache-sets = <64>;
@@ -89,7 +86,6 @@ cpu2_intc: interrupt-controller {
 		};
 
 		cpu@3 {
-			clock-frequency = <0>;
 			compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
 			d-cache-block-size = <64>;
 			d-cache-sets = <64>;
@@ -116,7 +112,6 @@ cpu3_intc: interrupt-controller {
 		};
 
 		cpu@4 {
-			clock-frequency = <0>;
 			compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
 			d-cache-block-size = <64>;
 			d-cache-sets = <64>;
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 2/2 riscv: dts: microchip: Fix wrong interrupt numbers of DMA

From: Bin Meng <[email protected]>

Per chapter 5.2.2, interrupt sources in the PolarFire MSS doc [1], the correct interrupt numbers for DMA are <5,6,...,12>.

[1] https://www.microsemi.com/document-portal/doc_download/
1245725-polarfire-soc-fpga-mss-technical-reference-manual

Fixes 0fa6107eca41 ("RISC-V: Initial DTS for Microchip ICICLE board")

---

 arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1 -1
index ee54878b3f89..a00d9dc560d3 100644
@@ -182,7 +182,7 @@ dma@3000000 {
 			compatible = "sifive,fu540-c000-pdma";
 			reg = <0x0 0x3000000 0x0 0x8000>;
 			interrupt-parent = <&plic>;
-			interrupts = <23 24 25 26 27 28 29 30>;
+			interrupts = <5 6 7 8 9 10 11 12>;
 			#dma-cells = <1>;
 		};
 
Signature · 1 line
2.25.1
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] riscv: dts: microchip: Fix wrong interrupt numbers of DMA

Quoted 31 lines · Bin Meng

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

From: Bin Meng <[email protected]>

Per chapter 5.2.2, interrupt sources in the PolarFire MSS doc [1], the correct interrupt numbers for DMA are <5,6,...,12>.

[1] https://www.microsemi.com/document-portal/doc_download/
1245725-polarfire-soc-fpga-mss-technical-reference-manual

Fixes 0fa6107eca41 ("RISC-V: Initial DTS for Microchip ICICLE board")

---

  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1 -2
index ee54878b3f89..a00d9dc560d3 100644
@@ -182,7 +182,7 @@ dma@3000000 {
                         compatible = "sifive,fu540-c000-pdma";
                         reg = <0x0 0x3000000 0x0 0x8000>;
                         interrupt-parent = <&plic>;
-                       interrupts = <23 24 25 26 27 28 29 30>;
+                       interrupts = <5 6 7 8 9 10 11 12>;
                         #dma-cells = <1>;
                 };
 
--
Quoted 1 line

2.25.1

Quoted 5 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#4 lore raw
Quoted 7 lines · Bin Meng

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 4 lines · Bin Meng

From: Bin Meng <[email protected]>

The "clock-frequency" property of cpu nodes isn't required. Drop it.

Quoted 7 lines
Quoted 6 lines

---

  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 5 -----
  1 file changed, 5 deletions(-)

Ping?

Daire can you have a look at this and the other hart/clock related change?

Quoted 5 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

maintainer Reviewed-by on v1 1/2
#5 lore raw
In reply to Bin Meng
Quoted 57 lines · Bin Meng

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

From: Bin Meng <[email protected]>

The "clock-frequency" property of cpu nodes isn't required. Drop it.

---

  arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 5 -----
  1 file changed, 5 deletions(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +0 -6
index b9819570a7d1..ee54878b3f89 100644
@@ -17,7 +17,6 @@ cpus {
                 #size-cells = <0>;
 
                 cpu@0 {
-                       clock-frequency = <0>;
                         compatible = "sifive,e51", "sifive,rocket0", "riscv";
                         device_type = "cpu";
                         i-cache-block-size = <64>;
@@ -35,7 +34,6 @@ cpu0_intc: interrupt-controller {
                 };
 
                 cpu@1 {
-                       clock-frequency = <0>;
                         compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
                         d-cache-block-size = <64>;
                         d-cache-sets = <64>;
@@ -62,7 +60,6 @@ cpu1_intc: interrupt-controller {
                 };
 
                 cpu@2 {
-                       clock-frequency = <0>;
                         compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
                         d-cache-block-size = <64>;
                         d-cache-sets = <64>;
@@ -89,7 +86,6 @@ cpu2_intc: interrupt-controller {
                 };
 
                 cpu@3 {
-                       clock-frequency = <0>;
                         compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
                         d-cache-block-size = <64>;
                         d-cache-sets = <64>;
@@ -116,7 +112,6 @@ cpu3_intc: interrupt-controller {
                 };
 
                 cpu@4 {
-                       clock-frequency = <0>;
                         compatible = "sifive,u54-mc", "sifive,rocket0", "riscv";
                         d-cache-block-size = <64>;
                         d-cache-sets = <64>;
--
Quoted 2 lines

2.25.1

Quoted 4 lines

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv