Skip to contentSkip to conversation

i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[]

PATCH In review Martin Schiller 2 participants 6 messages Apr 16, 2025 – Apr 22, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 i2c: mediatek: add missing empty entry at end of mkt_i2c_ids[]

This adds the missing empty entry at the end of mtk_i2c_ids[].

---
 drivers/i2c/mtk_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/mtk_i2c.c +1 -1
index 3450177741a..6edf3f44eca 100644
@@ -879,7 +879,7 @@ static const struct udevice_id mtk_i2c_ids[] = {
 	}, {
 		.compatible = "mediatek,mt8518-i2c",
 		.data = (ulong)&mt8518_soc_data,
-	}
+	}, {}
 };
 
 U_BOOT_DRIVER(mtk_i2c) = {
Signature · 1 line
2.39.5
#1 lore raw

PATCH 2/2 i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[]

This removes a duplicate entry in mt_i2c_regs_v1[].

---
 drivers/i2c/mtk_i2c.c | 1 -
 1 file changed, 1 deletion(-)
drivers/i2c/mtk_i2c.c +0 -1
index 6edf3f44eca..55381dbeced 100644
@@ -143,7 +143,6 @@ static const uint mt_i2c_regs_v1[] = {
 	[REG_RSV_DEBUG] = 0x44,
 	[REG_HS] = 0x48,
 	[REG_SOFTRESET] = 0x50,
-	[REG_SOFTRESET] = 0x50,
 	[REG_DCM_EN] = 0x54,
 	[REG_DEBUGSTAT] = 0x64,
 	[REG_DEBUGCTRL] = 0x68,
Signature · 1 line
2.39.5
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[]

Hello Martin,

Quoted 13 lines · Martin Schiller

This removes a duplicate entry in mt_i2c_regs_v1[].

---
  drivers/i2c/mtk_i2c.c | 1 -
  1 file changed, 1 deletion(-)
drivers/i2c/mtk_i2c.c +0 -0
index 6edf3f44eca..55381dbeced 100644

drivers/i2c/mtk_i2c.c static const uint mt_i2c_regs_v1[] = { · line 148

Quoted 7 lines
drivers/i2c/mtk_i2c.c +0 -1
@@ -143,7 +143,6 @@ static const uint mt_i2c_regs_v1[] = {
  	[REG_RSV_DEBUG] = 0x44,
  	[REG_HS] = 0x48,
  	[REG_SOFTRESET] = 0x50,
-	[REG_SOFTRESET] = 0x50,
  	[REG_DCM_EN] = 0x54,
  	[REG_DEBUGSTAT] = 0x64,
  	[REG_DEBUGCTRL] = 0x68,

good catch, thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#3 lore raw

Re: [PATCH 2/2] i2c: mediatek: remove duplicate entry in mt_i2c_regs_v1[]

In reply to Martin Schiller

Hello Martin,

Quoted 6 lines · Martin Schiller

This removes a duplicate entry in mt_i2c_regs_v1[].

---
  drivers/i2c/mtk_i2c.c | 1 -
  1 file changed, 1 deletion(-)

Applied to u-boot-i2c master

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
Reviewed-by on v1 1/2
#4 lore raw
In reply to Martin Schiller

Hello Martin,

Quoted 13 lines · Martin Schiller

This adds the missing empty entry at the end of mtk_i2c_ids[].

---
  drivers/i2c/mtk_i2c.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/mtk_i2c.c +0 -0
index 3450177741a..6edf3f44eca 100644

drivers/i2c/mtk_i2c.c static const struct udevice_id mtk_i2c_ids[] = { · line 885

Quoted 8 lines
drivers/i2c/mtk_i2c.c +1 -1
@@ -879,7 +879,7 @@ static const struct udevice_id mtk_i2c_ids[] = {
  	}, {
  		.compatible = "mediatek,mt8518-i2c",
  		.data = (ulong)&mt8518_soc_data,
-	}
+	}, {}
  };
 
  U_BOOT_DRIVER(mtk_i2c) = {

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]
#5 lore raw
In reply to Martin Schiller

Hello Amrtin,

Quoted 6 lines · Martin Schiller

This adds the missing empty entry at the end of mtk_i2c_ids[].

---
  drivers/i2c/mtk_i2c.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-i2c master

Thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: [email protected]