sched/deadline: Use proc_douintvec_minmax() limit minimum value
PATCH 1/1 sched/deadline: Use proc_douintvec_minmax() limit minimum value
proc_dointvec() is not applicable for unsigned integer, use proc_douintvec_minmax() limit minimum value.
--- kernel/sched/deadline.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
kernel/sched/deadline.c +4 -2
@@ -30,14 +30,16 @@ static struct ctl_table sched_dl_sysctls[] = { .data = &sysctl_sched_dl_period_max, .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_douintvec_minmax, + .extra1 = (void *)&sysctl_sched_dl_period_min, }, { .procname = "sched_deadline_period_min_us", .data = &sysctl_sched_dl_period_min, .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_douintvec_minmax, + .extra2 = (void *)&sysctl_sched_dl_period_max, }, {} };
Signature · 1 line
2.25.1
Ping.
Quoted 33 lines · Yajun Deng
proc_dointvec()is not applicable for unsigned integer, useproc_douintvec_minmax()limit minimum value.Signed-off-by Yajun Deng <[email protected]>---
kernel/sched/deadline.c| 6 ++++--1 file changed, 4 insertions(+), 2 deletions(-)kernel/sched/deadline.c +4
-2@@ -30,14 +30,16 @@ static struct ctl_table sched_dl_sysctls[] = { .data = &sysctl_sched_dl_period_max, .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_douintvec_minmax, + .extra1 = (void *)&sysctl_sched_dl_period_min, }, { .procname = "sched_deadline_period_min_us", .data = &sysctl_sched_dl_period_min, .maxlen = sizeof(unsigned int), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = proc_douintvec_minmax, + .extra2 = (void *)&sysctl_sched_dl_period_max, }, {} };Signature · 1 line
2.25.1
Hi Yajun
Quoted 2 lines · Yajun Deng
proc_dointvec()is not applicable for unsigned integer, useproc_douintvec_minmax()limit minimum value.
I understand your patch, but your log message is somehow incomplete.
Could you expand on that, showing the problem using an example, and then how you see it fixed?
Also, could you please add the Fixes: tag so this patch can land on stable trees?
-- Daniel
Quoted 4 lines · Daniel Bristot de Oliveira
Hi Yajun
On 5/13/22 04:41, Yajun Deng wrote:
Quoted 8 lines
Quoted 2 lines
proc_dointvec()is not applicable for unsigned integer, useproc_douintvec_minmax()limit minimum value.I understand your patch, but your log message is somehow incomplete.
Could you expand on that, showing the problem using an example, and then how you see it fixed?
This patch isn't a fix. It's just an optimization for match data and proc_handler in struct ctl_table.
Quoted 2 lines
Also, could you please add the Fixes: tag so this patch can land on stable trees?
This statement 'if (period < min || period > max)' in __checkparam_dl() will work fine even if there hasn't this patch. So this patch may not need land on stable trees.
Quoted 1 line
-- Daniel
Quoted 13 lines · Yajun Deng
Quoted 11 lines · Daniel Bristot de Oliveira
Hi Yajun
Quoted 2 lines · Yajun Deng
proc_dointvec()is not applicable for unsigned integer, useproc_douintvec_minmax()limit minimum value.I understand your patch, but your log message is somehow incomplete.
Could you expand on that, showing the problem using an example, and then how you see it fixed?
Quoted 7 lines
This patch isn't a fix. It's just an optimization for match data and
proc_handlerin structctl_table.Quoted 2 lines
Also, could you please add the Fixes: tag so this patch can land on stable trees?
This statement 'if (period < min || period > max)' in
__checkparam_dl()will work fine even if there hasn't this patch. So this patch may not need land on stable trees.
Good, so you already know how to improve your log message.
-- Daniel