Skip to contentSkip to conversation

r8169: fix rtl_hw_jumbo_disable for RTL8168evl

PATCH Applied Heiner Kallweit 2 participants 2 messages Dec 7, 2019

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH v2 1/1 r8169: fix rtl_hw_jumbo_disable for RTL8168evl

In referenced fix we removed the RTL8168e-specific jumbo config for RTL8168evl in rtl_hw_jumbo_enable(). We have to do the same in rtl_hw_jumbo_disable().

v2: fix referenced commit id

Fixes 14012c9f3bb9 ("r8169: fix jumbo configuration for RTL8168evl")
---
 drivers/net/ethernet/realtek/r8169_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/realtek/r8169_main.c +1 -1
index 38d212686..46a492229 100644
@@ -3896,7 +3896,7 @@ static void rtl_hw_jumbo_disable(struct rtl8169_private *tp)
 	case RTL_GIGA_MAC_VER_27 ... RTL_GIGA_MAC_VER_28:
 		r8168dp_hw_jumbo_disable(tp);
 		break;
-	case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_34:
+	case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33:
 		r8168e_hw_jumbo_disable(tp);
 		break;
 	default:
Signature · 1 line
2.24.0
maintainer Applied
#1 lore raw

From: Heiner Kallweit <[email protected]>
Date: Sat, 7 Dec 2019 22:21:52 +0100

Quoted 8 lines

In referenced fix we removed the RTL8168e-specific jumbo config for RTL8168evl in rtl_hw_jumbo_enable(). We have to do the same in rtl_hw_jumbo_disable().

v2: fix referenced commit id

Fixes 14012c9f3bb9 ("r8169: fix jumbo configuration for RTL8168evl")

Applied.

Again, another fun chain of fixes to fixes:

[davem@localhost net]$ git describe 14012c9f3bb9 v5.4-8858-g14012c9f3bb9
[davem@localhost net]$ git show 14012c9f3bb9 | grep Fixes

Fixes 4ebcb113edcc ("r8169: fix jumbo packet handling on resume from suspend")

[davem@localhost net]$ gdc 4ebcb113edcc v5.4-rc4~6^2~55
[davem@localhost net]$ git show 4ebcb113edcc | grep Fixes

    Fixes: 7366016d2d4c ("r8169: read common register for PCI commit")

[davem@localhost net]$ gdc 7366016d2d4c
v5.4-rc1~131^2~119^2~4