configure: warn if not using a separate build directory
PATCH v3 1/1 configure: warn if not using a separate build directory
Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building QEMU in an undesirable manner.
---
Changed in v3:
- Don't try to predict the future so much, just recommend a separate build dir
configure | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)
configure +26 -0
@@ -285,6 +285,16 @@ then error_exit "main directory cannot contain spaces nor colons" fi +canon_build_path=$(realpath -- "$PWD") +canon_source_path=$(realpath -- "$source_path") + +in_srcdir=no +if [ "$canon_build_path" = "$canon_source_path" ] +then + in_srcdir=yes +fi + + # default parameters cpu="" iasl="iasl"
@@ -6799,6 +6809,22 @@ if test "$supported_os" = "no"; then echo "us upstream at [email protected]." fi +if test "$in_srcdir" = "yes"; then + echo + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" + echo + echo "Support for running the 'configure' script directly from the" + echo "source directory is deprecated. In source dir builds are not" + echo "covered by automated testing and thus may not correctly build" + echo "QEMU. Users are recommended to use a separate build directory:" + echo + echo " $ mkdir build" + echo " $ cd build" + echo " $ ../configure" + echo " $ make" + echo +fi + config_host_mak="config-host.mak" echo "# Automatically generated by configure - do not modify" >config-all-disas.mak
Signature · 1 line
2.24.1
Quoted 10 lines · Daniel P. Berrangé
Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building QEMU in an undesirable manner.
Signed-off-by Daniel P. Berrangé <[email protected]>---
configure if test "$supported_os" = "no"; then · line 6819
Quoted 8 lines
configure +8
-0+if test "$in_srcdir" = "yes"; then + echo + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" + echo + echo "Support for running the 'configure' script directly from the" + echo "source directory is deprecated. In source dir builds are not" + echo "covered by automated testing and thus may not correctly build" + echo "QEMU. Users are recommended to use a separate build directory:"
Our mails crossed. I still think this reads a bit awkwardly; maybe:
s/IN SOURCE DIR BUILDS/BUILDING IN THE SOURCE DIR/ s/In source dir builds/In-tree builds/
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Markus Armbruster
Reviewed-byQuoted 20 lines · Eric Blake
Quoted 10 lines · Daniel P. Berrangé
Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building QEMU in an undesirable manner.
Signed-off-by Daniel P. Berrangé <[email protected]>---
configure if test "$supported_os" = "no"; then · line 6819
Quoted 8 lines
configure +8
-0+if test "$in_srcdir" = "yes"; then + echo + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" + echo + echo "Support for running the 'configure' script directly from the" + echo "source directory is deprecated. In source dir builds are not" + echo "covered by automated testing and thus may not correctly build" + echo "QEMU. Users are recommended to use a separate build directory:"
Quoted 6 lines
Our mails crossed. I still think this reads a bit awkwardly; maybe:
s/IN SOURCE DIR BUILDS/BUILDING IN THE SOURCE DIR/ s/In source dir builds/In-tree builds/
Reviewed-by Eric Blake <[email protected]>
Preferably with Eric's tweaks:
Quoted 24 lines · Markus Armbruster
Quoted 22 lines · Eric Blake
Quoted 10 lines · Daniel P. Berrangé
Running configure directly from the source directory is a build configuration that will go away in future. It is also not currently covered by any automated testing. Display a deprecation warning if the user attempts to use an in-srcdir build setup, so that they are aware that they're building QEMU in an undesirable manner.
Signed-off-by Daniel P. Berrangé <[email protected]>---
configure if test "$supported_os" = "no"; then · line 6819
Quoted 8 lines
configure +8
-0+if test "$in_srcdir" = "yes"; then + echo + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED" + echo + echo "Support for running the 'configure' script directly from the" + echo "source directory is deprecated. In source dir builds are not" + echo "covered by automated testing and thus may not correctly build" + echo "QEMU. Users are recommended to use a separate build directory:"Our mails crossed. I still think this reads a bit awkwardly; maybe:
Quoted 8 lines
Quoted 4 lines
s/IN SOURCE DIR BUILDS/BUILDING IN THE SOURCE DIR/ s/In source dir builds/In-tree builds/
Reviewed-by Eric Blake <[email protected]>Preferably with Eric's tweaks:
Reviewed-by Markus Armbruster <[email protected]>