Skip to contentSkip to conversation

ram: px30: drop non informative debug message

PATCH New Miquel Raynal 2 participants 2 messages Mar 17, 2020 – Mar 18, 2020 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ram: px30: drop non informative debug message

It seems that this line was added by mistake as right before it there is another function printing debug info already, so this line is pretty much useless, drop it.

Fixes 39edfaa758a ("ram: px30: add sdram driver")
---
 drivers/ram/rockchip/sdram_px30.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ram/rockchip/sdram_px30.c +0 -1
index ee657573111..a07f05ded07 100644
@@ -714,7 +714,6 @@ int sdram_init(void)
 
 	sdram_print_ddr_info(&sdram_params->ch.cap_info, &sdram_params->base);
 
-	printascii("out\n");
 	return ret;
 error:
 	return (-1);
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 ram: px30: drop non informative debug message

Hi Miquel,

Quoted 3 lines · Miquel Raynal

It seems that this line was added by mistake as right before it there is another function printing debug info already, so this line is pretty much useless, drop it.

This line is not add by mistake, if you have more experience on rockchip dram init binaries,

you can see this 'out' in most of them, which means the dram init has been done.

This is useless in logical for it just after dram info print for px30 dram driver, so it's OK to drop.

Thanks,

- Kever

Quoted 19 lines
Fixes 39edfaa758a ("ram: px30: add sdram driver")
---
  drivers/ram/rockchip/sdram_px30.c | 1 -
  1 file changed, 1 deletion(-)
drivers/ram/rockchip/sdram_px30.c +0 -1
index ee657573111..a07f05ded07 100644
@@ -714,7 +714,6 @@ int sdram_init(void)
 
  	sdram_print_ddr_info(&sdram_params->ch.cap_info, &sdram_params->base);
 
-	printascii("out\n");
  	return ret;
  error:
  	return (-1);