Skip to contentSkip to conversation

b43: N-PHY: update init tables

PATCH New ikorot at earthlink.net 2 participants 2 messages Dec 10, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 b43: N-PHY: update init tables

Rafal,

-----Original Message-----

Quoted 48 lines

From: Rafa? Mi?ecki <[email protected]>
Sent: Dec 9, 2010 10:36 PM
To: ikorot at earthlink.net
Cc: Larry Finger <[email protected]>, Hauke Mehrtens <[email protected]>, linux-wireless at vger.kernel.org, b43-dev at lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables

W dniu 10 grudnia 2010 03:26 u?ytkownik <[email protected]> napisa?:

Quoted 41 lines

-----Original Message-----

Quoted 39 lines

From: Rafa? Mi?ecki <[email protected]>
Sent: Dec 9, 2010 6:06 AM
To: ikorot at earthlink.net
Cc: Larry Finger <[email protected]>, Hauke Mehrtens <[email protected]>, linux-wireless at vger.kernel.org, b43-dev at lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables

2010/12/8 ?<[email protected]>:

Quoted 25 lines

Larry,

-----Original Message-----

Quoted 14 lines

From: Larry Finger <[email protected]>
Sent: Dec 7, 2010 12:00 PM
To: ikorot at earthlink.net
Cc: Hauke Mehrtens <[email protected]>, linux-wireless at vger.kernel.org, b43-dev at lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables

Quoted 6 lines · ikorot at earthlink.net
Quoted 3 lines

One reason is that these tables changed from non-zero to zero values between Broadcom driver 4.174.64.19 and 5.10.56.46. As they might change again, I think we should retain the full version.

Is there a way to check for version of the driver? This way whoever uses old one won't be screwed...

Quoted 6 lines

That will not be a problem as no older version of b43 works at all with b43. To help you understand this change, when the 4.174.64.19 Broadcom driver was reverse-engineered, the tables had non-zero values. Rafel later compared the trace dumps of b43 with the latest version of wl and found that the values are now zero. When I rechecked driver 5.10.56.46, I found them to be zero there as well and changed the specs.

Quoted 4 lines

Well, it maybe feasible to keep the old values and check the version of the driver, since you are saying yourself that the value might be changing in the future. Maybe for couple of releases only?

Sorry, but I don't understand that at all. What do you mean by version of the driver? What driver?

Quoted 8 lines
Quoted 5 lines

#if B43_VERSION <= x.x.x.x
// table initialized to some values
#else
//table initialized to 0's
#endif

You want to put condition checking b43 version in... b43 driver? I can't follow you.

Yes.
And what you can't follow?

For historical purposes and to better understand the changes and ease the debugging I proposed this addition.
Besides if for some reason in future versions Broadcom will decide to return to the same values for init tables, the changes will be very simple.

Thank you.

Quoted 3 lines
Signature · 2 lines
-- 
Rafa?
#1 lore raw

PATCH 1/4 b43: N-PHY: update init tables

W dniu 10 grudnia 2010 20:09 u?ytkownik <[email protected]> napisa?:

Quoted 61 lines

Rafal,

-----Original Message-----

Quoted 48 lines

From: Rafa? Mi?ecki <[email protected]>
Sent: Dec 9, 2010 10:36 PM
To: ikorot at earthlink.net
Cc: Larry Finger <[email protected]>, Hauke Mehrtens <[email protected]>, linux-wireless at vger.kernel.org, b43-dev at lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables

W dniu 10 grudnia 2010 03:26 u?ytkownik ?<[email protected]> napisa?:

Quoted 41 lines

-----Original Message-----

Quoted 39 lines

From: Rafa? Mi?ecki <[email protected]>
Sent: Dec 9, 2010 6:06 AM
To: ikorot at earthlink.net
Cc: Larry Finger <[email protected]>, Hauke Mehrtens <[email protected]>, linux-wireless at vger.kernel.org, b43-dev at lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables

2010/12/8 ?<[email protected]>:

Quoted 25 lines

Larry,

-----Original Message-----

Quoted 14 lines

From: Larry Finger <[email protected]>
Sent: Dec 7, 2010 12:00 PM
To: ikorot at earthlink.net
Cc: Hauke Mehrtens <[email protected]>, linux-wireless at vger.kernel.org, b43-dev at lists.infradead.org
Subject: Re: [PATCH 1/4] b43: N-PHY: update init tables

Quoted 6 lines · ikorot at earthlink.net
Quoted 3 lines

One reason is that these tables changed from non-zero to zero values between Broadcom driver 4.174.64.19 and 5.10.56.46. As they might change again, I think we should retain the full version.

Is there a way to check for version of the driver? This way whoever uses old one won't be screwed...

Quoted 6 lines

That will not be a problem as no older version of b43 works at all with b43. To help you understand this change, when the 4.174.64.19 Broadcom driver was reverse-engineered, the tables had non-zero values. Rafel later compared the trace dumps of b43 with the latest version of wl and found that the values are now zero. When I rechecked driver 5.10.56.46, I found them to be zero there as well and changed the specs.

Quoted 4 lines

Well, it maybe feasible to keep the old values and check the version of the driver, since you are saying yourself that the value might be changing in the future. Maybe for couple of releases only?

Sorry, but I don't understand that at all. What do you mean by version of the driver? What driver?

Quoted 8 lines
Quoted 5 lines

#if B43_VERSION <= x.x.x.x
// table initialized to some values
#else
//table initialized to 0's
#endif

You want to put condition checking b43 version in... b43 driver? I can't follow you.

Quoted 7 lines

Yes.
And what you can't follow?

For historical purposes and to better understand the changes and ease the debugging I proposed this addition.
Besides if for some reason in future versions Broadcom will decide to return to the same values for init tables, the changes will be very simple.

So I guess you meant using "#if 0" for commenting old values?

I guess we could do that instead deleting old values, but fortunately it's git so we always can browse history and restore old values without problems :)

Signature · 1 line
Rafa?