filelock: move file locking definitions to separate header file
Subsystems (17)
Jeff Layton
maintainerPATCH v2 1/1 filelock: move file locking definitions to separate header file
The file locking definitions have lived in fs.h since the dawn of time, but they are only used by a small subset of the source files that include it.
Move the file locking definitions to a new header file, and add the appropriate #include directives to the source files that need them. By doing this we trim down fs.h a bit and limit the amount of rebuilding that has to be done when we make changes to the file locking APIs.
--- arch/arm/kernel/sys_oabi-compat.c | 1 + fs/9p/vfs_file.c | 1 + fs/afs/internal.h | 1 + fs/attr.c | 1 + fs/ceph/locks.c | 1 + fs/cifs/cifsfs.c | 1 + fs/cifs/cifsglob.h | 1 + fs/cifs/cifssmb.c | 1 + fs/cifs/file.c | 1 + fs/cifs/smb2file.c | 1 + fs/dlm/plock.c | 1 + fs/fcntl.c | 1 + fs/file_table.c | 1 + fs/fuse/file.c | 1 + fs/gfs2/file.c | 1 + fs/inode.c | 1 + fs/ksmbd/smb2pdu.c | 1 + fs/ksmbd/vfs.c | 1 + fs/ksmbd/vfs_cache.c | 1 + fs/lockd/clntproc.c | 1 + fs/lockd/netns.h | 1 + fs/locks.c | 1 + fs/namei.c | 1 + fs/nfs/file.c | 1 + fs/nfs/nfs4_fs.h | 1 + fs/nfs/pagelist.c | 1 + fs/nfs/write.c | 1 + fs/nfs_common/grace.c | 1 + fs/nfsd/netns.h | 1 + fs/ocfs2/locks.c | 1 + fs/ocfs2/stack_user.c | 1 + fs/open.c | 1 + fs/orangefs/file.c | 1 + fs/posix_acl.c | 1 + fs/proc/fd.c | 1 + fs/utimes.c | 1 + fs/xattr.c | 1 + fs/xfs/xfs_linux.h | 1 + include/linux/filelock.h | 438 ++++++++++++++++++++++++++++++ include/linux/fs.h | 426 ----------------------------- include/linux/lockd/xdr.h | 1 + 41 files changed, 477 insertions(+), 426 deletions(-) create mode 100644 include/linux/filelock.h
v2:
- drop pointless externs from the new filelock.h
- move include into xfs_linux.h instead of xfs_buf.h
- have filelock.h #include fs.h. Any file including filelock.h will almost certainly need fs.h anyway.
I've left some of Al's comments unaddressed for now, as I'd like to keep this move mostly mechanical, and no go changing function prototypes until the dust settles.
I'll plan to drop this into linux-next within the next few days, with an eye toward merging this for v6.3.
arch/arm/kernel/sys_oabi-compat.c +1 -0
@@ -73,6 +73,7 @@#include <linux/syscalls.h> #include <linux/errno.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/cred.h> #include <linux/fcntl.h> #include <linux/eventpoll.h>
fs/9p/vfs_file.c +1 -0
@@ -9,6 +9,7 @@#include <linux/module.h> #include <linux/errno.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/sched.h> #include <linux/file.h> #include <linux/stat.h>
fs/afs/internal.h +1 -0
@@ -9,6 +9,7 @@#include <linux/kernel.h> #include <linux/ktime.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/pagemap.h> #include <linux/rxrpc.h> #include <linux/key.h>
fs/attr.c +1 -0
@@ -14,6 +14,7 @@#include <linux/capability.h> #include <linux/fsnotify.h> #include <linux/fcntl.h> +#include <linux/filelock.h> #include <linux/security.h> #include <linux/evm.h> #include <linux/ima.h>
fs/ceph/locks.c +1 -0
@@ -7,6 +7,7 @@#include "super.h" #include "mds_client.h" +#include <linux/filelock.h> #include <linux/ceph/pagelist.h> static u64 lock_secret;
fs/cifs/cifsfs.c +1 -0
@@ -12,6 +12,7 @@#include <linux/module.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/mount.h> #include <linux/slab.h> #include <linux/init.h>
fs/cifs/cifsglob.h +1 -0
@@ -26,6 +26,7 @@#include <uapi/linux/cifs/cifs_mount.h> #include "../smbfs_common/smb2pdu.h" #include "smb2pdu.h" +#include <linux/filelock.h> #define SMB_PATH_MAX 260#define CIFS_PORT 445
fs/cifs/cifssmb.c +1 -0
@@ -15,6 +15,7 @@/* want to reuse a stale file handle and only the caller knows the file info */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/kernel.h> #include <linux/vfs.h> #include <linux/slab.h>
fs/cifs/file.c +1 -0
@@ -9,6 +9,7 @@* */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/backing-dev.h> #include <linux/stat.h> #include <linux/fcntl.h>
fs/cifs/smb2file.c +1 -0
@@ -7,6 +7,7 @@* */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/stat.h> #include <linux/slab.h> #include <linux/pagemap.h>
fs/dlm/plock.c +1 -0
@@ -4,6 +4,7 @@*/ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/miscdevice.h> #include <linux/poll.h> #include <linux/dlm.h>
fs/fcntl.c +1 -0
@@ -10,6 +10,7 @@#include <linux/mm.h> #include <linux/sched/task.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/file.h> #include <linux/fdtable.h> #include <linux/capability.h>
fs/file_table.c +1 -0
@@ -13,6 +13,7 @@#include <linux/init.h> #include <linux/module.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/security.h> #include <linux/cred.h> #include <linux/eventpoll.h>
fs/fuse/file.c +1 -0
@@ -18,6 +18,7 @@#include <linux/falloc.h> #include <linux/uio.h> #include <linux/fs.h> +#include <linux/filelock.h> static int fuse_send_open(struct fuse_mount *fm, u64 nodeid, unsigned int open_flags, int opcode,
fs/gfs2/file.c +1 -0
@@ -15,6 +15,7 @@#include <linux/mm.h> #include <linux/mount.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/gfs2_ondisk.h> #include <linux/falloc.h> #include <linux/swap.h>
fs/inode.c +1 -0
@@ -5,6 +5,7 @@*/ #include <linux/export.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/mm.h> #include <linux/backing-dev.h> #include <linux/hash.h>
fs/ksmbd/smb2pdu.c +1 -0
@@ -12,6 +12,7 @@#include <linux/ethtool.h> #include <linux/falloc.h> #include <linux/mount.h> +#include <linux/filelock.h> #include "glob.h" #include "smbfsctl.h"
fs/ksmbd/vfs.c +1 -0
@@ -6,6 +6,7 @@#include <linux/kernel.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/uaccess.h> #include <linux/backing-dev.h> #include <linux/writeback.h>
fs/ksmbd/vfs_cache.c +1 -0
@@ -5,6 +5,7 @@*/ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/slab.h> #include <linux/vmalloc.h>
fs/lockd/clntproc.c +1 -0
@@ -12,6 +12,7 @@#include <linux/types.h> #include <linux/errno.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/nfs_fs.h> #include <linux/utsname.h> #include <linux/freezer.h>
fs/lockd/netns.h +1 -0
@@ -3,6 +3,7 @@#define __LOCKD_NETNS_H__#include <linux/fs.h> +#include <linux/filelock.h> #include <net/netns/generic.h> struct lockd_net {
fs/locks.c +1 -0
@@ -52,6 +52,7 @@#include <linux/capability.h> #include <linux/file.h> #include <linux/fdtable.h> +#include <linux/filelock.h> #include <linux/fs.h> #include <linux/init.h> #include <linux/security.h>
fs/namei.c +1 -0
@@ -20,6 +20,7 @@#include <linux/kernel.h> #include <linux/slab.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/namei.h> #include <linux/pagemap.h> #include <linux/sched/mm.h>
fs/nfs/file.c +1 -0
@@ -31,6 +31,7 @@#include <linux/swap.h> #include <linux/uaccess.h> +#include <linux/filelock.h> #include "delegation.h" #include "internal.h"
fs/nfs/nfs4_fs.h +1 -0
@@ -23,6 +23,7 @@#define NFS4_MAX_LOOP_ON_RECOVER (10)#include <linux/seqlock.h> +#include <linux/filelock.h> struct idmap ;
fs/nfs/pagelist.c +1 -0
@@ -21,6 +21,7 @@#include <linux/nfs_page.h> #include <linux/nfs_mount.h> #include <linux/export.h> +#include <linux/filelock.h> #include "internal.h" #include "pnfs.h"
fs/nfs/write.c +1 -0
@@ -25,6 +25,7 @@#include <linux/freezer.h> #include <linux/wait.h> #include <linux/iversion.h> +#include <linux/filelock.h> #include <linux/uaccess.h> #include <linux/sched/mm.h>
fs/nfs_common/grace.c +1 -0
@@ -9,6 +9,7 @@#include <net/net_namespace.h> #include <net/netns/generic.h> #include <linux/fs.h> +#include <linux/filelock.h> static unsigned int grace_net_id;static DEFINE_SPINLOCK (grace_lock);
fs/nfsd/netns.h +1 -0
@@ -10,6 +10,7 @@#include <net/net_namespace.h> #include <net/netns/generic.h> +#include <linux/filelock.h> #include <linux/percpu_counter.h> #include <linux/siphash.h>
fs/ocfs2/locks.c +1 -0
@@ -8,6 +8,7 @@*/ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/fcntl.h> #include <cluster/masklog.h>
fs/ocfs2/stack_user.c +1 -0
@@ -9,6 +9,7 @@#include <linux/module.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/miscdevice.h> #include <linux/mutex.h> #include <linux/slab.h>
fs/open.c +1 -0
@@ -33,6 +33,7 @@#include <linux/dnotify.h> #include <linux/compat.h> #include <linux/mnt_idmapping.h> +#include <linux/filelock.h> #include "internal.h"
fs/orangefs/file.c +1 -0
@@ -14,6 +14,7 @@#include "orangefs-kernel.h" #include "orangefs-bufmap.h" #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/pagemap.h> static int flush_racache (struct inode *inode)
fs/posix_acl.c +1 -0
@@ -28,6 +28,7 @@#include <linux/security.h> #include <linux/evm.h> #include <linux/fsnotify.h> +#include <linux/filelock.h> #include "internal.h"
fs/proc/fd.c +1 -0
@@ -12,6 +12,7 @@#include <linux/file.h> #include <linux/seq_file.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/proc_fs.h>
fs/utimes.c +1 -0
@@ -7,6 +7,7 @@#include <linux/uaccess.h> #include <linux/compat.h> #include <asm/unistd.h> +#include <linux/filelock.h> static bool nsec_valid (long nsec) {
fs/xattr.c +1 -0
@@ -9,6 +9,7 @@Copyright (c) 2004 Red Hat, Inc., James Morris <[email protected]> */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/slab.h> #include <linux/file.h> #include <linux/xattr.h>
fs/xfs/xfs_linux.h +1 -0
@@ -34,6 +34,7 @@ typedef __u32 xfs_nlink_t;#include <linux/module.h> #include <linux/mutex.h> #include <linux/file.h> +#include <linux/filelock.h> #include <linux/swap.h> #include <linux/errno.h> #include <linux/sched/signal.h>
include/linux/filelock.h new file +438 -0
438 lines not on this page · raw message
include/linux/fs.h +0 -426
455 lines not on this page · raw message
include/linux/lockd/xdr.h +1 -0
@@ -11,6 +11,7 @@#define LOCKD_XDR_H #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/nfs.h> #include <linux/sunrpc/xdr.h>
Signature · 1 line
2.39.0
Al Viro
maintainerQuoted 9 lines · Jeff Layton
The file locking definitions have lived in
fs.hsince the dawn of time, but they are only used by a small subset of the source files that include it.Move the file locking definitions to a new header file, and add the appropriate #include directives to the source files that need them. By doing this we trim down
fs.ha bit and limit the amount of rebuilding that has to be done when we make changes to the file locking APIs.
Quoted 8 lines
Reviewed-by Xiubo Li <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by David Howells <[email protected]>Acked-by Chuck Lever <[email protected]>Acked-by Joseph Qi <[email protected]>Acked-by Steve French <[email protected]>Signed-off-by Jeff Layton <[email protected]>
Same question re git tree preferences (and my Acked-by in any case)
Jeff Layton
maintainerQuoted 19 lines · Al Viro
Quoted 9 lines · Jeff Layton
The file locking definitions have lived in
fs.hsince the dawn of time, but they are only used by a small subset of the source files that include it.Move the file locking definitions to a new header file, and add the appropriate #include directives to the source files that need them. By doing this we trim down
fs.ha bit and limit the amount of rebuilding that has to be done when we make changes to the file locking APIs.Quoted 8 lines
Reviewed-by Xiubo Li <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by David Howells <[email protected]>Acked-by Chuck Lever <[email protected]>Acked-by Joseph Qi <[email protected]>Acked-by Steve French <[email protected]>Signed-off-by Jeff Layton <[email protected]>
Quoted 1 line
Same question re git tree preferences (and my Acked-by in any case)
I'll take this one via the file locking tree as well. FWIW, I have some other filelock API changes I'd like to propose, so I think that'll be easier.
Thanks,
Signature · 1 line
Jeff Layton <[email protected]>
Quoted 9 lines · Jeff Layton
The file locking definitions have lived in
fs.hsince the dawn of time, but they are only used by a small subset of the source files that include it.Move the file locking definitions to a new header file, and add the appropriate #include directives to the source files that need them. By doing this we trim down
fs.ha bit and limit the amount of rebuilding that has to be done when we make changes to the file locking APIs.
Quoted 8 lines
Reviewed-by Xiubo Li <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by David Howells <[email protected]>Acked-by Chuck Lever <[email protected]>Acked-by Joseph Qi <[email protected]>Acked-by Steve French <[email protected]>Signed-off-by Jeff Layton <[email protected]>
The XFS part looks good,
--D
Quoted 1,436 lines
--- arch/arm/kernel/sys_oabi-compat.c | 1 + fs/9p/vfs_file.c | 1 + fs/afs/internal.h | 1 + fs/attr.c | 1 + fs/ceph/locks.c | 1 + fs/cifs/cifsfs.c | 1 + fs/cifs/cifsglob.h | 1 + fs/cifs/cifssmb.c | 1 + fs/cifs/file.c | 1 + fs/cifs/smb2file.c | 1 + fs/dlm/plock.c | 1 + fs/fcntl.c | 1 + fs/file_table.c | 1 + fs/fuse/file.c | 1 + fs/gfs2/file.c | 1 + fs/inode.c | 1 + fs/ksmbd/smb2pdu.c | 1 + fs/ksmbd/vfs.c | 1 + fs/ksmbd/vfs_cache.c | 1 + fs/lockd/clntproc.c | 1 + fs/lockd/netns.h | 1 + fs/locks.c | 1 + fs/namei.c | 1 + fs/nfs/file.c | 1 + fs/nfs/nfs4_fs.h | 1 + fs/nfs/pagelist.c | 1 + fs/nfs/write.c | 1 + fs/nfs_common/grace.c | 1 + fs/nfsd/netns.h | 1 + fs/ocfs2/locks.c | 1 + fs/ocfs2/stack_user.c | 1 + fs/open.c | 1 + fs/orangefs/file.c | 1 + fs/posix_acl.c | 1 + fs/proc/fd.c | 1 + fs/utimes.c | 1 + fs/xattr.c | 1 + fs/xfs/xfs_linux.h | 1 + include/linux/filelock.h | 438 ++++++++++++++++++++++++++++++ include/linux/fs.h | 426 ----------------------------- include/linux/lockd/xdr.h | 1 + 41 files changed, 477 insertions(+), 426 deletions(-) create mode 100644 include/linux/filelock.hv2:
- drop pointless externs from the newfilelock.h
- move include intoxfs_linux.hinstead ofxfs_buf.h
- havefilelock.h#includefs.h. Any file includingfilelock.hwill almost certainly needfs.hanyway.I've left some of Al's comments unaddressed for now, as I'd like to keep this move mostly mechanical, and no go changing function prototypes until the dust settles.
I'll plan to drop this into linux-next within the next few days, with an eye toward merging this for v6.3.
arch/arm/kernel/sys_oabi-compat.c +1
-0@@ -73,6 +73,7 @@#include <linux/syscalls.h> #include <linux/errno.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/cred.h> #include <linux/fcntl.h> #include <linux/eventpoll.h> fs/9p/vfs_file.c +1
-0@@ -9,6 +9,7 @@#include <linux/module.h> #include <linux/errno.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/sched.h> #include <linux/file.h> #include <linux/stat.h> fs/afs/internal.h +1
-0@@ -9,6 +9,7 @@#include <linux/kernel.h> #include <linux/ktime.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/pagemap.h> #include <linux/rxrpc.h> #include <linux/key.h> fs/attr.c +1
-0@@ -14,6 +14,7 @@#include <linux/capability.h> #include <linux/fsnotify.h> #include <linux/fcntl.h> +#include <linux/filelock.h> #include <linux/security.h> #include <linux/evm.h> #include <linux/ima.h> fs/ceph/locks.c +1
-0@@ -7,6 +7,7 @@#include "super.h" #include "mds_client.h" +#include <linux/filelock.h> #include <linux/ceph/pagelist.h> static u64 lock_secret;fs/cifs/cifsfs.c +1
-0@@ -12,6 +12,7 @@#include <linux/module.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/mount.h> #include <linux/slab.h> #include <linux/init.h> fs/cifs/cifsglob.h +1
-0@@ -26,6 +26,7 @@#include <uapi/linux/cifs/cifs_mount.h> #include "../smbfs_common/smb2pdu.h" #include "smb2pdu.h" +#include <linux/filelock.h> #define SMB_PATH_MAX 260#define CIFS_PORT 445fs/cifs/cifssmb.c +1
-0@@ -15,6 +15,7 @@/* want to reuse a stale file handle and only the caller knows the file info */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/kernel.h> #include <linux/vfs.h> #include <linux/slab.h> fs/cifs/file.c +1
-0@@ -9,6 +9,7 @@* */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/backing-dev.h> #include <linux/stat.h> #include <linux/fcntl.h> fs/cifs/smb2file.c +1
-0@@ -7,6 +7,7 @@* */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/stat.h> #include <linux/slab.h> #include <linux/pagemap.h> fs/dlm/plock.c +1
-0@@ -4,6 +4,7 @@*/ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/miscdevice.h> #include <linux/poll.h> #include <linux/dlm.h> fs/fcntl.c +1
-0@@ -10,6 +10,7 @@#include <linux/mm.h> #include <linux/sched/task.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/file.h> #include <linux/fdtable.h> #include <linux/capability.h> fs/file_table.c +1
-0@@ -13,6 +13,7 @@#include <linux/init.h> #include <linux/module.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/security.h> #include <linux/cred.h> #include <linux/eventpoll.h> fs/fuse/file.c +1
-0@@ -18,6 +18,7 @@#include <linux/falloc.h> #include <linux/uio.h> #include <linux/fs.h> +#include <linux/filelock.h> static int fuse_send_open(struct fuse_mount *fm, u64 nodeid, unsigned int open_flags, int opcode,fs/gfs2/file.c +1
-0@@ -15,6 +15,7 @@#include <linux/mm.h> #include <linux/mount.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/gfs2_ondisk.h> #include <linux/falloc.h> #include <linux/swap.h> fs/inode.c +1
-0@@ -5,6 +5,7 @@*/ #include <linux/export.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/mm.h> #include <linux/backing-dev.h> #include <linux/hash.h> fs/ksmbd/smb2pdu.c +1
-0@@ -12,6 +12,7 @@#include <linux/ethtool.h> #include <linux/falloc.h> #include <linux/mount.h> +#include <linux/filelock.h> #include "glob.h" #include "smbfsctl.h" fs/ksmbd/vfs.c +1
-0@@ -6,6 +6,7 @@#include <linux/kernel.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/uaccess.h> #include <linux/backing-dev.h> #include <linux/writeback.h> fs/ksmbd/vfs_cache.c +1
-0@@ -5,6 +5,7 @@*/ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/slab.h> #include <linux/vmalloc.h> fs/lockd/clntproc.c +1
-0@@ -12,6 +12,7 @@#include <linux/types.h> #include <linux/errno.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/nfs_fs.h> #include <linux/utsname.h> #include <linux/freezer.h> fs/lockd/netns.h +1
-0@@ -3,6 +3,7 @@#define __LOCKD_NETNS_H__#include <linux/fs.h> +#include <linux/filelock.h> #include <net/netns/generic.h> struct lockd_net {fs/locks.c +1
-0@@ -52,6 +52,7 @@#include <linux/capability.h> #include <linux/file.h> #include <linux/fdtable.h> +#include <linux/filelock.h> #include <linux/fs.h> #include <linux/init.h> #include <linux/security.h> fs/namei.c +1
-0@@ -20,6 +20,7 @@#include <linux/kernel.h> #include <linux/slab.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/namei.h> #include <linux/pagemap.h> #include <linux/sched/mm.h> fs/nfs/file.c +1
-0@@ -31,6 +31,7 @@#include <linux/swap.h> #include <linux/uaccess.h> +#include <linux/filelock.h> #include "delegation.h" #include "internal.h" fs/nfs/nfs4_fs.h +1
-0@@ -23,6 +23,7 @@#define NFS4_MAX_LOOP_ON_RECOVER (10)#include <linux/seqlock.h> +#include <linux/filelock.h> struct idmap ;fs/nfs/pagelist.c +1
-0@@ -21,6 +21,7 @@#include <linux/nfs_page.h> #include <linux/nfs_mount.h> #include <linux/export.h> +#include <linux/filelock.h> #include "internal.h" #include "pnfs.h" fs/nfs/write.c +1
-0@@ -25,6 +25,7 @@#include <linux/freezer.h> #include <linux/wait.h> #include <linux/iversion.h> +#include <linux/filelock.h> #include <linux/uaccess.h> #include <linux/sched/mm.h> fs/nfs_common/grace.c +1
-0@@ -9,6 +9,7 @@#include <net/net_namespace.h> #include <net/netns/generic.h> #include <linux/fs.h> +#include <linux/filelock.h> static unsigned int grace_net_id;static DEFINE_SPINLOCK (grace_lock);fs/nfsd/netns.h +1
-0@@ -10,6 +10,7 @@#include <net/net_namespace.h> #include <net/netns/generic.h> +#include <linux/filelock.h> #include <linux/percpu_counter.h> #include <linux/siphash.h> fs/ocfs2/locks.c +1
-0@@ -8,6 +8,7 @@*/ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/fcntl.h> #include <cluster/masklog.h> fs/ocfs2/stack_user.c +1
-0@@ -9,6 +9,7 @@#include <linux/module.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/miscdevice.h> #include <linux/mutex.h> #include <linux/slab.h> fs/open.c +1
-0@@ -33,6 +33,7 @@#include <linux/dnotify.h> #include <linux/compat.h> #include <linux/mnt_idmapping.h> +#include <linux/filelock.h> #include "internal.h" fs/orangefs/file.c +1
-0@@ -14,6 +14,7 @@#include "orangefs-kernel.h" #include "orangefs-bufmap.h" #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/pagemap.h> static int flush_racache (struct inode *inode)fs/posix_acl.c +1
-0@@ -28,6 +28,7 @@#include <linux/security.h> #include <linux/evm.h> #include <linux/fsnotify.h> +#include <linux/filelock.h> #include "internal.h" fs/proc/fd.c +1
-0@@ -12,6 +12,7 @@#include <linux/file.h> #include <linux/seq_file.h> #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/proc_fs.h> fs/utimes.c +1
-0@@ -7,6 +7,7 @@#include <linux/uaccess.h> #include <linux/compat.h> #include <asm/unistd.h> +#include <linux/filelock.h> static bool nsec_valid (long nsec) {fs/xattr.c +1
-0@@ -9,6 +9,7 @@Copyright (c) 2004 Red Hat, Inc., James Morris <[email protected]> */ #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/slab.h> #include <linux/file.h> #include <linux/xattr.h> fs/xfs/xfs_linux.h +1
-0@@ -34,6 +34,7 @@ typedef __u32 xfs_nlink_t;#include <linux/module.h> #include <linux/mutex.h> #include <linux/file.h> +#include <linux/filelock.h> #include <linux/swap.h> #include <linux/errno.h> #include <linux/sched/signal.h> include/linux/filelock.h new file +438
-0@@ -0,0 +1,438 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_FILELOCK_H +#define _LINUX_FILELOCK_H + +#include <linux/fs.h> + +#define FL_POSIX 1 +#define FL_FLOCK 2 +#define FL_DELEG 4/* NFSv4 delegation */ +#define FL_ACCESS 8/* not trying to lock, just looking */ +#define FL_EXISTS 16/* when unlocking, test for existence */ +#define FL_LEASE 32/* lease held on this file */ +#define FL_CLOSE 64/* unlock on close */ +#define FL_SLEEP 128/* A blocking lock */ +#define FL_DOWNGRADE_PENDING 256/* Lease is being downgraded */ +#define FL_UNLOCK_PENDING 512/* Lease is being broken */ +#define FL_OFDLCK 1024/* lock is "owned" by struct file */ +#define FL_LAYOUT 2048/* outstanding pNFS layout */ +#define FL_RECLAIM 4096/* reclaiming from a reboot server */ + +#define FL_CLOSE_POSIX (FL_POSIX | FL_CLOSE) + +/* +* Special return value from posix_lock_file() and vfs_lock_file() for +* asynchronous locking. +*/ +#define FILE_LOCK_DEFERRED 1 + +struct file_lock ; + +struct file_lock_operations { +void (*fl_copy_lock)(struct file_lock *,struct file_lock *); +void (*fl_release_private)(struct file_lock *); +}; + +struct lock_manager_operations { +void *lm_mod_owner; +fl_owner_t (*lm_get_owner)(fl_owner_t ); +void (*lm_put_owner)(fl_owner_t ); +void (*lm_notify)(struct file_lock *);/* unblock callback */ +int (*lm_grant)(struct file_lock *,int ); +bool (*lm_break)(struct file_lock *); +int (*lm_change)(struct file_lock *,int ,struct list_head *); +void (*lm_setup)(struct file_lock *,void **); +bool (*lm_breaker_owns_lease)(struct file_lock *); +bool (*lm_lock_expirable)(struct file_lock *cfl); +void (*lm_expire_lock)(void ); +}; + +struct lock_manager { +struct list_head list; +/* +* NFSv4 and up also want opens blocked during the grace period; +* NLM doesn't care: +*/ +bool block_opens; +}; + +struct net ; +void locks_start_grace (struct net *,struct lock_manager *); +void locks_end_grace (struct lock_manager *); +bool locks_in_grace (struct net *); +bool opens_in_grace (struct net *); + +/* +* struct file_lock has a union that some filesystems use to track +* their own private info. The NFS side of things is defined here: +*/ +#include <linux/nfs_fs_i.h> + +/* +* struct file_lock represents a generic "file lock". It's used to represent +* POSIX byte range locks, BSD (flock) locks, and leases. It's important to +* note that the same struct is used to represent both a request for a lock and +* the lock itself, but the same object is never used for both. +* +* FIXME: should we create a separate "struct lock_request" to help distinguish +* these two uses? +* +* The varous i_flctx lists are ordered by: +* +* 1) lock owner +* 2) lock range start +* 3) lock range end +* +* Obviously, the last two criteria only matter for POSIX locks. +*/ +struct file_lock { +struct file_lock *fl_blocker;/* The lock, that is blocking us */ +struct list_head fl_list;/* link into file_lock_context */ +struct hlist_node fl_link;/* node in global lists */ +struct list_head fl_blocked_requests;/* list of requests with +* ->fl_blocker pointing here +*/ +struct list_head fl_blocked_member;/* node in +* ->fl_blocker->fl_blocked_requests +*/ +fl_owner_t fl_owner; +unsigned int fl_flags; +unsigned char fl_type; +unsigned int fl_pid; +int fl_link_cpu;/* what cpu's list is this on? */ +wait_queue_head_t fl_wait; +struct file *fl_file; +loff_t fl_start; +loff_t fl_end; + +struct fasync_struct * fl_fasync;/* for lease break notifications */ +/* for lease breaks: */ +unsigned long fl_break_time; +unsigned long fl_downgrade_time; + +const struct file_lock_operations *fl_ops;/* Callbacks for filesystems */ +const struct lock_manager_operations *fl_lmops;/* Callbacks for lockmanagers */ +union { +struct nfs_lock_info nfs_fl; +struct nfs4_lock_info nfs4_fl; +struct { +struct list_head link;/* link in AFS vnode's pending_locks list */ +int state;/* state of grant or error if -ve */ +unsigned int debug_id; + } afs; + } fl_u; +} __randomize_layout; + +struct file_lock_context { +spinlock_t flc_lock; +struct list_head flc_flock; +struct list_head flc_posix; +struct list_head flc_lease; +}; + +#define locks_inode (f) file_inode(f) + +#ifdef CONFIG_FILE_LOCKING +int fcntl_getlk (struct file *,unsigned int ,struct flock *); +int fcntl_setlk (unsigned int ,struct file *,unsigned int , +struct flock *); + +#if BITS_PER_LONG ==32 +int fcntl_getlk64 (struct file *,unsigned int ,struct flock64 *); +int fcntl_setlk64 (unsigned int ,struct file *,unsigned int , +struct flock64 *); +#endif + +int fcntl_setlease (unsigned int fd,struct file *filp,long arg); +int fcntl_getlease (struct file *filp); + +/* fs/locks.c */ +void locks_free_lock_context (struct inode *inode); +void locks_free_lock (struct file_lock *fl); +void locks_init_lock (struct file_lock *); +struct file_lock *locks_alloc_lock (void ); +void locks_copy_lock (struct file_lock *,struct file_lock *); +void locks_copy_conflock (struct file_lock *,struct file_lock *); +void locks_remove_posix (struct file *,fl_owner_t ); +void locks_remove_file (struct file *); +void locks_release_private (struct file_lock *); +void posix_test_lock (struct file *,struct file_lock *); +int posix_lock_file (struct file *,struct file_lock *,struct file_lock *); +int locks_delete_block (struct file_lock *); +int vfs_test_lock (struct file *,struct file_lock *); +int vfs_lock_file (struct file *,unsigned int ,struct file_lock *,struct file_lock *); +int vfs_cancel_lock (struct file *filp,struct file_lock *fl); +bool vfs_inode_has_locks (struct inode *inode); +int locks_lock_inode_wait (struct inode *inode,struct file_lock *fl); +int __break_lease (struct inode *inode,unsigned int flags,unsigned int type); +void lease_get_mtime (struct inode *,struct timespec64 *time); +int generic_setlease (struct file *,long ,struct file_lock **,void **priv); +int vfs_setlease (struct file *,long ,struct file_lock **,void **); +int lease_modify (struct file_lock *,int ,struct list_head *); + +struct notifier_block ; +int lease_register_notifier (struct notifier_block *); +void lease_unregister_notifier (struct notifier_block *); + +struct files_struct ; +void show_fd_locks (struct seq_file *f, +struct file *filp,struct files_struct *files); +bool locks_owner_has_blockers (struct file_lock_context *flctx, +fl_owner_t owner); + +static inline struct file_lock_context * +locks_inode_context (const struct inode *inode) +{ +return smp_load_acquire (&inode->i_flctx); +} + +#else /* !CONFIG_FILE_LOCKING */ +static inline int fcntl_getlk (struct file *file,unsigned int cmd, +struct flock __user *user) +{ +return -EINVAL ; +} + +static inline int fcntl_setlk (unsigned int fd,struct file *file, +unsigned int cmd,struct flock __user *user) +{ +return -EACCES ; +} + +#if BITS_PER_LONG ==32 +static inline int fcntl_getlk64 (struct file *file,unsigned int cmd, +struct flock64 *user) +{ +return -EINVAL ; +} + +static inline int fcntl_setlk64 (unsigned int fd,struct file *file, +unsigned int cmd,struct flock64 *user) +{ +return -EACCES ; +} +#endif +static inline int fcntl_setlease (unsigned int fd,struct file *filp,long arg) +{ +return -EINVAL ; +} + +static inline int fcntl_getlease (struct file *filp) +{ +return F_UNLCK ; +} + +static inline void +locks_free_lock_context (struct inode *inode) +{ +} + +static inline void locks_init_lock (struct file_lock *fl) +{ +return ; +} + +static inline void locks_copy_conflock (struct file_lock *new,struct file_lock *fl) +{ +return ; +} + +static inline void locks_copy_lock (struct file_lock *new,struct file_lock *fl) +{ +return ; +} + +static inline void locks_remove_posix (struct file *filp,fl_owner_t owner) +{ +return ; +} + +static inline void locks_remove_file (struct file *filp) +{ +return ; +} + +static inline void posix_test_lock (struct file *filp,struct file_lock *fl) +{ +return ; +} + +static inline int posix_lock_file (struct file *filp,struct file_lock *fl, +struct file_lock *conflock) +{ +return -ENOLCK ; +} + +static inline int locks_delete_block (struct file_lock *waiter) +{ +return -ENOENT ; +} + +static inline int vfs_test_lock (struct file *filp,struct file_lock *fl) +{ +return 0 ; +} + +static inline int vfs_lock_file (struct file *filp,unsigned int cmd, +struct file_lock *fl,struct file_lock *conf) +{ +return -ENOLCK ; +} + +static inline int vfs_cancel_lock (struct file *filp,struct file_lock *fl) +{ +return 0 ; +} + +static inline bool vfs_inode_has_locks (struct inode *inode) +{ +return false; +} + +static inline int locks_lock_inode_wait (struct inode *inode,struct file_lock *fl) +{ +return -ENOLCK ; +} + +static inline int __break_lease (struct inode *inode,unsigned int mode,unsigned int type) +{ +return 0 ; +} + +static inline void lease_get_mtime (struct inode *inode, +struct timespec64 *time) +{ +return ; +} + +static inline int generic_setlease (struct file *filp,long arg, +struct file_lock **flp,void **priv) +{ +return -EINVAL ; +} + +static inline int vfs_setlease (struct file *filp,long arg, +struct file_lock **lease,void **priv) +{ +return -EINVAL ; +} + +static inline int lease_modify (struct file_lock *fl,int arg, +struct list_head *dispose) +{ +return -EINVAL ; +} + +struct files_struct ; +static inline void show_fd_locks (struct seq_file *f, +struct file *filp,struct files_struct *files) {} +static inline bool locks_owner_has_blockers (struct file_lock_context *flctx, +fl_owner_t owner) +{ +return false; +} + +static inline struct file_lock_context * +locks_inode_context (const struct inode *inode) +{ +return NULL ; +} + +#endif /* !CONFIG_FILE_LOCKING */ + +static inline int locks_lock_file_wait (struct file *filp,struct file_lock *fl) +{ +return locks_lock_inode_wait (locks_inode (filp), fl); +} + +#ifdef CONFIG_FILE_LOCKING +static inline int break_lease (struct inode *inode,unsigned int mode) +{ +/* +* Since this check is lockless, we must ensure that any refcounts +* taken are done before checking i_flctx->flc_lease. Otherwise, we +* could end up racing with tasks trying to set a new lease on this +* file. +*/ +smp_mb (); +if (inode->i_flctx && !list_empty_careful (&inode->i_flctx->flc_lease)) +return __break_lease (inode, mode,FL_LEASE ); +return 0 ; +} + +static inline int break_deleg (struct inode *inode,unsigned int mode) +{ +/* +* Since this check is lockless, we must ensure that any refcounts +* taken are done before checking i_flctx->flc_lease. Otherwise, we +* could end up racing with tasks trying to set a new lease on this +* file. +*/ +smp_mb (); +if (inode->i_flctx && !list_empty_careful (&inode->i_flctx->flc_lease)) +return __break_lease (inode, mode,FL_DELEG ); +return 0 ; +} + +static inline int try_break_deleg (struct inode *inode,struct inode **delegated_inode) +{ +int ret; + + ret =break_deleg (inode,O_WRONLY |O_NONBLOCK ); +if (ret == -EWOULDBLOCK && delegated_inode) { + *delegated_inode = inode; +ihold (inode); + } +return ret; +} + +static inline int break_deleg_wait (struct inode **delegated_inode) +{ +int ret; + + ret =break_deleg (*delegated_inode,O_WRONLY ); +iput (*delegated_inode); + *delegated_inode =NULL ; +return ret; +} + +static inline int break_layout (struct inode *inode,bool wait) +{ +smp_mb (); +if (inode->i_flctx && !list_empty_careful (&inode->i_flctx->flc_lease)) +return __break_lease (inode, + wait ?O_WRONLY :O_WRONLY |O_NONBLOCK , +FL_LAYOUT ); +return 0 ; +} + +#else /* !CONFIG_FILE_LOCKING */ +static inline int break_lease (struct inode *inode,unsigned int mode) +{ +return 0 ; +} + +static inline int break_deleg (struct inode *inode,unsigned int mode) +{ +return 0 ; +} + +static inline int try_break_deleg (struct inode *inode,struct inode **delegated_inode) +{ +return 0 ; +} + +static inline int break_deleg_wait (struct inode **delegated_inode) +{ +BUG (); +return 0 ; +} + +static inline int break_layout (struct inode *inode,bool wait) +{ +return 0 ; +} + +#endif /* CONFIG_FILE_LOCKING */ + +#endif /* _LINUX_FILELOCK_H */ include/linux/fs.h +0
-426@@ -1003,132 +1003,11 @@ static inline struct file *get_file(struct file *f)#define MAX_LFS_FILESIZE ((loff_t)LLONG_MAX)#endif -#define FL_POSIX 1 -#define FL_FLOCK 2 -#define FL_DELEG 4/* NFSv4 delegation */ -#define FL_ACCESS 8/* not trying to lock, just looking */ -#define FL_EXISTS 16/* when unlocking, test for existence */ -#define FL_LEASE 32/* lease held on this file */ -#define FL_CLOSE 64/* unlock on close */ -#define FL_SLEEP 128/* A blocking lock */ -#define FL_DOWNGRADE_PENDING 256/* Lease is being downgraded */ -#define FL_UNLOCK_PENDING 512/* Lease is being broken */ -#define FL_OFDLCK 1024/* lock is "owned" by struct file */ -#define FL_LAYOUT 2048/* outstanding pNFS layout */ -#define FL_RECLAIM 4096/* reclaiming from a reboot server */ - -#define FL_CLOSE_POSIX (FL_POSIX | FL_CLOSE) - -/* -* Special return value from posix_lock_file() and vfs_lock_file() for -* asynchronous locking. -*/ -#define FILE_LOCK_DEFERRED 1 -/* legacy typedef, should eventually be removed */ typedef void *fl_owner_t ;struct file_lock ; -struct file_lock_operations { -void (*fl_copy_lock)(struct file_lock *,struct file_lock *); -void (*fl_release_private)(struct file_lock *); -}; - -struct lock_manager_operations { -void *lm_mod_owner; -fl_owner_t (*lm_get_owner)(fl_owner_t ); -void (*lm_put_owner)(fl_owner_t ); -void (*lm_notify)(struct file_lock *);/* unblock callback */ -int (*lm_grant)(struct file_lock *,int ); -bool (*lm_break)(struct file_lock *); -int (*lm_change)(struct file_lock *,int ,struct list_head *); -void (*lm_setup)(struct file_lock *,void **); -bool (*lm_breaker_owns_lease)(struct file_lock *); -bool (*lm_lock_expirable)(struct file_lock *cfl); -void (*lm_expire_lock)(void ); -}; - -struct lock_manager { -struct list_head list; -/* -* NFSv4 and up also want opens blocked during the grace period; -* NLM doesn't care: -*/ -bool block_opens; -}; - -struct net ; -void locks_start_grace (struct net *,struct lock_manager *); -void locks_end_grace (struct lock_manager *); -bool locks_in_grace (struct net *); -bool opens_in_grace (struct net *); - -/* that will die - we need it for nfs_lock_info */ -#include <linux/nfs_fs_i.h> - -/* -* struct file_lock represents a generic "file lock". It's used to represent -* POSIX byte range locks, BSD (flock) locks, and leases. It's important to -* note that the same struct is used to represent both a request for a lock and -* the lock itself, but the same object is never used for both. -* -* FIXME: should we create a separate "struct lock_request" to help distinguish -* these two uses? -* -* The varous i_flctx lists are ordered by: -* -* 1) lock owner -* 2) lock range start -* 3) lock range end -* -* Obviously, the last two criteria only matter for POSIX locks. -*/ -struct file_lock { -struct file_lock *fl_blocker;/* The lock, that is blocking us */ -struct list_head fl_list;/* link into file_lock_context */ -struct hlist_node fl_link;/* node in global lists */ -struct list_head fl_blocked_requests;/* list of requests with -* ->fl_blocker pointing here -*/ -struct list_head fl_blocked_member;/* node in -* ->fl_blocker->fl_blocked_requests -*/ -fl_owner_t fl_owner; -unsigned int fl_flags; -unsigned char fl_type; -unsigned int fl_pid; -int fl_link_cpu;/* what cpu's list is this on? */ -wait_queue_head_t fl_wait; -struct file *fl_file; -loff_t fl_start; -loff_t fl_end; - -struct fasync_struct * fl_fasync;/* for lease break notifications */ -/* for lease breaks: */ -unsigned long fl_break_time; -unsigned long fl_downgrade_time; - -const struct file_lock_operations *fl_ops;/* Callbacks for filesystems */ -const struct lock_manager_operations *fl_lmops;/* Callbacks for lockmanagers */ -union { -struct nfs_lock_info nfs_fl; -struct nfs4_lock_info nfs4_fl; -struct { -struct list_head link;/* link in AFS vnode's pending_locks list */ -int state;/* state of grant or error if -ve */ -unsigned int debug_id; - } afs; - } fl_u; -} __randomize_layout; - -struct file_lock_context { -spinlock_t flc_lock; -struct list_head flc_flock; -struct list_head flc_posix; -struct list_head flc_lease; -}; -/* The following constant reflects the upper bound of the file/locking space */ #ifndef OFFSET_MAX #define OFFSET_MAX type_max(loff_t)@@ -1137,216 +1016,6 @@ struct file_lock_context {extern void send_sigio (struct fown_struct *fown,int fd,int band); -#define locks_inode (f) file_inode(f) - -#ifdef CONFIG_FILE_LOCKING -extern int fcntl_getlk (struct file *,unsigned int ,struct flock *); -extern int fcntl_setlk (unsigned int ,struct file *,unsigned int , -struct flock *); - -#if BITS_PER_LONG ==32 -extern int fcntl_getlk64 (struct file *,unsigned int ,struct flock64 *); -extern int fcntl_setlk64 (unsigned int ,struct file *,unsigned int , -struct flock64 *); -#endif - -extern int fcntl_setlease (unsigned int fd,struct file *filp,long arg); -extern int fcntl_getlease (struct file *filp); - -/* fs/locks.c */ -void locks_free_lock_context (struct inode *inode); -void locks_free_lock (struct file_lock *fl); -extern void locks_init_lock (struct file_lock *); -extern struct file_lock *locks_alloc_lock (void ); -extern void locks_copy_lock (struct file_lock *,struct file_lock *); -extern void locks_copy_conflock (struct file_lock *,struct file_lock *); -extern void locks_remove_posix (struct file *,fl_owner_t ); -extern void locks_remove_file (struct file *); -extern void locks_release_private (struct file_lock *); -extern void posix_test_lock (struct file *,struct file_lock *); -extern int posix_lock_file (struct file *,struct file_lock *,struct file_lock *); -extern int locks_delete_block (struct file_lock *); -extern int vfs_test_lock (struct file *,struct file_lock *); -extern int vfs_lock_file (struct file *,unsigned int ,struct file_lock *,struct file_lock *); -extern int vfs_cancel_lock (struct file *filp,struct file_lock *fl); -bool vfs_inode_has_locks (struct inode *inode); -extern int locks_lock_inode_wait (struct inode *inode,struct file_lock *fl); -extern int __break_lease (struct inode *inode,unsigned int flags,unsigned int type); -extern void lease_get_mtime (struct inode *,struct timespec64 *time); -extern int generic_setlease (struct file *,long ,struct file_lock **,void **priv); -extern int vfs_setlease (struct file *,long ,struct file_lock **,void **); -extern int lease_modify (struct file_lock *,int ,struct list_head *); - -struct notifier_block ; -extern int lease_register_notifier (struct notifier_block *); -extern void lease_unregister_notifier (struct notifier_block *); - -struct files_struct ; -extern void show_fd_locks (struct seq_file *f, -struct file *filp,struct files_struct *files); -extern bool locks_owner_has_blockers (struct file_lock_context *flctx, -fl_owner_t owner); - -static inline struct file_lock_context * -locks_inode_context (const struct inode *inode) -{ -return smp_load_acquire (&inode->i_flctx); -} - -#else /* !CONFIG_FILE_LOCKING */ -static inline int fcntl_getlk (struct file *file,unsigned int cmd, -struct flock __user *user) -{ -return -EINVAL ; -} - -static inline int fcntl_setlk (unsigned int fd,struct file *file, -unsigned int cmd,struct flock __user *user) -{ -return -EACCES ; -} - -#if BITS_PER_LONG ==32 -static inline int fcntl_getlk64 (struct file *file,unsigned int cmd, -struct flock64 *user) -{ -return -EINVAL ; -} - -static inline int fcntl_setlk64 (unsigned int fd,struct file *file, -unsigned int cmd,struct flock64 *user) -{ -return -EACCES ; -} -#endif -static inline int fcntl_setlease (unsigned int fd,struct file *filp,long arg) -{ -return -EINVAL ; -} - -static inline int fcntl_getlease (struct file *filp) -{ -return F_UNLCK ; -} - -static inline void -locks_free_lock_context (struct inode *inode) -{ -} - -static inline void locks_init_lock (struct file_lock *fl) -{ -return ; -} - -static inline void locks_copy_conflock (struct file_lock *new,struct file_lock *fl) -{ -return ; -} - -static inline void locks_copy_lock (struct file_lock *new,struct file_lock *fl) -{ -return ; -} - -static inline void locks_remove_posix (struct file *filp,fl_owner_t owner) -{ -return ; -} - -static inline void locks_remove_file (struct file *filp) -{ -return ; -} - -static inline void posix_test_lock (struct file *filp,struct file_lock *fl) -{ -return ; -} - -static inline int posix_lock_file (struct file *filp,struct file_lock *fl, -struct file_lock *conflock) -{ -return -ENOLCK ; -} - -static inline int locks_delete_block (struct file_lock *waiter) -{ -return -ENOENT ; -} - -static inline int vfs_test_lock (struct file *filp,struct file_lock *fl) -{ -return 0 ; -} - -static inline int vfs_lock_file (struct file *filp,unsigned int cmd, -struct file_lock *fl,struct file_lock *conf) -{ -return -ENOLCK ; -} - -static inline int vfs_cancel_lock (struct file *filp,struct file_lock *fl) -{ -return 0 ; -} - -static inline bool vfs_inode_has_locks (struct inode *inode) -{ -return false; -} - -static inline int locks_lock_inode_wait (struct inode *inode,struct file_lock *fl) -{ -return -ENOLCK ; -} - -static inline int __break_lease (struct inode *inode,unsigned int mode,unsigned int type) -{ -return 0 ; -} - -static inline void lease_get_mtime (struct inode *inode, -struct timespec64 *time) -{ -return ; -} - -static inline int generic_setlease (struct file *filp,long arg, -struct file_lock **flp,void **priv) -{ -return -EINVAL ; -} - -static inline int vfs_setlease (struct file *filp,long arg, -struct file_lock **lease,void **priv) -{ -return -EINVAL ; -} - -static inline int lease_modify (struct file_lock *fl,int arg, -struct list_head *dispose) -{ -return -EINVAL ; -} - -struct files_struct ; -static inline void show_fd_locks (struct seq_file *f, -struct file *filp,struct files_struct *files) {} -static inline bool locks_owner_has_blockers (struct file_lock_context *flctx, -fl_owner_t owner) -{ -return false; -} - -static inline struct file_lock_context * -locks_inode_context (const struct inode *inode) -{ -return NULL ; -} - -#endif /* !CONFIG_FILE_LOCKING */ -static inline struct inode *file_inode (const struct file *f) {return f->f_inode;@@ -1357,11 +1026,6 @@ static inline struct dentry *file_dentry(const struct file *file)return d_real (file->f_path.dentry,file_inode (file)); } -static inline int locks_lock_file_wait (struct file *filp,struct file_lock *fl) -{ -return locks_lock_inode_wait (locks_inode (filp), fl); -} -struct fasync_struct {rwlock_t fa_lock;int magic;@@ -2621,96 +2285,6 @@ extern struct kobject *fs_kobj;#define MAX_RW_COUNT (INT_MAX & PAGE_MASK) -#ifdef CONFIG_FILE_LOCKING -static inline int break_lease (struct inode *inode,unsigned int mode) -{ -/* -* Since this check is lockless, we must ensure that any refcounts -* taken are done before checking i_flctx->flc_lease. Otherwise, we -* could end up racing with tasks trying to set a new lease on this -* file. -*/ -smp_mb (); -if (inode->i_flctx && !list_empty_careful (&inode->i_flctx->flc_lease)) -return __break_lease (inode, mode,FL_LEASE ); -return 0 ; -} - -static inline int break_deleg (struct inode *inode,unsigned int mode) -{ -/* -* Since this check is lockless, we must ensure that any refcounts -* taken are done before checking i_flctx->flc_lease. Otherwise, we -* could end up racing with tasks trying to set a new lease on this -* file. -*/ -smp_mb (); -if (inode->i_flctx && !list_empty_careful (&inode->i_flctx->flc_lease)) -return __break_lease (inode, mode,FL_DELEG ); -return 0 ; -} - -static inline int try_break_deleg (struct inode *inode,struct inode **delegated_inode) -{ -int ret; - - ret =break_deleg (inode,O_WRONLY |O_NONBLOCK ); -if (ret == -EWOULDBLOCK && delegated_inode) { - *delegated_inode = inode; -ihold (inode); - } -return ret; -} - -static inline int break_deleg_wait (struct inode **delegated_inode) -{ -int ret; - - ret =break_deleg (*delegated_inode,O_WRONLY ); -iput (*delegated_inode); - *delegated_inode =NULL ; -return ret; -} - -static inline int break_layout (struct inode *inode,bool wait) -{ -smp_mb (); -if (inode->i_flctx && !list_empty_careful (&inode->i_flctx->flc_lease)) -return __break_lease (inode, - wait ?O_WRONLY :O_WRONLY |O_NONBLOCK , -FL_LAYOUT ); -return 0 ; -} - -#else /* !CONFIG_FILE_LOCKING */ -static inline int break_lease (struct inode *inode,unsigned int mode) -{ -return 0 ; -} - -static inline int break_deleg (struct inode *inode,unsigned int mode) -{ -return 0 ; -} - -static inline int try_break_deleg (struct inode *inode,struct inode **delegated_inode) -{ -return 0 ; -} - -static inline int break_deleg_wait (struct inode **delegated_inode) -{ -BUG (); -return 0 ; -} - -static inline int break_layout (struct inode *inode,bool wait) -{ -return 0 ; -} - -#endif /* CONFIG_FILE_LOCKING */ -/* fs/open.c */ struct audit_names ;struct filename {include/linux/lockd/xdr.h +1
-0@@ -11,6 +11,7 @@#define LOCKD_XDR_H #include <linux/fs.h> +#include <linux/filelock.h> #include <linux/nfs.h> #include <linux/sunrpc/xdr.h> Signature · 1 line
2.39.0
Quoted 17 lines · Jeff Layton
The file locking definitions have lived in
fs.hsince the dawn of time, but they are only used by a small subset of the source files that include it.Move the file locking definitions to a new header file, and add the appropriate #include directives to the source files that need them. By doing this we trim down
fs.ha bit and limit the amount of rebuilding that has to be done when we make changes to the file locking APIs.Reviewed-by Xiubo Li <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by David Howells <[email protected]>Acked-by Chuck Lever <[email protected]>Acked-by Joseph Qi <[email protected]>Acked-by Steve French <[email protected]>Signed-off-by Jeff Layton <[email protected]>
Quoted 6 lines
--- arch/arm/kernel/sys_oabi-compat.c | 1 + fs/9p/vfs_file.c | 1 + fs/afs/internal.h | 1 + fs/attr.c | 1 + fs/ceph/locks.c | 1 +
ceph part looks good to me.
Thanks
- Xiubo
Quoted 17 lines · Jeff Layton
The file locking definitions have lived in
fs.hsince the dawn of time, but they are only used by a small subset of the source files that include it.Move the file locking definitions to a new header file, and add the appropriate #include directives to the source files that need them. By doing this we trim down
fs.ha bit and limit the amount of rebuilding that has to be done when we make changes to the file locking APIs.Reviewed-by Xiubo Li <[email protected]>Reviewed-by Christoph Hellwig <[email protected]>Reviewed-by David Howells <[email protected]>Acked-by Chuck Lever <[email protected]>Acked-by Joseph Qi <[email protected]>Acked-by Steve French <[email protected]>Signed-off-by Jeff Layton <[email protected]>
Quoted 2 lines
--- arch/arm/kernel/sys_oabi-compat.c | 1 +
For arm:
Thanks.
Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!