Skip to contentSkip to conversation

ARM: S3C24XX: add missing dma-devices and warning fix

PATCH RESEND Superseded Heiko Stübner 6 participants 16 messages Oct 11, 2013 – Oct 20, 2013 1 message not in the archive

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

[I messed up the linux-arm-kernel list address yesterday, so I resend it with a fixed address, sorry for the noise]

When Olof reported the warning about the unused s3c2410_dma_resource, I thought the best way forward would be to simply implement the missing pieces and so it has users :-) .

Therefore this series adds the necessary platform-devices for s3c2410, s3c2440 and s3c2442. This especially also includes the channel-constraints of those socs.

As I do not have access to any of those socs these changes are of course compile-tested only.

Heiko Stuebner (3):
ARM: S3C24XX: Fix possible dma selection warning
dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller
ARM: S3C24XX: add dma platformdata for s3c2410, s3c2440 and s3c2442

 arch/arm/mach-s3c24xx/Kconfig             |    3 +-
 arch/arm/mach-s3c24xx/common.c            |  100 +++++++++++++++++++++++++++++
 arch/arm/mach-s3c24xx/common.h            |    2 +
 drivers/dma/s3c24xx-dma.c                 |   10 +++
 include/linux/platform_data/dma-s3c24xx.h |    3 +
 sound/soc/samsung/Kconfig                 |    2 +-
 6 files changed, 118 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH RESEND 1/3 ARM: S3C24XX: Fix possible dma selection warning

Currently the s3c sound support selects CONFIG_S3C2410_DMA on s3c24xx architectures while the generic dma config is enabled by CONFIG_S3C24XX_DMA.

With the way the Kconfig options are layed out currently it is possible to enable Samsung sound support without enabling the necessary dma support resulting in warnings like
warning: (SND_SOC_SAMSUNG && SND_S3C24XX_I2S && SND_S3C2412_SOC_I2S &&

       SND_SOC_SAMSUNG_SMDK2443_WM9710 && SND_SOC_SAMSUNG_LN2440SBC_ALC650)
  selects S3C2410_DMA which has unmet direct dependencies (ARCH_S3C24XX &&
       S3C24XX_DMA && (CPU_S3C2410 || CPU_S3C2442))

Therefore bring the s3c2410 dma support in line with the way the other s3c24xx SoCs handle this by having the SoC dma-support selected if the generic s3c dma support is enabled and have the sound support depend on S3C24XX_DMA on these arches. The s3c2442 is using the same dma descriptors and therefore also selected S3C2410_DMA.

---
 arch/arm/mach-s3c24xx/Kconfig |    3 ++-
 sound/soc/samsung/Kconfig     |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-s3c24xx/Kconfig +2 -1
index dba2173..8f1d327 100644
@@ -28,6 +28,7 @@ config CPU_S3C2410
 	select CPU_ARM920T
 	select CPU_LLSERIAL_S3C2410
 	select S3C2410_CLOCK
+	select S3C2410_DMA if S3C24XX_DMA
 	select ARM_S3C2410_CPUFREQ if ARM_S3C24XX_CPUFREQ
 	select S3C2410_PM if PM
 	select SAMSUNG_WDT_RESET
@@ -70,6 +71,7 @@ config CPU_S3C2442
 	select CPU_ARM920T
 	select CPU_LLSERIAL_S3C2440
 	select S3C2410_CLOCK
+	select S3C2410_DMA if S3C24XX_DMA
 	select S3C2410_PM if PM
 	help
 	  Support for S3C2442 Samsung Mobile CPU based systems.
@@ -148,7 +150,6 @@ config S3C2410_DMA_DEBUG
 config S3C2410_DMA
 	bool
 	depends on S3C24XX_DMA && (CPU_S3C2410 || CPU_S3C2442)
-	default y if CPU_S3C2410 || CPU_S3C2442
 	help
 	  DMA device selection for S3C2410 and compatible CPUs
 
sound/soc/samsung/Kconfig +1 -1
index 2eea184..37459df 100644
@@ -2,7 +2,7 @@ config SND_SOC_SAMSUNG
 	tristate "ASoC support for Samsung"
 	depends on PLAT_SAMSUNG
 	select S3C64XX_DMA if ARCH_S3C64XX
-	select S3C2410_DMA if ARCH_S3C24XX
+	select S3C24XX_DMA if ARCH_S3C24XX
 	help
 	  Say Y or M if you want to add support for codecs attached to
 	  the Samsung SoCs' Audio interfaces. You will also need to
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH RESEND 2/3 dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller

In reply to Heiko Stübner

The earliest variants of the dma controller did not contain support for controlling clocks.

---
 drivers/dma/s3c24xx-dma.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/dma/s3c24xx-dma.c +10 -0
index 56c9253..4cb1279 100644
@@ -1078,6 +1078,13 @@ static void s3c24xx_dma_free_virtual_channels(struct dma_device *dmadev)
 		list_del(&chan->vc.chan.device_node);
 }
 
+/* s3c2410, s3c2440 and s3c2442 have a 0x40 stride without separate clocks */
+static struct soc_data soc_s3c2410 = {
+	.stride = 0x40,
+	.has_reqsel = false,
+	.has_clocks = false,
+};
+
 /* s3c2412 and s3c2413 have a 0x40 stride and dmareqsel mechanism */
 static struct soc_data soc_s3c2412 = {
 	.stride = 0x40,
@@ -1094,6 +1101,9 @@ static struct soc_data soc_s3c2443 = {
 
 static struct platform_device_id s3c24xx_dma_driver_ids[] = {
 	{
+		.name		= "s3c2410-dma",
+		.driver_data	= (kernel_ulong_t)&soc_s3c2410,
+	}, {
 		.name		= "s3c2412-dma",
 		.driver_data	= (kernel_ulong_t)&soc_s3c2412,
 	}, {
Signature · 1 line
1.7.10.4
#3 lore raw

PATCH RESEND 2/3 dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller

Quoted 2 lines · Heiko St?bner

The earliest variants of the dma controller did not contain support for controlling clocks.

Quoted 37 lines
---
 drivers/dma/s3c24xx-dma.c |   10 ++++++++++
 1 file changed, 10 insertions(+)
drivers/dma/s3c24xx-dma.c +10 -0
index 56c9253..4cb1279 100644
@@ -1078,6 +1078,13 @@ static void s3c24xx_dma_free_virtual_channels(struct dma_device *dmadev)
 		list_del(&chan->vc.chan.device_node);
 }
 
+/* s3c2410, s3c2440 and s3c2442 have a 0x40 stride without separate clocks */
+static struct soc_data soc_s3c2410 = {
+	.stride = 0x40,
+	.has_reqsel = false,
+	.has_clocks = false,
+};
+
 /* s3c2412 and s3c2413 have a 0x40 stride and dmareqsel mechanism */
 static struct soc_data soc_s3c2412 = {
 	.stride = 0x40,
@@ -1094,6 +1101,9 @@ static struct soc_data soc_s3c2443 = {
 
 static struct platform_device_id s3c24xx_dma_driver_ids[] = {
 	{
+		.name		= "s3c2410-dma",
+		.driver_data	= (kernel_ulong_t)&soc_s3c2410,
+	}, {
 		.name		= "s3c2412-dma",
 		.driver_data	= (kernel_ulong_t)&soc_s3c2412,
 	}, {
Signature · 1 line
1.7.10.4
#4 lore raw

PATCH RESEND 3/3 ARM: S3C24XX: add dma pdata for s3c2410, s3c2440 and s3c2442

In reply to Heiko Stübner

s3c2410 and s3c2442 share the same dma channels while s3c2440 has slight differences. But on all three the reachable sources per dma channel has constraints attached and thus encodes the usable combinations using the S3C24XX_DMA_CHANREQ macro.

This also fixes the warning about s3c2410_dma_resource being unused as reported by Olof Johansson.

---
 arch/arm/mach-s3c24xx/common.c            |  100 +++++++++++++++++++++++++++++
 arch/arm/mach-s3c24xx/common.h            |    2 +
 include/linux/platform_data/dma-s3c24xx.h |    3 +
 3 files changed, 105 insertions(+)
arch/arm/mach-s3c24xx/common.c +100 -0
index 16ac669..4cfe7a4 100644
@@ -343,6 +343,50 @@ static struct resource s3c2410_dma_resource[] = {
 };
 #endif
 
+#if defined(CONFIG_CPU_S3C2410) || defined(CONFIG_CPU_S3C2442)
+static struct s3c24xx_dma_channel s3c2410_dma_channels[DMACH_MAX] = {
+	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 0), },
+	[DMACH_XD1] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 1), },
+	[DMACH_SDI] = { S3C24XX_DMA_APB, false, S3C24XX_DMA_CHANREQ(2, 0) |
+						S3C24XX_DMA_CHANREQ(2, 2) |
+						S3C24XX_DMA_CHANREQ(1, 3),
+	},
+	[DMACH_SPI0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 1), },
+	[DMACH_SPI1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 3), },
+	[DMACH_UART0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 0), },
+	[DMACH_UART1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 1), },
+	[DMACH_UART2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 3), },
+	[DMACH_TIMER] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 0) |
+						 S3C24XX_DMA_CHANREQ(3, 2) |
+						 S3C24XX_DMA_CHANREQ(3, 3),
+	},
+	[DMACH_I2S_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 1) |
+						  S3C24XX_DMA_CHANREQ(1, 2),
+	},
+	[DMACH_I2S_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 2), },
+	[DMACH_USB_EP1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 0), },
+	[DMACH_USB_EP2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 1), },
+	[DMACH_USB_EP3] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 2), },
+	[DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), },
+};
+
+static struct s3c24xx_dma_platdata s3c2410_dma_platdata = {
+	.num_phy_channels = 4,
+	.channels = s3c2410_dma_channels,
+	.num_channels = DMACH_MAX,
+};
+
+struct platform_device s3c2410_device_dma = {
+	.name		= "s3c2410-dma",
+	.id		= 0,
+	.num_resources	= ARRAY_SIZE(s3c2410_dma_resource),
+	.resource	= s3c2410_dma_resource,
+	.dev	= {
+		.platform_data	= &s3c2410_dma_platdata,
+	},
+};
+#endif
+
 #ifdef CONFIG_CPU_S3C2412
 static struct s3c24xx_dma_channel s3c2412_dma_channels[DMACH_MAX] = {
 	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, 17 },
@@ -384,6 +428,62 @@ struct platform_device s3c2412_device_dma = {
 };
 #endif
 
+#if defined(CONFIG_CPU_S3C2440)
+static struct s3c24xx_dma_channel s3c2440_dma_channels[DMACH_MAX] = {
+	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 0), },
+	[DMACH_XD1] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 1), },
+	[DMACH_SDI] = { S3C24XX_DMA_APB, false, S3C24XX_DMA_CHANREQ(2, 0) |
+						S3C24XX_DMA_CHANREQ(6, 1) |
+						S3C24XX_DMA_CHANREQ(2, 2) |
+						S3C24XX_DMA_CHANREQ(1, 3),
+	},
+	[DMACH_SPI0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 1), },
+	[DMACH_SPI1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 3), },
+	[DMACH_UART0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 0), },
+	[DMACH_UART1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 1), },
+	[DMACH_UART2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 3), },
+	[DMACH_TIMER] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 0) |
+						 S3C24XX_DMA_CHANREQ(3, 2) |
+						 S3C24XX_DMA_CHANREQ(3, 3),
+	},
+	[DMACH_I2S_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 1) |
+						  S3C24XX_DMA_CHANREQ(1, 2),
+	},
+	[DMACH_I2S_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(5, 0) |
+						   S3C24XX_DMA_CHANREQ(0, 2),
+	},
+	[DMACH_PCM_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(6, 0) |
+						  S3C24XX_DMA_CHANREQ(5, 2),
+	},
+	[DMACH_PCM_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(5, 1) |
+						  S3C24XX_DMA_CHANREQ(6, 3),
+	},
+	[DMACH_MIC_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(6, 2) |
+						  S3C24XX_DMA_CHANREQ(5, 3),
+	},
+	[DMACH_USB_EP1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 0), },
+	[DMACH_USB_EP2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 1), },
+	[DMACH_USB_EP3] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 2), },
+	[DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), },
+};
+
+static struct s3c24xx_dma_platdata s3c2440_dma_platdata = {
+	.num_phy_channels = 4,
+	.channels = s3c2440_dma_channels,
+	.num_channels = DMACH_MAX,
+};
+
+struct platform_device s3c2440_device_dma = {
+	.name		= "s3c2410-dma",
+	.id		= 0,
+	.num_resources	= ARRAY_SIZE(s3c2410_dma_resource),
+	.resource	= s3c2410_dma_resource,
+	.dev	= {
+		.platform_data	= &s3c2440_dma_platdata,
+	},
+};
+#endif
+
 #if defined(CONFIG_CPUS_3C2443) || defined(CONFIG_CPU_S3C2416)
 static struct resource s3c2443_dma_resource[] = {
 	[0] = DEFINE_RES_MEM(S3C24XX_PA_DMA, S3C24XX_SZ_DMA),
arch/arm/mach-s3c24xx/common.h +2 -0
index fe07189..e46c104 100644
@@ -109,7 +109,9 @@ extern void s3c2443_init_irq(void);
 
 extern struct syscore_ops s3c24xx_irq_syscore_ops;
 
+extern struct platform_device s3c2410_device_dma;
 extern struct platform_device s3c2412_device_dma;
+extern struct platform_device s3c2440_device_dma;
 extern struct platform_device s3c2443_device_dma;
 
 #endif /* __ARCH_ARM_MACH_S3C24XX_COMMON_H */
include/linux/platform_data/dma-s3c24xx.h +3 -0
index 5a0cfff..89ba1b0 100644
@@ -9,6 +9,9 @@
  * any later version.
  */
 
+/* Helper to encode the source selection constraints for early s3c socs. */
+#define S3C24XX_DMA_CHANREQ(src, chan)	((BIT(3) | src) << chan * 4)
+
 enum s3c24xx_dma_bus {
 	S3C24XX_DMA_APB,
 	S3C24XX_DMA_AHB,
Signature · 1 line
1.7.10.4
#5 lore raw

PATCH RESEND 3/3 ARM: S3C24XX: add dma pdata for s3c2410, s3c2440 and s3c2442

Quoted 7 lines · Heiko St?bner

s3c2410 and s3c2442 share the same dma channels while s3c2440 has slight differences. But on all three the reachable sources per dma channel has constraints attached and thus encodes the usable combinations using the S3C24XX_DMA_CHANREQ macro.

This also fixes the warning about s3c2410_dma_resource being unused as reported by Olof Johansson.

Perhpas you should have used Reported-by tag for that..

~Vinod

Quoted 157 lines
---
 arch/arm/mach-s3c24xx/common.c            |  100 +++++++++++++++++++++++++++++
 arch/arm/mach-s3c24xx/common.h            |    2 +
 include/linux/platform_data/dma-s3c24xx.h |    3 +
 3 files changed, 105 insertions(+)
arch/arm/mach-s3c24xx/common.c +100 -0
index 16ac669..4cfe7a4 100644
@@ -343,6 +343,50 @@ static struct resource s3c2410_dma_resource[] = {
 };
 #endif
 
+#if defined(CONFIG_CPU_S3C2410) || defined(CONFIG_CPU_S3C2442)
+static struct s3c24xx_dma_channel s3c2410_dma_channels[DMACH_MAX] = {
+	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 0), },
+	[DMACH_XD1] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 1), },
+	[DMACH_SDI] = { S3C24XX_DMA_APB, false, S3C24XX_DMA_CHANREQ(2, 0) |
+						S3C24XX_DMA_CHANREQ(2, 2) |
+						S3C24XX_DMA_CHANREQ(1, 3),
+	},
+	[DMACH_SPI0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 1), },
+	[DMACH_SPI1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 3), },
+	[DMACH_UART0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 0), },
+	[DMACH_UART1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 1), },
+	[DMACH_UART2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 3), },
+	[DMACH_TIMER] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 0) |
+						 S3C24XX_DMA_CHANREQ(3, 2) |
+						 S3C24XX_DMA_CHANREQ(3, 3),
+	},
+	[DMACH_I2S_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 1) |
+						  S3C24XX_DMA_CHANREQ(1, 2),
+	},
+	[DMACH_I2S_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 2), },
+	[DMACH_USB_EP1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 0), },
+	[DMACH_USB_EP2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 1), },
+	[DMACH_USB_EP3] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 2), },
+	[DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), },
+};
+
+static struct s3c24xx_dma_platdata s3c2410_dma_platdata = {
+	.num_phy_channels = 4,
+	.channels = s3c2410_dma_channels,
+	.num_channels = DMACH_MAX,
+};
+
+struct platform_device s3c2410_device_dma = {
+	.name		= "s3c2410-dma",
+	.id		= 0,
+	.num_resources	= ARRAY_SIZE(s3c2410_dma_resource),
+	.resource	= s3c2410_dma_resource,
+	.dev	= {
+		.platform_data	= &s3c2410_dma_platdata,
+	},
+};
+#endif
+
 #ifdef CONFIG_CPU_S3C2412
 static struct s3c24xx_dma_channel s3c2412_dma_channels[DMACH_MAX] = {
 	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, 17 },
@@ -384,6 +428,62 @@ struct platform_device s3c2412_device_dma = {
 };
 #endif
 
+#if defined(CONFIG_CPU_S3C2440)
+static struct s3c24xx_dma_channel s3c2440_dma_channels[DMACH_MAX] = {
+	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 0), },
+	[DMACH_XD1] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 1), },
+	[DMACH_SDI] = { S3C24XX_DMA_APB, false, S3C24XX_DMA_CHANREQ(2, 0) |
+						S3C24XX_DMA_CHANREQ(6, 1) |
+						S3C24XX_DMA_CHANREQ(2, 2) |
+						S3C24XX_DMA_CHANREQ(1, 3),
+	},
+	[DMACH_SPI0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 1), },
+	[DMACH_SPI1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 3), },
+	[DMACH_UART0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 0), },
+	[DMACH_UART1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 1), },
+	[DMACH_UART2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 3), },
+	[DMACH_TIMER] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 0) |
+						 S3C24XX_DMA_CHANREQ(3, 2) |
+						 S3C24XX_DMA_CHANREQ(3, 3),
+	},
+	[DMACH_I2S_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 1) |
+						  S3C24XX_DMA_CHANREQ(1, 2),
+	},
+	[DMACH_I2S_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(5, 0) |
+						   S3C24XX_DMA_CHANREQ(0, 2),
+	},
+	[DMACH_PCM_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(6, 0) |
+						  S3C24XX_DMA_CHANREQ(5, 2),
+	},
+	[DMACH_PCM_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(5, 1) |
+						  S3C24XX_DMA_CHANREQ(6, 3),
+	},
+	[DMACH_MIC_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(6, 2) |
+						  S3C24XX_DMA_CHANREQ(5, 3),
+	},
+	[DMACH_USB_EP1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 0), },
+	[DMACH_USB_EP2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 1), },
+	[DMACH_USB_EP3] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 2), },
+	[DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), },
+};
+
+static struct s3c24xx_dma_platdata s3c2440_dma_platdata = {
+	.num_phy_channels = 4,
+	.channels = s3c2440_dma_channels,
+	.num_channels = DMACH_MAX,
+};
+
+struct platform_device s3c2440_device_dma = {
+	.name		= "s3c2410-dma",
+	.id		= 0,
+	.num_resources	= ARRAY_SIZE(s3c2410_dma_resource),
+	.resource	= s3c2410_dma_resource,
+	.dev	= {
+		.platform_data	= &s3c2440_dma_platdata,
+	},
+};
+#endif
+
 #if defined(CONFIG_CPUS_3C2443) || defined(CONFIG_CPU_S3C2416)
 static struct resource s3c2443_dma_resource[] = {
 	[0] = DEFINE_RES_MEM(S3C24XX_PA_DMA, S3C24XX_SZ_DMA),
arch/arm/mach-s3c24xx/common.h +2 -0
index fe07189..e46c104 100644
@@ -109,7 +109,9 @@ extern void s3c2443_init_irq(void);
 
 extern struct syscore_ops s3c24xx_irq_syscore_ops;
 
+extern struct platform_device s3c2410_device_dma;
 extern struct platform_device s3c2412_device_dma;
+extern struct platform_device s3c2440_device_dma;
 extern struct platform_device s3c2443_device_dma;
 
 #endif /* __ARCH_ARM_MACH_S3C24XX_COMMON_H */
include/linux/platform_data/dma-s3c24xx.h +3 -0
index 5a0cfff..89ba1b0 100644
@@ -9,6 +9,9 @@
  * any later version.
  */
 
+/* Helper to encode the source selection constraints for early s3c socs. */
+#define S3C24XX_DMA_CHANREQ(src, chan)	((BIT(3) | src) << chan * 4)
+
 enum s3c24xx_dma_bus {
 	S3C24XX_DMA_APB,
 	S3C24XX_DMA_AHB,
Signature · 1 line
1.7.10.4
#6 lore raw

PATCH RESEND 3/3 ARM: S3C24XX: add dma pdata for s3c2410, s3c2440 and s3c2442

Am Sonntag, 13. Oktober 2013, 16:55:37 schrieb Vinod Koul:

Quoted 10 lines · Heiko St?bner
Quoted 7 lines

s3c2410 and s3c2442 share the same dma channels while s3c2440 has slight differences. But on all three the reachable sources per dma channel has constraints attached and thus encodes the usable combinations using the S3C24XX_DMA_CHANREQ macro.

This also fixes the warning about s3c2410_dma_resource being unused as reported by Olof Johansson.

Perhpas you should have used Reported-by tag for that..

yep, I should've, if I hadn't forgotten.

Maybe Kgene, who will most likely apply the patches, can add a

at the time.

Quoted 21 lines

~Vinod

Quoted 18 lines

---

 arch/arm/mach-s3c24xx/common.c            |  100
 +++++++++++++++++++++++++++++ arch/arm/mach-s3c24xx/common.h           
 |    2 +
 include/linux/platform_data/dma-s3c24xx.h |    3 +
 3 files changed, 105 insertions(+)
(quoted diff) +0 -0

b/arch/arm/mach-s3c24xx/common.c index 16ac669..4cfe7a4 100644

arch/arm/mach-s3c24xx/common.c +0 -0
@@ -343,6 +343,50 @@ static struct resource s3c2410_dma_resource[] = {
 
 };
 #endif
 
Quoted 11 lines

arch/arm/mach-s3c24xx/common.c static struct resource s3c2410_dma_resource[] = {

Quoted 11 lines
arch/arm/mach-s3c24xx/common.c +11 -0
+#if defined(CONFIG_CPU_S3C2410) || defined(CONFIG_CPU_S3C2442)
+static struct s3c24xx_dma_channel s3c2410_dma_channels[DMACH_MAX] = {
+	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 0), },
+	[DMACH_XD1] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 1), },
+	[DMACH_SDI] = { S3C24XX_DMA_APB, false, S3C24XX_DMA_CHANREQ(2, 0) |
+						S3C24XX_DMA_CHANREQ(2, 2) |
+						S3C24XX_DMA_CHANREQ(1, 3),
+	},
+	[DMACH_SPI0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 1), },
+	[DMACH_SPI1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 3), },
+	[DMACH_UART0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 0), 

},

Quoted 1 line

arch/arm/mach-s3c24xx/common.c static struct resource s3c2410_dma_resource[] = { · line 358

Quoted 1 line
arch/arm/mach-s3c24xx/common.c +1 -0
+	[DMACH_UART1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 1), 

},

Quoted 1 line

arch/arm/mach-s3c24xx/common.c static struct resource s3c2410_dma_resource[] = { · line 359

Quoted 1 line
arch/arm/mach-s3c24xx/common.c +1 -0
+	[DMACH_UART2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 3), 

},

Quoted 42 lines
Quoted 42 lines
arch/arm/mach-s3c24xx/common.c +8 -0
+	[DMACH_TIMER] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 0) |
+						 S3C24XX_DMA_CHANREQ(3, 2) |
+						 S3C24XX_DMA_CHANREQ(3, 3),
+	},
+	[DMACH_I2S_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 1) |
+						  S3C24XX_DMA_CHANREQ(1, 2),
+	},
+	[DMACH_I2S_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 2),
 }, +	[DMACH_USB_EP1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4,
 0), }, +	[DMACH_USB_EP2] = { S3C24XX_DMA_APB, true,

S3C24XX_DMA_CHANREQ(4, 1), }, + [DMACH_USB_EP3] = { S3C24XX_DMA_APB,
true, S3C24XX_DMA_CHANREQ(4, 2), }, + [DMACH_USB_EP4] = {
S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), }, +};

arch/arm/mach-s3c24xx/common.c +18 -0
+
+static struct s3c24xx_dma_platdata s3c2410_dma_platdata = {
+	.num_phy_channels = 4,
+	.channels = s3c2410_dma_channels,
+	.num_channels = DMACH_MAX,
+};
+
+struct platform_device s3c2410_device_dma = {
+	.name		= "s3c2410-dma",
+	.id		= 0,
+	.num_resources	= ARRAY_SIZE(s3c2410_dma_resource),
+	.resource	= s3c2410_dma_resource,
+	.dev	= {
+		.platform_data	= &s3c2410_dma_platdata,
+	},
+};
+#endif
+
 
 #ifdef CONFIG_CPU_S3C2412
 static struct s3c24xx_dma_channel s3c2412_dma_channels[DMACH_MAX] = {
 
 	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, 17 },
@@ -384,6 +428,62 @@ struct platform_device s3c2412_device_dma = {
 
 };
 #endif
 
Quoted 12 lines

arch/arm/mach-s3c24xx/common.c struct platform_device s3c2412_device_dma = {

Quoted 12 lines
arch/arm/mach-s3c24xx/common.c +12 -0
+#if defined(CONFIG_CPU_S3C2440)
+static struct s3c24xx_dma_channel s3c2440_dma_channels[DMACH_MAX] = {
+	[DMACH_XD0] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 0), },
+	[DMACH_XD1] = { S3C24XX_DMA_AHB, true, S3C24XX_DMA_CHANREQ(0, 1), },
+	[DMACH_SDI] = { S3C24XX_DMA_APB, false, S3C24XX_DMA_CHANREQ(2, 0) |
+						S3C24XX_DMA_CHANREQ(6, 1) |
+						S3C24XX_DMA_CHANREQ(2, 2) |
+						S3C24XX_DMA_CHANREQ(1, 3),
+	},
+	[DMACH_SPI0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 1), },
+	[DMACH_SPI1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 3), },
+	[DMACH_UART0] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 0), 

},

Quoted 1 line

arch/arm/mach-s3c24xx/common.c struct platform_device s3c2412_device_dma = { · line 444

Quoted 1 line
arch/arm/mach-s3c24xx/common.c +1 -0
+	[DMACH_UART1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(1, 1), 

},

Quoted 1 line

arch/arm/mach-s3c24xx/common.c struct platform_device s3c2412_device_dma = { · line 445

Quoted 1 line
arch/arm/mach-s3c24xx/common.c +1 -0
+	[DMACH_UART2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(0, 3), 

},

Quoted 8 lines

arch/arm/mach-s3c24xx/common.c static struct resource s3c2410_dma_resource[] = {

Quoted 8 lines
arch/arm/mach-s3c24xx/common.c +8 -0
+	[DMACH_TIMER] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(3, 0) |
+						 S3C24XX_DMA_CHANREQ(3, 2) |
+						 S3C24XX_DMA_CHANREQ(3, 3),
+	},
+	[DMACH_I2S_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(2, 1) |
+						  S3C24XX_DMA_CHANREQ(1, 2),
+	},
+	[DMACH_I2S_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(5, 0) 

|

Quoted 6 lines

arch/arm/mach-s3c24xx/common.c struct platform_device s3c2412_device_dma = {

Quoted 6 lines
arch/arm/mach-s3c24xx/common.c +6 -0
+						   S3C24XX_DMA_CHANREQ(0, 2),
+	},
+	[DMACH_PCM_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(6, 0) |
+						  S3C24XX_DMA_CHANREQ(5, 2),
+	},
+	[DMACH_PCM_OUT] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(5, 1) 

|

Quoted 70 lines
Quoted 70 lines
arch/arm/mach-s3c24xx/common.c +6 -0
+						  S3C24XX_DMA_CHANREQ(6, 3),
+	},
+	[DMACH_MIC_IN] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(6, 2) |
+						  S3C24XX_DMA_CHANREQ(5, 3),
+	},
+	[DMACH_USB_EP1] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 0),
 }, +	[DMACH_USB_EP2] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4,
 1), }, +	[DMACH_USB_EP3] = { S3C24XX_DMA_APB, true,

S3C24XX_DMA_CHANREQ(4, 2), }, + [DMACH_USB_EP4] = { S3C24XX_DMA_APB,
true, S3C24XX_DMA_CHANREQ(4, 3), }, +};

arch/arm/mach-s3c24xx/common.c +18 -0
+
+static struct s3c24xx_dma_platdata s3c2440_dma_platdata = {
+	.num_phy_channels = 4,
+	.channels = s3c2440_dma_channels,
+	.num_channels = DMACH_MAX,
+};
+
+struct platform_device s3c2440_device_dma = {
+	.name		= "s3c2410-dma",
+	.id		= 0,
+	.num_resources	= ARRAY_SIZE(s3c2410_dma_resource),
+	.resource	= s3c2410_dma_resource,
+	.dev	= {
+		.platform_data	= &s3c2440_dma_platdata,
+	},
+};
+#endif
+
 
 #if defined(CONFIG_CPUS_3C2443) || defined(CONFIG_CPU_S3C2416)
 static struct resource s3c2443_dma_resource[] = {
 
 	[0] = DEFINE_RES_MEM(S3C24XX_PA_DMA, S3C24XX_SZ_DMA),
(quoted diff) +0 -0

b/arch/arm/mach-s3c24xx/common.h index fe07189..e46c104 100644

arch/arm/mach-s3c24xx/common.h +2 -0
@@ -109,7 +109,9 @@ extern void s3c2443_init_irq(void);
 
 extern struct syscore_ops s3c24xx_irq_syscore_ops;
 
+extern struct platform_device s3c2410_device_dma;
 
 extern struct platform_device s3c2412_device_dma;
 
+extern struct platform_device s3c2440_device_dma;
 

extern struct platform_device s3c2443_device_dma;

#endif /* __ARCH_ARM_MACH_S3C24XX_COMMON_H */

(quoted diff) +0 -0

b/include/linux/platform_data/dma-s3c24xx.h index 5a0cfff..89ba1b0 100644

include/linux/platform_data/dma-s3c24xx.h +2 -0
@@ -9,6 +9,9 @@
 
  * any later version.
  */
 
+/* Helper to encode the source selection constraints for early s3c socs.
 */ +#define S3C24XX_DMA_CHANREQ(src, chan)	((BIT(3) | src) << chan * 4)
+
 
 enum s3c24xx_dma_bus {
 
 	S3C24XX_DMA_APB,
 	S3C24XX_DMA_AHB,
#7 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

In reply to Heiko Stübner

Hi Heiko,

[Resending, due to my e-mail client enabling HTML formatting. Sorry for the noise.]

Quoted 19 lines · On Friday 11 of October 2013 10:59:19 Heiko St?bner wrote:

[I messed up the linux-arm-kernel list address yesterday, so I resend it with a fixed address, sorry for the noise]

When Olof reported the warning about the unused s3c2410_dma_resource, I thought the best way forward would be to simply implement the missing pieces and so it has users :-) .

Therefore this series adds the necessary platform-devices for s3c2410, s3c2440 and s3c2442. This especially also includes the channel-constraints of those socs.

As I do not have access to any of those socs these changes are of course compile-tested only.

Heiko Stuebner (3):
ARM: S3C24XX: Fix possible dma selection warning
dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller
ARM: S3C24XX: add dma platformdata for s3c2410, s3c2440 and s3c2442

Quoted 7 lines
 arch/arm/mach-s3c24xx/Kconfig             |    3 +-
 arch/arm/mach-s3c24xx/common.c            |  100 +++++++++++++++++++++++++++++
 arch/arm/mach-s3c24xx/common.h            |    2 +
 drivers/dma/s3c24xx-dma.c                 |   10 +++
 include/linux/platform_data/dma-s3c24xx.h |    3 +
 sound/soc/samsung/Kconfig                 |    2 +-
 6 files changed, 118 insertions(+), 2 deletions(-)

Big thanks for this series and the one adding DMA engine support for S3C24xx. It would be great if someone could test this on affected platforms, so we could finally drop the old S3C-DMA nonsense.

Anyway, for the whole series

Best regards,
Tomasz

A message that is not in the archive (sent off-list or not yet received): 15184009.9QsSDOGPSA@amdn883

maintainer
#9 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

Quoted 3 lines · Tomasz Figa

Big thanks for this series and the one adding DMA engine support for S3C24xx. It would be great if someone could test this on affected platforms, so we could finally drop the old S3C-DMA nonsense.

Did the s3c64xx pl08x stuff get merged?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131012/aa9cd86c/attachment.sig>

#10 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

Quoted 6 lines · On Saturday 12 of October 2013 13:33:29 Mark Brown wrote:
Quoted 3 lines · Tomasz Figa

Big thanks for this series and the one adding DMA engine support for S3C24xx. It would be great if someone could test this on affected platforms, so we could finally drop the old S3C-DMA nonsense.

Did the s3c64xx pl08x stuff get merged?

Most of. All the patches for the amba-pl08x driver got merged. Just the platform glue remains. I will rebase and send respective patches this week.

Best regards,
Tomasz

maintainer
#11 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

Quoted 7 lines · Tomasz Figa
Quoted 1 line · On Saturday 12 of October 2013 13:33:29 Mark Brown wrote:

Did the s3c64xx pl08x stuff get merged?

Most of. All the patches for the amba-pl08x driver got merged. Just the platform glue remains. I will rebase and send respective patches this week.

Ah, excellent - I hadn't noticed that!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131014/b3281c32/attachment-0001.sig>

#12 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

In reply to Heiko Stübner
Quoted 7 lines · Heiko St?bner

[I messed up the linux-arm-kernel list address yesterday, so I resend it with a fixed address, sorry for the noise]

When Olof reported the warning about the unused s3c2410_dma_resource, I thought the best way forward would be to simply implement the missing pieces and so it has users :-) .

Quoted 6 lines

Therefore this series adds the necessary platform-devices for s3c2410, s3c2440 and s3c2442. This especially also includes the channel-constraints of those socs.

As I do not have access to any of those socs these changes are of course compile-tested only.

Do you want this to be applied thru dma or arm tree?

~Vinod

Quoted 17 lines

Heiko Stuebner (3):
ARM: S3C24XX: Fix possible dma selection warning
dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller
ARM: S3C24XX: add dma platformdata for s3c2410, s3c2440 and s3c2442

 arch/arm/mach-s3c24xx/Kconfig             |    3 +-
 arch/arm/mach-s3c24xx/common.c            |  100 +++++++++++++++++++++++++++++
 arch/arm/mach-s3c24xx/common.h            |    2 +
 drivers/dma/s3c24xx-dma.c                 |   10 +++
 include/linux/platform_data/dma-s3c24xx.h |    3 +
 sound/soc/samsung/Kconfig                 |    2 +-
 6 files changed, 118 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.10.4
#13 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

Am Sonntag, 13. Oktober 2013, 16:56:42 schrieb Vinod Koul:

Quoted 8 lines · Heiko St?bner
Quoted 7 lines

[I messed up the linux-arm-kernel list address yesterday, so I resend it with a fixed address, sorry for the noise]

When Olof reported the warning about the unused s3c2410_dma_resource, I thought the best way forward would be to simply implement the missing pieces and so it has users :-) .

Quoted 8 lines
Quoted 6 lines

Therefore this series adds the necessary platform-devices for s3c2410, s3c2440 and s3c2442. This especially also includes the channel-constraints of those socs.

As I do not have access to any of those socs these changes are of course compile-tested only.

Do you want this to be applied thru dma or arm tree?

hmm, the original series went into the samsung tree for 3.13, so maybe this addition should go the same way?

Heiko

Quoted 15 lines

~Vinod

Quoted 13 lines

Heiko Stuebner (3):
ARM: S3C24XX: Fix possible dma selection warning
dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller
ARM: S3C24XX: add dma platformdata for s3c2410, s3c2440 and s3c2442

 arch/arm/mach-s3c24xx/Kconfig             |    3 +-
 arch/arm/mach-s3c24xx/common.c            |  100
 +++++++++++++++++++++++++++++ arch/arm/mach-s3c24xx/common.h           
 |    2 +
 drivers/dma/s3c24xx-dma.c                 |   10 +++
 include/linux/platform_data/dma-s3c24xx.h |    3 +
 sound/soc/samsung/Kconfig                 |    2 +-
 6 files changed, 118 insertions(+), 2 deletions(-)
#14 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

Quoted 13 lines · Heiko St?bner

Am Sonntag, 13. Oktober 2013, 16:56:42 schrieb Vinod Koul:

Quoted 12 lines · Heiko St?bner
Quoted 11 lines

[I messed up the linux-arm-kernel list address yesterday, so I resend it with a fixed address, sorry for the noise]

When Olof reported the warning about the unused s3c2410_dma_resource, I thought the best way forward would be to simply implement the missing pieces and so it has users :-) .

Therefore this series adds the necessary platform-devices for s3c2410, s3c2440 and s3c2442. This especially also includes the channel-constraints of those socs.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

As I do not have access to any of those socs these changes are of course compile-tested only.

Do you want this to be applied thru dma or arm tree?

hmm, the original series went into the samsung tree for 3.13, so maybe this addition should go the same way?

I think so, let me pick this up into Samsung tree for v3.13.

Thanks,
Kukjin

Quoted 19 lines

Heiko

Quoted 15 lines

~Vinod

Quoted 13 lines

Heiko Stuebner (3):
ARM: S3C24XX: Fix possible dma selection warning
dmaengine: s3c24xx-dma: add support for the s3c2410 type of controller
ARM: S3C24XX: add dma platformdata for s3c2410, s3c2440 and s3c2442

  arch/arm/mach-s3c24xx/Kconfig             |    3 +-
  arch/arm/mach-s3c24xx/common.c            |  100
  +++++++++++++++++++++++++++++ arch/arm/mach-s3c24xx/common.h
  |    2 +
  drivers/dma/s3c24xx-dma.c                 |   10 +++
  include/linux/platform_data/dma-s3c24xx.h |    3 +
  sound/soc/samsung/Kconfig                 |    2 +-
  6 files changed, 118 insertions(+), 2 deletions(-)
#15 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

Quoted 17 lines · Kukjin Kim
Quoted 16 lines · Heiko St?bner

Am Sonntag, 13. Oktober 2013, 16:56:42 schrieb Vinod Koul:

Quoted 15 lines · Heiko St?bner
Quoted 13 lines

[I messed up the linux-arm-kernel list address yesterday, so I resend it with a fixed address, sorry for the noise]

When Olof reported the warning about the unused s3c2410_dma_resource, I thought the best way forward would be to simply implement the missing pieces and so it has users :-) .

Therefore this series adds the necessary platform-devices for s3c2410, s3c2440 and s3c2442. This especially also includes the channel-constraints of those socs.

As I do not have access to any of those socs these changes are of course compile-tested only.

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

Do you want this to be applied thru dma or arm tree?

hmm, the original series went into the samsung tree for 3.13, so maybe this addition should go the same way?

I think so, let me pick this up into Samsung tree for v3.13.

Okay, sounds good. Ack for dmaengine patch sent

~Vinod

#16 lore raw

cover ARM: S3C24XX: add missing dma-devices and warning fix

Quoted 18 lines · Vinod Koul
Quoted 17 lines · Kukjin Kim
Quoted 16 lines · Heiko St?bner

Am Sonntag, 13. Oktober 2013, 16:56:42 schrieb Vinod Koul:

Quoted 15 lines · Heiko St?bner
Quoted 13 lines

[I messed up the linux-arm-kernel list address yesterday, so I resend it with a fixed address, sorry for the noise]

When Olof reported the warning about the unused s3c2410_dma_resource, I thought the best way forward would be to simply implement the missing pieces and so it has users :-) .

Therefore this series adds the necessary platform-devices for s3c2410, s3c2440 and s3c2442. This especially also includes the channel-constraints of those socs.

As I do not have access to any of those socs these changes are of course compile-tested only.

Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line

Do you want this to be applied thru dma or arm tree?

hmm, the original series went into the samsung tree for 3.13, so maybe this addition should go the same way?

I think so, let me pick this up into Samsung tree for v3.13.

Okay, sounds good. Ack for dmaengine patch sent

Applied with Vinod's ack, thanks.

- Kukjin