kaweth: Fix memory leak in kaweth_control()
Subsystems (3)
PATCH RESEND 1/1 kaweth: Fix memory leak in kaweth_control()
kaweth_control() never frees the buffer that it allocates for the USB control message. Test case:
while :; do ifconfig eth2 down ; ifconfig eth2 up ; done
This is a tiny buffer so it is a slow leak. If you want to speed up the process, you can change the allocation size to e.g. 16384 bytes, and it will consume several megabytes within a few minutes.
Signed-off-by Kevin Cernekee <[email protected]>
Acked-by Oliver Neukum <[email protected]>
--- drivers/net/usb/kaweth.c | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-)
drivers/net/usb/kaweth.c +11 -7
@@ -263,6 +263,7 @@ static int kaweth_control(struct kaweth_device *kaweth, int timeout) {struct usb_ctrlrequest *dr; +int retval;dbg ("kaweth_control()" );
@@ -278,18 +279,21 @@ static int kaweth_control(struct kaweth_device *kaweth,return -ENOMEM ; } - dr->bRequestType= requesttype; + dr->bRequestType = requesttype; dr->bRequest = request; dr->wValue =cpu_to_le16 (value); dr->wIndex =cpu_to_le16 (index); dr->wLength =cpu_to_le16 (size); -return kaweth_internal_control_msg (kaweth->dev, - pipe, - dr, - data, - size, - timeout); + retval =kaweth_internal_control_msg (kaweth->dev, + pipe, + dr, + data, + size, + timeout); + +kfree (dr); +return retval; }/****************************************************************
Signature · 6 lines
1.6.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html