cifs: remove dead code
Subsystems (2)
PATCH 1/1 cifs: remove dead code
cifs provides two dummy functions 'sess_auth_lanman' and 'sess_auth_kerberos' for the case in which the respective features are not defined. However, the caller is also under an #ifdef, so we just get warnings about unused code:
fs/cifs/sess.c:1109:1: warning: 'sess_auth_kerberos' defined but not used [-Wunused-function]
sess_auth_kerberos(struct sess_data *sess_data)
Removing the dead functions gets rid of the warnings without any downsides that I can see.
fs/cifs/sess.c +0 -17
@@ -745,14 +745,6 @@ out:sess_free_buffer (sess_data); } -#else - -static void -sess_auth_lanman (struct sess_data *sess_data) -{ - sess_data->result = -EOPNOTSUPP ; - sess_data->func =NULL ; -}#endif static void
@@ -1103,15 +1095,6 @@ out: ses->auth_key.response = NULL; } -#else - -static void -sess_auth_kerberos (struct sess_data *sess_data) -{ -cifs_dbg (VFS ,"Kerberos negotiated but upcall support disabled!\n" ); - sess_data->result = -ENOSYS ; - sess_data->func =NULL ; -}#endif /* ! CONFIG_CIFS_UPCALL */ /*
Steve French
AppliedMerged into cifs-2.6.git for-next
Added Yalin Wang <[email protected]> who reported the same problem/fix
Quoted 49 lines · Arnd Bergmann
cifs provides two dummy functions '
sess_auth_lanman' and 'sess_auth_kerberos' for the case in which the respective features are not defined. However, the caller is also under an #ifdef, so we just get warnings about unused code:
fs/cifs/sess.c:1109:1: warning: 'sess_auth_kerberos' defined but not used [-Wunused-function]
sess_auth_kerberos(struct sess_data *sess_data)Removing the dead functions gets rid of the warnings without any downsides that I can see.
Signed-off-by Arnd Bergmann <[email protected]>fs/cifs/sess.c +0
-17@@ -745,14 +745,6 @@ out:sess_free_buffer (sess_data); } -#else - -static void -sess_auth_lanman (struct sess_data *sess_data) -{ - sess_data->result = -EOPNOTSUPP ; - sess_data->func =NULL ; -}#endif static void@@ -1103,15 +1095,6 @@ out: ses->auth_key.response = NULL; } -#else - -static void -sess_auth_kerberos (struct sess_data *sess_data) -{ -cifs_dbg (VFS ,"Kerberos negotiated but upcall support disabled!\n" ); - sess_data->result = -ENOSYS ; - sess_data->func =NULL ; -}#endif /* ! CONFIG_CIFS_UPCALL */ /*
Signature · 3 lines
Thanks, Steve