idpf: Add missing dependencies
Subsystems (2)
PATCH 1/1 idpf: Add missing dependencies
The idpf driver depends on both AUXILIARY_BUS and NET_DEVLINK, but they're not selected by the Kconfig. Let's fix this so idpf builds even with a stripped config.
--- drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/intel/idpf/Kconfig +2 -0
@@ -8,6 +8,8 @@ config IDPF select LIBETH select LIBETH_CP select LIBETH_IRQ + select AUXILIARY_BUS + select NET_DEVLINK help This driver supports Intel(R) Infrastructure Data Path Function devices.
Signature · 1 line
2.34.1
Przemek Kitszel
maintainerQuoted 6 lines · Malin Jonsson
The idpf driver depends on both
AUXILIARY_BUSandNET_DEVLINK, but they're not selected by theKconfig. Let's fix this so idpf builds even with a stripped config.Reported-by Yong Gu <[email protected]>Signed-off-by Malin Jonsson <[email protected]>
Thank you for the fix!
if you have a Link to the public report, please add it as a Closes: tag
Would be also great to add a Fixes: tag with the commit that introduces the need for given dependency/ies
(there should be one tag only (per your commit), if both deps were introduced by the very same pull request, just use the earlier commit)
Quoted 9 lines
--- drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ 1 file changed, 2 insertions(+)drivers/net/ethernet/intel/idpf/Kconfig +0
-0
drivers/net/ethernet/intel/idpf/Kconfig config IDPF · line 12
Quoted 5 lines
drivers/net/ethernet/intel/idpf/Kconfig +2
-0@@ -8,6 +8,8 @@ config IDPF select LIBETH select LIBETH_CP select LIBETH_IRQ + select AUXILIARY_BUS + select NET_DEVLINK
looks good, but please notice that we keep this list sorted
Quoted 3 lines
drivers/net/ethernet/intel/idpf/Kconfig +0
-0help This driver supports Intel(R) Infrastructure Data Path Function devices.
Quoted 9 lines · Przemek Kitszel
Quoted 6 lines · Malin Jonsson
The idpf driver depends on both
AUXILIARY_BUSandNET_DEVLINK, but they're not selected by theKconfig. Let's fix this so idpf builds even with a stripped config.Reported-by Yong Gu <[email protected]>Signed-off-by Malin Jonsson <[email protected]>Thank you for the fix!
My pleasure!
Quoted 1 line
if you have a Link to the public report, please add it as a Closes: tag
There is no public report that I'm aware of.
Quoted 3 lines
Would be also great to add a Fixes: tag with the commit that introduces the need for given dependency/ies
I can do that.
Quoted 7 lines
(there should be one tag only (per your commit), if both deps were introduced by the very same pull request, just use the earlier commit)
Quoted 4 lines
--- drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
Quoted 12 lines
drivers/net/ethernet/intel/idpf/Kconfig config IDPF · line 12
Quoted 10 lines
drivers/net/ethernet/intel/idpf/Kconfig +2
-0@@ -8,6 +8,8 @@ config IDPF select LIBETH select LIBETH_CP select LIBETH_IRQ + select AUXILIARY_BUS + select NET_DEVLINKlooks good, but please notice that we keep this list sorted
Thanks! I will fix this and resubmit.
Quoted 7 lines
Quoted 4 lines
drivers/net/ethernet/intel/idpf/Kconfig +0
-0help This driver supports Intel(R) Infrastructure Data Path Function devices.
Quoted 44 lines · Malin Jonsson
Quoted 9 lines · Przemek Kitszel
Quoted 6 lines · Malin Jonsson
The idpf driver depends on both
AUXILIARY_BUSandNET_DEVLINK, but they're not selected by theKconfig. Let's fix this so idpf builds even with a stripped config.Reported-by Yong Gu <[email protected]>Signed-off-by Malin Jonsson <[email protected]>Thank you for the fix!
My pleasure!
Quoted 1 line
if you have a Link to the public report, please add it as a Closes: tag
There is no public report that I'm aware of.
Quoted 3 lines
Would be also great to add a Fixes: tag with the commit that introduces the need for given dependency/ies
I can do that.
Quoted 7 lines
(there should be one tag only (per your commit), if both deps were introduced by the very same pull request, just use the earlier commit)
Quoted 4 lines
--- drivers/net/ethernet/intel/idpf/Kconfig | 2 ++ 1 file changed, 2 insertions(+)Quoted 12 lines
drivers/net/ethernet/intel/idpf/Kconfig config IDPF · line 12
Quoted 10 lines
drivers/net/ethernet/intel/idpf/Kconfig +2
-0@@ -8,6 +8,8 @@ config IDPF select LIBETH select LIBETH_CP select LIBETH_IRQ + select AUXILIARY_BUS + select NET_DEVLINKlooks good, but please notice that we keep this list sorted
Quoted 8 lines
Thanks! I will fix this and resubmit.
Quoted 7 lines
Quoted 4 lines
drivers/net/ethernet/intel/idpf/Kconfig +0
-0help This driver supports Intel(R) Infrastructure Data Path Function devices.
Apologies Przemek,
I did not do my due diligence before I submitted this fix: I maintain a custom kernel for an Intel chip that's still under development (PMR), and we receive patches before submission to go with early releases of the PMR simulator.
The patches that introduce the dependencies are not on the list yet.
Thank you for your prompt and kind response, and your time!
Cheers //malin
~
From: Przemek Kitszel <[email protected]>
Date: Fri, 11 Jul 2025 12:25:09 +0200
Quoted 20 lines · Malin Jonsson
Quoted 6 lines
The idpf driver depends on both
AUXILIARY_BUSandNET_DEVLINK, but they're not selected by theKconfig. Let's fix this so idpf builds even with a stripped config.Reported-by Yong Gu <[email protected]>Signed-off-by Malin Jonsson <[email protected]>Thank you for the fix!
if you have a Link to the public report, please add it as a Closes: tagWould be also great to add a Fixes: tag with the commit that introduces the need for given dependency/ies
(there should be one tag only (per your commit), if both deps were introduced by the very same pull request, just use the earlier commit)Quoted 4 lines
---
drivers/net/ethernet/intel/idpf/Kconfig| 2 ++1 file changed, 2 insertions(+)
Quoted 11 lines
Quoted 11 lines
drivers/net/ renamed from drivers/net/ethernet/intel/idpf/Kconfig +0
-0ethernet/intel/idpf/Kconfig
index1f893221e2c99..5c7ce626aae16100644drivers/net/ethernet/intel/idpf/Kconfig +0
-0@@ -8,6 +8,8 @@ config IDPFselect LIBETH
selectLIBETH_CP
selectLIBETH_IRQ
+ selectAUXILIARY_BUS
+ selectNET_DEVLINK
Uhm, idpf currently uses neither of those...
Could you give a real output with the linker being unable to resolve auxbus and/or devlink symbols for idpf.ko?
Quoted 6 lines
looks good, but please notice that we keep this list sorted
Quoted 3 lines
help
This driver supports Intel(R) Infrastructure Data Path Function devices.
Thanks,
Olek
Quoted 23 lines · Alexander Lobakin
From: Przemek Kitszel <[email protected]>
Date: Fri, 11 Jul 2025 12:25:09 +0200Quoted 20 lines · Malin Jonsson
Quoted 6 lines
The idpf driver depends on both
AUXILIARY_BUSandNET_DEVLINK, but they're not selected by theKconfig. Let's fix this so idpf builds even with a stripped config.Reported-by Yong Gu <[email protected]>Signed-off-by Malin Jonsson <[email protected]>Thank you for the fix!
if you have a Link to the public report, please add it as a Closes: tagWould be also great to add a Fixes: tag with the commit that introduces the need for given dependency/ies
(there should be one tag only (per your commit), if both deps were introduced by the very same pull request, just use the earlier commit)Quoted 4 lines
---
drivers/net/ethernet/intel/idpf/Kconfig| 2 ++1 file changed, 2 insertions(+)
Quoted 13 lines
Quoted 11 lines
Quoted 11 lines
drivers/net/ renamed from drivers/net/ethernet/intel/idpf/Kconfig +0
-0ethernet/intel/idpf/Kconfig
index1f893221e2c99..5c7ce626aae16100644drivers/net/ethernet/intel/idpf/Kconfig +0
-0@@ -8,6 +8,8 @@ config IDPFselect LIBETH
selectLIBETH_CP
selectLIBETH_IRQ
+ selectAUXILIARY_BUS
+ selectNET_DEVLINKUhm, idpf currently uses neither of those...
Correct, I didn't do my due diligence before I submitted the fix:
I maintain a custom kernel for an Intel chip that's still under development (PMR), and we receive patches before submission to go with early releases of the PMR simulator.
The patches that introduce the dependencies are not on the list yet - I only realised this when I started searching the list for the commits in question.
Quoted 3 lines
Could you give a real output with the linker being unable to resolve auxbus and/or devlink symbols for idpf.ko?
This information doesn't apply to the upstream driver of course, but for completeness' sake:
ERROR: modpost: "devlink_info_version_running_put" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "auxiliary_driver_unregister" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "priv_to_devlink" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "devl_nested_devlink_set" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "__auxiliary_device_add" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "devl_port_register_with_ops" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "devlink_info_serial_number_put" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "devl_unlock" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "devl_port_unregister" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
ERROR: modpost: "devlink_priv" [drivers/net/ethernet/intel/idpf/idpf.ko] undefined!
WARNING: modpost: suppressed 10 unresolved symbol warnings because there were too many) make[2]: *** [scripts/Makefile.modpost:147: Module.symvers] Error 1
make[1]: *** [/repo/malin/elin/linux/Makefile:1956: modpost] Error 2
Quoted 10 lines
Quoted 7 lines
looks good, but please notice that we keep this list sorted
Quoted 3 lines
help
This driver supports Intel(R) Infrastructure Data Path Function devices.Thanks,
Olek
Cheers //malin