arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
PATCH 1/1 arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI).
---
Eugen, I would advise you to double-check, if your AT91 based boards using NAND also have this BBT option enabled in Linux. If yes, its definitely necessary to enable it in U-Boot as well to match the same layout.
configs/gardena-smart-gateway-at91sam_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
configs/gardena-smart-gateway-at91sam_defconfig +1 -2
@@ -17,6 +17,7 @@ CONFIG_DEBUG_UART_BASE=0xfffff200 CONFIG_DEBUG_UART_CLOCK=132000000 CONFIG_SMBIOS_PRODUCT_NAME="at91sam9x5ek" CONFIG_DEBUG_UART=y +CONFIG_SPL_TEXT_BASE=0x300000 CONFIG_FIT=y CONFIG_NAND_BOOT=y CONFIG_BOOTDELAY=3
@@ -24,7 +25,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk mtdparts=atmel_nand:256k(bootstrap)ro,768k(uboot)ro,256k(env_redundant),256k(env),512k(dtb),6M(kernel)ro,-(rootfs) rootfstype=ubifs ubi.mtd=6 root=ubi0:rootfs rw" CONFIG_SYS_CONSOLE_IS_IN_ENV=y CONFIG_SYS_CONSOLE_INFO_QUIET=y -CONFIG_SPL_TEXT_BASE=0x300000 CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_SEPARATE_BSS=y # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set
@@ -66,7 +66,6 @@ CONFIG_AT91_GPIO=y CONFIG_LED=y CONFIG_LED_GPIO=y # CONFIG_MMC is not set -# CONFIG_SYS_NAND_USE_FLASH_BBT is not set CONFIG_NAND_ATMEL=y CONFIG_SPL_GENERATE_ATMEL_PMECC_HEADER=y CONFIG_DM_ETH=y
Signature · 1 line
2.23.0
PATCH 1/1 arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
Quoted 6 lines · Stefan Roese
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI).
Quoted 8 lines
Signed-off-by Stefan Roese <[email protected]>Cc Eugen Hristev <[email protected]>Cc Tom Rini <[email protected]>---
Eugen, I would advise you to double-check, if your AT91 based boards using NAND also have this BBT option enabled in Linux. If yes, its definitely necessary to enable it in U-Boot as well to match the same layout.
Hi Stefan,
Thank you for the patch.
I will look into it with help of Tudor and provide some feedback.
Eugen
Quoted 33 lines
configs/gardena-smart-gateway-at91sam_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)configs/gardena-smart-gateway-at91sam_defconfig +1
-2@@ -17,6 +17,7 @@ CONFIG_DEBUG_UART_BASE=0xfffff200 CONFIG_DEBUG_UART_CLOCK=132000000 CONFIG_SMBIOS_PRODUCT_NAME="at91sam9x5ek" CONFIG_DEBUG_UART=y +CONFIG_SPL_TEXT_BASE=0x300000 CONFIG_FIT=y CONFIG_NAND_BOOT=y CONFIG_BOOTDELAY=3@@ -24,7 +25,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk mtdparts=atmel_nand:256k(bootstrap)ro,768k(uboot)ro,256k(env_redundant),256k(env),512k(dtb),6M(kernel)ro,-(rootfs) rootfstype=ubifs ubi.mtd=6 root=ubi0:rootfs rw" CONFIG_SYS_CONSOLE_IS_IN_ENV=y CONFIG_SYS_CONSOLE_INFO_QUIET=y -CONFIG_SPL_TEXT_BASE=0x300000 CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_SEPARATE_BSS=y # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set@@ -66,7 +66,6 @@ CONFIG_AT91_GPIO=y CONFIG_LED=y CONFIG_LED_GPIO=y # CONFIG_MMC is not set -# CONFIG_SYS_NAND_USE_FLASH_BBT is not set CONFIG_NAND_ATMEL=y CONFIG_SPL_GENERATE_ATMEL_PMECC_HEADER=y CONFIG_DM_ETH=y
PATCH 1/1 arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
Hi Eugen,
Quoted 19 lines · Eugen.Hristev at microchip.com
Quoted 6 lines · Stefan Roese
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI).
Quoted 8 lines
Signed-off-by Stefan Roese <[email protected]>Cc Eugen Hristev <[email protected]>Cc Tom Rini <[email protected]>---
Eugen, I would advise you to double-check, if your AT91 based boards using NAND also have this BBT option enabled in Linux. If yes, its definitely necessary to enable it in U-Boot as well to match the same layout.
Quoted 4 lines
Hi Stefan,
Thank you for the patch.
I will look into it with help of Tudor and provide some feedback.
Do you have any updates on this?
Would it be possible to apply this patch for the upcoming release?
Thanks,
Stefan
Quoted 31 lines
Eugen
Quoted 29 lines
configs/gardena-smart-gateway-at91sam_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)configs/gardena-smart-gateway-at91sam_defconfig +1
-2@@ -17,6 +17,7 @@ CONFIG_DEBUG_UART_BASE=0xfffff200 CONFIG_DEBUG_UART_CLOCK=132000000 CONFIG_SMBIOS_PRODUCT_NAME="at91sam9x5ek" CONFIG_DEBUG_UART=y +CONFIG_SPL_TEXT_BASE=0x300000 CONFIG_FIT=y CONFIG_NAND_BOOT=y CONFIG_BOOTDELAY=3@@ -24,7 +25,6 @@ CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk mtdparts=atmel_nand:256k(bootstrap)ro,768k(uboot)ro,256k(env_redundant),256k(env),512k(dtb),6M(kernel)ro,-(rootfs) rootfstype=ubifs ubi.mtd=6 root=ubi0:rootfs rw" CONFIG_SYS_CONSOLE_IS_IN_ENV=y CONFIG_SYS_CONSOLE_INFO_QUIET=y -CONFIG_SPL_TEXT_BASE=0x300000 CONFIG_SPL_SYS_MALLOC_SIMPLE=y CONFIG_SPL_SEPARATE_BSS=y # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set@@ -66,7 +66,6 @@ CONFIG_AT91_GPIO=y CONFIG_LED=y CONFIG_LED_GPIO=y # CONFIG_MMC is not set -# CONFIG_SYS_NAND_USE_FLASH_BBT is not set
Quoted 9 lines
configs/gardena-smart-gateway-at91sam_defconfig CONFIG_AT91_GPIO=y · line 71
Quoted 4 lines
configs/gardena-smart-gateway-at91sam_defconfig +0
-0CONFIG_NAND_ATMEL=y CONFIG_SPL_GENERATE_ATMEL_PMECC_HEADER=y CONFIG_DM_ETH=y_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot
Viele Grüße,
Stefan
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
PATCH 1/1 arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
Quoted 28 lines · Stefan Roese
Hi Eugen,
Quoted 19 lines · Eugen.Hristev at microchip.com
Quoted 6 lines · Stefan Roese
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI).
Quoted 8 lines
Signed-off-by Stefan Roese <[email protected]>Cc Eugen Hristev <[email protected]>Cc Tom Rini <[email protected]>---
Eugen, I would advise you to double-check, if your AT91 based boards using NAND also have this BBT option enabled in Linux. If yes, its definitely necessary to enable it in U-Boot as well to match the same layout.Quoted 4 lines
Hi Stefan,
Thank you for the patch.
I will look into it with help of Tudor and provide some feedback.
Quoted 7 lines
Do you have any updates on this?
Would it be possible to apply this patch for the upcoming release?
Thanks,
Stefan
Applied to u-boot-atmel/master
Will queue it before release in a PR. Have to check if more at91 boards need the same kind of patch.
Eugen
PATCH 1/1 arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
Hi Eugen,
Quoted 21 lines · Eugen.Hristev at microchip.com
Quoted 21 lines
Quoted 14 lines
Quoted 5 lines
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI).
Quoted 8 lines
Signed-off-by Stefan Roese <[email protected]>Cc Eugen Hristev <[email protected]>Cc Tom Rini <[email protected]>---
Eugen, I would advise you to double-check, if your AT91 based boards using NAND also have this BBT option enabled in Linux. If yes, its definitely necessary to enable it in U-Boot as well to match the same layout.Quoted 4 lines
Hi Stefan,
Thank you for the patch.
I will look into it with help of Tudor and provide some feedback.Do you have any updates on this?
Quoted 7 lines
Quoted 5 lines
Would it be possible to apply this patch for the upcoming release?
Thanks,
StefanApplied to u-boot-atmel/master
Thanks.
Quoted 2 lines
Will queue it before release in a PR. Have to check if more at91 boards need the same kind of patch.
As mentioned before, I'm pretty sure that most (all) at91 boards with NAND need this patch.
Thanks,
Stefan
PATCH 1/1 arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
In reply to Stefan RoeseHei hei,
Am Dienstag, 27. August 2019, 08:14:50 CEST schrieb Stefan Roese:
Quoted 4 lines
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI).
Does the Linux kernel driver use those unconditionally or is that a kernel config option? Which one? (Search in 5.2 kernel config for BBT is inconclusive.)
Greets
Alex
PATCH 1/1 arm: at91: gardena-smart-gateway-at91sam: Enable CONFIG_SYS_NAND_USE_FLASH_BBT
Hi Alex,
Quoted 9 lines · Alexander Dahl
Am Dienstag, 27. August 2019, 08:14:50 CEST schrieb Stefan Roese:
Quoted 4 lines
This patch enables the BBT in NAND on the AT91SAM based GARDENA smart Gateway. This is especially important, since the Linux driver also enables this option and uses the BBT table pages. Without setting this option, U-Boot will try to re-use these pages again (e.g. UBI).
Does the Linux kernel driver use those unconditionally or is that a kernel config option? Which one? (Search in 5.2 kernel config for BBT is inconclusive.)
Linux uses the DT property "nand-on-flash-bbt" for this decision. But please be aware - this is only for raw NAND and not SPI NAND (IIRC).
And yes, we should definitely move to this DT property instead of the Kconfig symbol in U-Boot as well. To automatically match the configuration of such boards in U-Boot and Linux. But such a change it too intrusive at this time of release cycle.
Thanks,
Stefan