drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()
Subsystems (5)
PATCH 1/1 drm/nouveau/tegra: Fix error pointer vs NULL return in nvkm_device_tegra_resource_addr()
The nvkm_device_tegra_resource() function returns a mix of error pointers and NULL. The callers only expect it to return NULL on error. Change it to only return NULL.
Fixes 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c +1 -1
@@ -196,7 +196,7 @@ nvkm_device_tegra_resource(struct nvkm_device *device, enum nvkm_bar_id bar)case NVKM_BAR1_FB : idx =1 ;break ;default :WARN_ON (1 ); -return ERR_PTR (-EINVAL ); +return NULL ; }return platform_get_resource (tdev->pdev,IORESOURCE_MEM , idx);
Signature · 1 line
2.47.2
Quoted 6 lines · Dan Carpenter
The
nvkm_device_tegra_resource()function returns a mix of error pointers and NULL. The callers only expect it to return NULL on error. Change it to only return NULL.Fixes 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Timur Tabi <[email protected]>