Skip to contentSkip to conversation

package/{python-}protobuf: bump to version 35.1

PATCH Applied Michael Nosthoff via buildroot 1 participant 3 messages Jun 15

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/{python-}protobuf: bump to version 35.1

Release Notes:
https://github.com/protocolbuffers/protobuf/releases/tag/v35.0
https://github.com/protocolbuffers/protobuf/releases/tag/v35.1

--

This release contains a workaround for the issue in libabseil with gcc <= 12 [0]. Buildroot introduced a patch in 955fb2f7c41f49e8d7fc8c60b8557f6f7c1d84c4 fixing this in libabseil-cpp.
So for protobuf this patch is not needed anymore. But it might make sense to keep it for other consumers of libabseil-cpp.

[0] https://github.com/protocolbuffers/protobuf/commit/78dc67e4d598d4e2ec8929105eb2ddbb4bf50935

---
 package/protobuf/protobuf.hash               | 2 +-
 package/protobuf/protobuf.mk                 | 2 +-
 package/python-protobuf/python-protobuf.hash | 4 ++--
 package/python-protobuf/python-protobuf.mk   | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
package/protobuf/protobuf.hash +1 -1
index be6484fb92..aaf5d77095 100644
@@ -1,3 +1,3 @@
 # Locally calculated
 sha256  6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d  LICENSE
-sha256  e4e6ff10760cf747a2decd1867741f561b216bd60cc4038c87564713a6da1848  protobuf-34.1.tar.gz
+sha256  f0b6838e7522a8da96126d487068c959bc624926368f3024ac8fd03abd0a1ac4  protobuf-35.1.tar.gz
package/protobuf/protobuf.mk +1 -1
index 4f5911e794..d4d0e3e0d0 100644
@@ -7,7 +7,7 @@
 # When bumping this package, make sure to also verify if the
 # python-protobuf package still works and to update its hash,
 # as they share the same version/site variables.
-PROTOBUF_VERSION = 34.1
+PROTOBUF_VERSION = 35.1
 PROTOBUF_SITE = https://github.com/protocolbuffers/protobuf/releases/download/v$(PROTOBUF_VERSION)
 PROTOBUF_LICENSE = BSD-3-Clause
 PROTOBUF_LICENSE_FILES = LICENSE
package/python-protobuf/python-protobuf.hash +2 -2
index 346a2f3c54..714e2cf49b 100644
@@ -1,5 +1,5 @@
 # md5, sha256 from https://pypi.org/pypi/protobuf/json
-md5  7d860558dfbd2762140370c391285c35  protobuf-7.34.1.tar.gz
-sha256  9ce42245e704cc5027be797c1db1eb93184d44d1cdd71811fb2d9b25ad541280  protobuf-7.34.1.tar.gz
+md5  e9074f4f40672c900f878be049f86cb8  protobuf-7.35.1.tar.gz
+sha256  ce115a26fe0c39a2c29973d914d327e516a6455464489fe3cd1e51a1b354f81a  protobuf-7.35.1.tar.gz
 # Locally computed sha256 checksums
 sha256  6e5e117324afd944dcf67f36cf329843bc1a92229a8cd9bb573d7a83130fea7d  LICENSE
package/python-protobuf/python-protobuf.mk +1 -1
index 3ba1b96514..17369d1462 100644
@@ -6,7 +6,7 @@
 
 PYTHON_PROTOBUF_VERSION = $(PROTOBUF_VERSION)
 PYTHON_PROTOBUF_SOURCE = protobuf-7.$(PYTHON_PROTOBUF_VERSION).tar.gz
-PYTHON_PROTOBUF_SITE = https://files.pythonhosted.org/packages/6b/6b/a0e95cad1ad7cc3f2c6821fcab91671bd5b78bd42afb357bb4765f29bc41
+PYTHON_PROTOBUF_SITE = https://files.pythonhosted.org/packages/da/01/9ef0afd7999eb9badb3a768b4aedd78c86d4c65cfaf1958ab276199e76b4
 
 PYTHON_PROTOBUF_LICENSE = BSD-3-Clause
 PYTHON_PROTOBUF_LICENSE_FILES = LICENSE
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Michael,

Quoted 14 lines · Michael Nosthoff via buildroot

Release Notes:
https://github.com/protocolbuffers/protobuf/releases/tag/v35.0
https://github.com/protocolbuffers/protobuf/releases/tag/v35.1

--

This release contains a workaround for the issue in libabseil with gcc <= 12 [0]. Buildroot introduced a patch in 955fb2f7c41f49e8d7fc8c60b8557f6f7c1d84c4 fixing this in libabseil-cpp.
So for protobuf this patch is not needed anymore. But it might make sense to keep it for other consumers of libabseil-cpp.

Quoted 4 lines

[0] https://github.com/protocolbuffers/protobuf/commit/78dc67e4d598d4e2ec8929105eb2ddbb4bf50935

---

Applied to master, thanks!

I noticed that we don't have any tests for protobuf/python-protobuf in buildroot. Do you think you could maybe contribute one? [1]

[1] https://nightly.buildroot.org/manual.html#_using_the_runtime_tests_framework

Best,
Marcus
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Michael Nosthoff via buildroot

Hi Michael,

Quoted 6 lines · Michael Nosthoff via buildroot

Release Notes:
https://github.com/protocolbuffers/protobuf/releases/tag/v35.0
https://github.com/protocolbuffers/protobuf/releases/tag/v35.1

Quoted 7 lines

--

This release contains a workaround for the issue in libabseil with gcc <= 12 [0]. Buildroot introduced a patch in 955fb2f7c41f49e8d7fc8c60b8557f6f7c1d84c4 fixing this in libabseil-cpp.
So for protobuf this patch is not needed anymore. But it might make sense to keep it for other consumers of libabseil-cpp.

The libabseil patch I proposed is not a complete fix. See:
https://github.com/abseil/abseil-cpp/pull/2044#issuecomment-4407040866

So we could probably remove it from Buildroot, now protobuf is fixed.

Quoted 3 lines

[0] https://github.com/protocolbuffers/protobuf/commit/78dc67e4d598d4e2ec8929105eb2ddbb4bf50935

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot