dma/idxd: fix missing default for workqueue options
Subsystems (2)
PATCH 1/1 dma/idxd: fix missing default for workqueue options
When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default value used by argparse is None. This leads to later errors which are expecting an array value:
TypeError: 'NoneType' object is not iterable
This is fixed by specifying that the empty array should be the default if no flags are passed.
--- drivers/dma/idxd/dpdk_idxd_cfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/idxd/dpdk_idxd_cfg.py +1 -1
@@ -122,7 +122,7 @@ def main(args): arg_p.add_argument('--name-prefix', metavar='prefix', dest='prefix', default="dpdk", help="Prefix for workqueue name to mark for DPDK use [default: 'dpdk']") - arg_p.add_argument('--wq-option', action='append', + arg_p.add_argument('--wq-option', action='append', default=[], help="Provide additional config option for queues (format 'x=y')") arg_p.add_argument('--reset', action='store_true', help="Reset DSA device and its queues")
Signature · 1 line
2.34.1
Quoted 13 lines
From: Richardson, Bruce <[email protected]>
Sent: Friday, June 17, 2022 4:48 PM
To: [email protected]
Cc: Laatz, Kevin <[email protected]>; Pai G, Sunil <[email protected]>; Richardson, Bruce <[email protected]>
Subject: [PATCH] dma/idxd: fix missing default for workqueue optionsWhen no --wq-option flag is passed to
dpdk_idxd_cfg.pyscript, the default value used by argparse is None. This leads to later errors which are expecting an array value:TypeError: 'NoneType' object is not iterable
Quoted 7 lines
This is fixed by specifying that the empty array should be the default if no flags are passed.
Fixes 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")Signed-off-by Bruce Richardson <[email protected]>---
LGTM
Thomas Monjalon
Applied20/06/2022 06:09, Pai G, Sunil:
Quoted 16 lines
Quoted 16 lines
From: Richardson, Bruce <[email protected]>
Sent: Friday, June 17, 2022 4:48 PM
To: [email protected]
Cc: Laatz, Kevin <[email protected]>; Pai G, Sunil <[email protected]>; Richardson, Bruce <[email protected]>
Subject: [PATCH] dma/idxd: fix missing default for workqueue optionsWhen no --wq-option flag is passed to
dpdk_idxd_cfg.pyscript, the default value used by argparse is None. This leads to later errors which are expecting an array value:TypeError: 'NoneType' object is not iterable
This is fixed by specifying that the empty array should be the default if no flags are passed.
Quoted 7 lines
Quoted 4 lines
Fixes 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")Signed-off-by Bruce Richardson <[email protected]>---
LGTM
Acked-by Sunil Pai G <[email protected]>
Applied, thanks.
Quoted 6 lines
When no --wq-option flag is passed to
dpdk_idxd_cfg.pyscript, the default value used by argparse is None. This leads to later errors which are expecting an array value:TypeError: 'NoneType' object is not iterable
Quoted 7 lines
This is fixed by specifying that the empty array should be the default if no flags are passed.
Fixes 94b0f04dc0e3 ("dma/idxd: add generic option for queue config")Signed-off-by Bruce Richardson <[email protected]>---