ahci: Remove the exporting of ahci_em_messages
PATCH 1/1 ahci: Remove the exporting of ahci_em_messages
The variable ahci_em_messages is declared static and marked EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the variable is not used outside of the drivers/ata/libahci.c file it is defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
--- drivers/ata/libahci.c | 1 - 1 file changed, 1 deletion(-)
drivers/ata/libahci.c +0 -1
@@ -175,7 +175,6 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {EXPORT_SYMBOL_GPL (ahci_pmp_retry_srst_ops);static bool ahci_em_messages__read_mostly = true; -EXPORT_SYMBOL_GPL (ahci_em_messages);module_param (ahci_em_messages, bool,0444 );/* add other LED protocol types when they become supported */ MODULE_PARM_DESC(ahci_em_messages,
Signature · 1 line
2.21.0
Quoted 10 lines
-----Original Message-----
From: Denis Efremov [mailto:[email protected]]
Sent: Wednesday, July 10, 2019 11:29 PM
To: Liu, Chuansheng <[email protected]>
Cc: Denis Efremov <[email protected]>; Jens Axboe <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] ahci: Remove the exporting ofahci_em_messages
Quoted 4 lines
The variable
ahci_em_messagesis declared static and markedEXPORT_SYMBOL_GPL, which is at best an odd combination. Because the variable is not used outside of thedrivers/ata/libahci.cfile it is defined in, this commit removes theEXPORT_SYMBOL_GPL()marking.
Sounds good to me, thanks.
Hi Jens,
Quoted 8 lines · Chuansheng
Quoted 8 lines
-----Original Message-----
From: Denis Efremov [mailto:[email protected]]
Sent: Wednesday, July 10, 2019 11:29 PM
To: Liu, Chuansheng <[email protected]>
Cc: Denis Efremov <[email protected]>; Jens Axboe <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] ahci: Remove the exporting ofahci_em_messages
Quoted 8 lines
Quoted 4 lines
The variable
ahci_em_messagesis declared static and markedEXPORT_SYMBOL_GPL, which is at best an odd combination. Because the variable is not used outside of thedrivers/ata/libahci.cfile it is defined in, this commit removes theEXPORT_SYMBOL_GPL()marking.Sounds good to me, thanks.
Reviewed-by Chuansheng Liu <[email protected]>
Could you please look at this patch once again and accept it if it's ok? static ahci_em_messages will trigger a warning after this check will be in tree https://lkml.org/lkml/2019/7/14/118
Thanks,
Denis