baseband/acc: coverity fix RC2
cover baseband/acc: coverity fix RC2
Fix for coverity issues 381631, 381646 raised on RC2 for the ACC100 PMD.
Hernan Vargas (1):
baseband/acc: fix check after deref and dead code
drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)
Signature · 1 line
2.37.1
PATCH 1/1 baseband/acc: fix check after deref and dead code
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
--- drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/baseband/acc/rte_acc100_pmd.c +0 -4
@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))return 0 ;#endif desc = q->ring_addr + (q->sw_ring_tail & q->sw_ring_wrap_mask); -if (unlikely (desc ==NULL )) -return 0 ; op = desc->req.op_addr;if (unlikely (ops ==NULL || op ==NULL ))return 0 ;
Signature · 1 line
2.37.1
Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
Quoted 16 lines · Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes 989dec301a9 ("baseband/acc100: add ring companion address")Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;
Can we be sure it can never be NULL?
static inline uint16_t rte_bbdev_dequeue_ldpc_enc_ops(uint16_t dev_id, uint16_t queue_id,
struct rte_bbdev_enc_op **ops, uint16_t num_ops)
{
struct rte_bbdev *dev = &rte_bbdev_devices[dev_id];
struct rte_bbdev_queue_data *q_data = &dev->data->queues[queue_id];
return dev->dequeue_ldpc_enc_ops(q_data, ops, num_ops);
}If the application passes an invalid queue_id or dev_id you can easily get garbage.
It may be worth adding some checks in all the helpers, to be sure dev_id is valid, and same for queue_id. We do that in Vhost library to improve robustness.
I know there is this comment:
"
* This function does not provide any error notification to avoid the
* corresponding overhead.
"
But to me this is not a good justification, the overhead would be minimal.
Regards,
Maxime
Quoted 10 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))return 0 ;#endif desc = q->ring_addr + (q->sw_ring_tail & q->sw_ring_wrap_mask); -if (unlikely (desc ==NULL )) -return 0 ; op = desc->req.op_addr;if (unlikely (ops ==NULL || op ==NULL ))return 0 ;
RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
Hi Maxime,
Quoted 53 lines
-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Friday, November 4, 2022 1:52 AM
To: Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codedrivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct
Quoted 17 lines · Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes 989dec301a9 ("baseband/acc100: add ring companion address")Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct
rte_bbdev_queue_data*q_data,drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;Can we be sure it can never be NULL?
static inline
uint16_trte_bbdev_dequeue_ldpc_enc_ops(uint16_tdev_id,uint16_tqueue_id,struct rte_bbdev_enc_op **ops, uint16_t num_ops) { struct rte_bbdev *dev = &rte_bbdev_devices[dev_id]; struct rte_bbdev_queue_data *q_data = &dev->data-drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct · line 4125
Quoted 1 line
drivers/baseband/acc/rte_acc100_pmd.c +0
-0queues[queue_id];return dev->dequeue_ldpc_enc_ops(q_data, ops, num_ops); }If the application passes an invalid
queue_idordev_idyou can easily get garbage.It may be worth adding some checks in all the helpers, to be sure
dev_idis valid, and same forqueue_id. We do that in Vhost library to improve robustness.
Quoted 8 lines
I know there is this comment:
"
* This function does not provide any error notification to avoid the
* corresponding overhead.
"But to me this is not a good justification, the overhead would be minimal.
Thanks.
The rational is that this function needs to be very lightweight since this is a called in loop and hence this is was captured explicitly in bbdev.
More generally I don’t believe that a change to bbdev would be relevant in that ticket, ok to move that discussion for later on in any case?
This ticket is purely about a Coverity fix for the ACC100 PMD. Note that we don’t check for q null during dequeue in most baseband PMD (including both intel and non-intel ones), this one was not required either, only historical. Does that sound fair in the context of that Coverity fix?
Thanks
Nic
Quoted 13 lines
Regards,
MaximeQuoted 10 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))return 0 ;#endif desc = q->ring_addr + (q->sw_ring_tail & q->sw_ring_wrap_mask); -if (unlikely (desc ==NULL )) -return 0 ; op = desc->req.op_addr;if (unlikely (ops ==NULL || op ==NULL ))return 0;
RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
Hi Maxime, Akhil,
This patch is not applied yet.
Any concern to apply this as is?
Maxime, unclear whether you recommend a change for this in the context of the coverify fix. Please kindly clarify. Do you want to keep the q == null in the PMD? Thanks
Nic
Quoted 101 lines
-----Original Message-----
From: Chautru, Nicolas
Sent: Friday, November 4, 2022 10:39 AM
To: Maxime Coquelin <[email protected]>; Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codeHi Maxime,
Quoted 54 lines
-----Original Message-----
From: Maxime Coquelin <[email protected]>
Sent: Friday, November 4, 2022 1:52 AM
To: Vargas, Hernan <[email protected]>; [email protected]; [email protected]; [email protected]
Cc: Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codedrivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct
Quoted 17 lines · Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes 989dec301a9 ("baseband/acc100: add ring companion address")Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct
rte_bbdev_queue_data*q_data,drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;Can we be sure it can never be NULL?
static inline
uint16_trte_bbdev_dequeue_ldpc_enc_ops(uint16_tdev_id,uint16_tqueue_id,struct rte_bbdev_enc_op **ops, uint16_t num_ops) { struct rte_bbdev *dev = &rte_bbdev_devices[dev_id]; struct rte_bbdev_queue_data *q_data = &dev->data-drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct · line 4125
Quoted 1 line
drivers/baseband/acc/rte_acc100_pmd.c +0
-0queues[queue_id];return dev->dequeue_ldpc_enc_ops(q_data, ops, num_ops); }If the application passes an invalid
queue_idordev_idyou can easily get garbage.It may be worth adding some checks in all the helpers, to be sure
dev_idis valid, and same forqueue_id. We do that in Vhost library to improve robustness.Quoted 8 lines
I know there is this comment:
"
* This function does not provide any error notification to avoid the
* corresponding overhead.
"But to me this is not a good justification, the overhead would be minimal.
Thanks.
The rational is that this function needs to be very lightweight since this is a called in loop and hence this is was captured explicitly in bbdev. More generally I don’t believe that a change to bbdev would be relevant in that ticket, ok to move that discussion for later on in any case?This ticket is purely about a Coverity fix for the ACC100 PMD. Note that we don’t check for q null during dequeue in most baseband PMD (including both intel and non-intel ones), this one was not required either, only historical. Does that sound fair in the context of that Coverity fix?
Thanks
NicQuoted 13 lines
Regards,
MaximeQuoted 10 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))return 0 ;#endif desc = q->ring_addr + (q->sw_ring_tail & q->sw_ring_wrap_mask); -if (unlikely (desc ==NULL )) -return 0 ; op = desc->req.op_addr;if (unlikely (ops ==NULL || op ==NULL ))return 0;
Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
In reply to Hernan VargasQuoted 17 lines · Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes 989dec301a9 ("baseband/acc100: add ring companion address")Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;
I guess this protects badly written applications that would do stuff like pass an incorrect queue id, or call this callback while the queue has not been configured yet.
This is something that should be caught at the bbdev layer (arguably under the RTE_LIBRTE_BBDEV_DEBUG if the performance is that much affected, though I'd like to see numbers).
(edit: I see Maxime replied a similar comment).
Back to this particular patch, rather than remove the check, the right fix is to move acc_ring_avail_deq(q).
This is what Coverity reports.
And this same pattern is used in other parts of the driver. It just happens that Coverity did not report them because some avec under RTE_LIBRTE_BBDEV_DEBUG...
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 2 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-0#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))
And I also noticed this hunk.
DPDK coding style, ops should be compared against NULL, but see below...
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4132
Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2return 0 ;#endif desc = q->ring_addr + (q->sw_ring_tail & q->sw_ring_wrap_mask); -if (unlikely (desc ==NULL )) -return 0 ; op = desc->req.op_addr;if (unlikely (ops ==NULL || op ==NULL ))return 0 ;
... like here, so above check is redundant.
There is probably more cleanups to do in this driver. This can be done later.
Signature · 1 line
David Marchand
RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
Hi David,
Quoted 36 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Thursday, November 10, 2022 1:49 AM
To: Vargas, Hernan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codedrivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct
Quoted 18 lines · Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes 989dec301a9 ("baseband/acc100: add ring companion address")Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct
rte_bbdev_queue_data*q_data,drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;
Quoted 7 lines
I guess this protects badly written applications that would do stuff like pass an incorrect queue id, or call this callback while the queue has not been configured yet.
This is something that should be caught at the bbdev layer (arguably under theRTE_LIBRTE_BBDEV_DEBUGif the performance is that much affected, though I'd like to see numbers).
(edit: I see Maxime replied a similar comment).
That is not directly to that ticket but would be good to follow up.
From previous discussion with Maxime, the new consensus was to avoid special check in debug mode (try to build the same code). It would be good to come up to a new consensus on this.
Quoted 8 lines
Back to this particular patch, rather than remove the check, the right fix is to move
acc_ring_avail_deq(q).
This is what Coverity reports.And this same pattern is used in other parts of the driver. It just happens that Coverity did not report them because some avec under
RTE_LIBRTE_BBDEV_DEBUG...
I believe that we don't want to create discrepancies : each dequeue function should behave the same way. Ie. acc100_dequeue_ldpc_enc should not do things differently from others dequeue functions. Currently there is a discrepancy which is being resolved in that patch.
Either we remove the check as in that commit which could be approved as is,
or we move the check under the debug as for the other functions which hides the Coverity issue without in reality fully addressing it, or we remove these check from all functions (including under debug) which is what we do for other PMD.
That 4th option you seem to suggest would consist in effect to do thing differently just for the dequeue function which would lacks consistency really.
Is there any concern just to approve as is, again that q == NULL is not done in production code anywhere else as you pointed out.
I agree that in next release we can remove much of the code under DEBUG flag which is not adding value nor being built/used in practice.
Thanks
Nic
Quoted 28 lines
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-0#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))And I also noticed this hunk.
DPDK coding style, ops should be compared against NULL, but see below...
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4132
Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2return 0 ;#endif desc = q->ring_addr + (q->sw_ring_tail & q->sw_ring_wrap_mask); -if (unlikely (desc ==NULL )) -return 0 ; op = desc->req.op_addr;if (unlikely (ops ==NULL || op ==NULL ))return 0 ;... like here, so above check is redundant.
There is probably more cleanups to do in this driver. This can be done later.
--
David Marchand
RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
David,
Reminder on this one. Ok to apply as is?
If not consensus we cannot also mark the Coverity warning as not an issue but please check notes below. Thanks
Nic
Quoted 122 lines
-----Original Message-----
From: Chautru, Nicolas
Sent: Thursday, November 10, 2022 1:15 PM
To: David Marchand <[email protected]>; Vargas, Hernan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codeHi David,
Quoted 37 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Thursday, November 10, 2022 1:49 AM
To: Vargas, Hernan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Chautru, Nicolas <[email protected]>; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codedrivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct
Quoted 18 lines · Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes 989dec301a9 ("baseband/acc100: add ring companion address")Signed-off-by Hernan Vargas <[email protected]>--- drivers/baseband/acc/rte_acc100_pmd.c | 4 ---- 1 file changed, 4 deletions(-)drivers/baseband/acc/rte_acc100_pmd.c +0
-0@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct
rte_bbdev_queue_data*q_data,drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;Quoted 7 lines
I guess this protects badly written applications that would do stuff like pass an incorrect queue id, or call this callback while the queue has not been configured yet.
This is something that should be caught at the bbdev layer (arguably under theRTE_LIBRTE_BBDEV_DEBUGif the performance is that much affected, though I'd like to see numbers).
(edit: I see Maxime replied a similar comment).That is not directly to that ticket but would be good to follow up. From previous discussion with Maxime, the new consensus was to avoid special check in debug mode (try to build the same code). It would be good to come up to a new consensus on this.
Quoted 8 lines
Back to this particular patch, rather than remove the check, the right fix is to move
acc_ring_avail_deq(q).
This is what Coverity reports.And this same pattern is used in other parts of the driver. It just happens that Coverity did not report them because some avec under
RTE_LIBRTE_BBDEV_DEBUG...I believe that we don't want to create discrepancies : each dequeue function should behave the same way. Ie.
acc100_dequeue_ldpc_encshould not do things differently from others dequeue functions.
Currently there is a discrepancy which is being resolved in that patch.Either we remove the check as in that commit which could be approved as is, or we move the check under the debug as for the other functions which hides the Coverity issue without in reality fully addressing it, or we remove these check from all functions (including under debug) which is what we do for other PMD.
That 4th option you seem to suggest would consist in effect to do thing differently just for the dequeue function which would lacks consistency really.
Is there any concern just to approve as is, again that q == NULL is not done in production code anywhere else as you pointed out.
I agree that in next release we can remove much of the code under DEBUG flag which is not adding value nor being built/used in practice.
Thanks
NicQuoted 28 lines
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-0#ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely (ops ==0 ))And I also noticed this hunk.
DPDK coding style, ops should be compared against NULL, but see below...
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4132
Quoted 8 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2return 0 ;#endif desc = q->ring_addr + (q->sw_ring_tail & q->sw_ring_wrap_mask); -if (unlikely (desc ==NULL )) -return 0 ; op = desc->req.op_addr;if (unlikely (ops ==NULL || op ==NULL ))return 0 ;... like here, so above check is redundant.
There is probably more cleanups to do in this driver. This can be done later.
--
David Marchand
Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
In reply to Chautru, NicolasHello Nicolas, Hernan,
Quoted 21 lines · Nicolas
Quoted 13 lines
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct
Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-0@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct
rte_bbdev_queue_data*q_data,drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;Quoted 7 lines
I guess this protects badly written applications that would do stuff like pass an incorrect queue id, or call this callback while the queue has not been configured yet.
This is something that should be caught at the bbdev layer (arguably under theRTE_LIBRTE_BBDEV_DEBUGif the performance is that much affected, though I'd like to see numbers).
(edit: I see Maxime replied a similar comment).
Quoted 2 lines
That is not directly to that ticket but would be good to follow up.
From previous discussion with Maxime, the new consensus was to avoid special check in debug mode (try to build the same code). It would be good to come up to a new consensus on this.
- Yes, there is something to look at in follow ups so we agree on which checks to add and have them *consistent* for all dequeue functions.
I am not taking sides with removing or adding checks for now.
My point above was to ask for performance numbers as part of this follow ups. If there is concern that adding checks has a cost, we need numbers to conclude. I saw none so far.
- Now, for this patch precisely, I still stand with this part of my previous mail:
""
Quoted 3 lines
Quoted 3 lines
Back to this particular patch, rather than remove the check, the right fix is to move
acc_ring_avail_deq(q).
This is what Coverity reports.
"""
This suggestion here seems the minimal and correct fix.
Deciding on removing/adding more checks can be decided in follow up discussions.
Signature · 1 line
David Marchand
RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
Hi David,
I am not sure why the push back. The minimal and proper fix is that v1.
We are not making that check for other dequeue function. It should not have been there in the first place. See previous discussion.
Thanks
Nic
Quoted 67 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Tuesday, November 15, 2022 8:00 AM
To: Chautru, Nicolas <[email protected]>; Vargas, Hernan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codeHello Nicolas, Hernan,
Quoted 21 lines · Nicolas
Quoted 13 lines
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct
Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-0@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct
rte_bbdev_queue_data*q_data,drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;Quoted 7 lines
I guess this protects badly written applications that would do stuff like pass an incorrect queue id, or call this callback while the queue has not been configured yet.
This is something that should be caught at the bbdev layer (arguably under theRTE_LIBRTE_BBDEV_DEBUGif the performance is that much affected, though I'd like to see numbers).
(edit: I see Maxime replied a similar comment).Quoted 2 lines
That is not directly to that ticket but would be good to follow up. From previous discussion with Maxime, the new consensus was to avoid
special check in debug mode (try to build the same code). It would be good to come up to a new consensus on this.
- Yes, there is something to look at in follow ups so we agree on which checks to add and have them *consistent* for all dequeue functions.
I am not taking sides with removing or adding checks for now.My point above was to ask for performance numbers as part of this follow ups.
If there is concern that adding checks has a cost, we need numbers to conclude.
I saw none so far.- Now, for this patch precisely, I still stand with this part of my previous mail:
""
Quoted 3 lines
Quoted 3 lines
Back to this particular patch, rather than remove the check, the right fix is to move
acc_ring_avail_deq(q).
This is what Coverity reports."""
This suggestion here seems the minimal and correct fix.
Deciding on removing/adding more checks can be decided in follow up discussions.
--
David Marchand
RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code
Hi David,
Given we are already at RC3, let's keep the PMD as is and avoid code churn on top of lack of consensus.
It is not worth spending more time on this for 22.11.
I have marked the issue accordingly in Coverity, there is no concerning vulnerability just dead code which is minor and accepted. As mentioned we can clean up some of these checks in 23.03, hence marked as deferred.
Thanks
Nic
Quoted 86 lines
-----Original Message-----
From: Chautru, Nicolas <[email protected]>
Sent: Tuesday, November 15, 2022 10:04 AM
To: David Marchand <[email protected]>; Vargas, Hernan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Zhang, Qi Z <[email protected]>
Subject: RE: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codeHi David,
I am not sure why the push back. The minimal and proper fix is that v1. We are not making that check for other dequeue function. It should not have been there in the first place.
See previous discussion.Thanks
NicQuoted 44 lines
-----Original Message-----
From: David Marchand <[email protected]>
Sent: Tuesday, November 15, 2022 8:00 AM
To: Chautru, Nicolas <[email protected]>; Vargas, Hernan <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; Zhang, Qi Z <[email protected]>
Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead codeHello Nicolas, Hernan,
Quoted 21 lines · Nicolas
Quoted 13 lines
drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct
Quoted 6 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-0@@ -4122,15 +4122,11 @@ acc100_dequeue_ldpc_enc(struct
rte_bbdev_queue_data*q_data,drivers/baseband/acc/rte_acc100_pmd.c acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, · line 4126
Quoted 5 lines
drivers/baseband/acc/rte_acc100_pmd.c +0
-2struct rte_bbdev_enc_op *op;union acc_dma_desc *desc; -if (q ==NULL ) -return 0 ;Quoted 7 lines
I guess this protects badly written applications that would do stuff like pass an incorrect queue id, or call this callback while the queue has not been configured yet.
This is something that should be caught at the bbdev layer (arguably under theRTE_LIBRTE_BBDEV_DEBUGif the performance is that much affected, though I'd like to see numbers). (edit: I see Maxime replied a similar comment).Quoted 2 lines
That is not directly to that ticket but would be good to follow up. From previous discussion with Maxime, the new consensus was to avoid
special check in debug mode (try to build the same code). It would be good to come up to a new consensus on this.
- Yes, there is something to look at in follow ups so we agree on which checks to add and have them *consistent* for all dequeue functions. I am not taking sides with removing or adding checks for now.
Quoted 8 lines
My point above was to ask for performance numbers as part of this follow ups.
If there is concern that adding checks has a cost, we need numbers to conclude.
I saw none so far.- Now, for this patch precisely, I still stand with this part of my previous
mail:
Quoted 15 lines
""
Quoted 3 lines
Quoted 3 lines
Back to this particular patch, rather than remove the check, the right fix is to move
acc_ring_avail_deq(q).
This is what Coverity reports."""
This suggestion here seems the minimal and correct fix.
Deciding on removing/adding more checks can be decided in follow up discussions.
--
David Marchand