Skip to contentSkip to conversation

ARM: BCM5310X: Enable earlyprintk on tested devices

PATCH Superseded Rafał Miłecki 3 participants 7 messages Jan 20, 2015

Subsystems (2)
Device tree bindings Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/2 ARM: BCM5310X: Enable earlyprintk on tested devices

Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts  | 2 +-
 arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts       | 2 +-
 arch/arm/boot/dts/bcm4708-netgear-r6250.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts +1 -1
index b359c1e..ce083a5 100644
@@ -16,7 +16,7 @@
 	model = "Buffalo WZR-1750DHP (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts +1 -1
index 946c728..f57f213 100644
@@ -16,7 +16,7 @@
 	model = "Luxul XWC-1000 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm4708-netgear-r6250.dts +1 -1
index f18c9d9..0a5f561 100644
@@ -16,7 +16,7 @@
 	model = "Netgear R6250 V1 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts +1 -1
index 0ee85ea..4d87219 100644
@@ -16,7 +16,7 @@
 	model = "Asus RT-N18U (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts +1 -1
index db9131e..362f914 100644
@@ -16,7 +16,7 @@
 	model = "Buffalo WZR-600DHP2 (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
Signature · 1 line
1.8.4.5
author
#1 lore raw

PATCH 2/2 ARM: BCM5301X: Add DT for Buffalo WZR-900DHP

Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/boot/dts/Makefile                        |  3 +-
 arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts | 37 +++++++++++++++++++++++
 2 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts
arch/arm/boot/dts/Makefile +2 -1
index ff4a5ae..0de664e 100644
@@ -61,7 +61,8 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
 	bcm4708-netgear-r6250.dtb \
 	bcm4708-netgear-r6300-v2.dtb \
 	bcm47081-asus-rt-n18u.dtb \
-	bcm47081-buffalo-wzr-600dhp2.dtb
+	bcm47081-buffalo-wzr-600dhp2.dtb \
+	bcm47081-buffalo-wzr-900dhp.dtb
 dtb-$(CONFIG_ARCH_BCM_63XX) += bcm963138dvt.dtb
 dtb-$(CONFIG_ARCH_BCM_CYGNUS) += bcm911360_entphn.dtb \
 	bcm911360k.dtb \
arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts new file +37 -0
new file mode 100644
index 0000000..b5352c0
@@ -0,0 +1,37 @@
+/*
+ * Broadcom BCM470X / BCM5301X ARM platform code.
+ * DTS for Buffalo WZR-900DHP
+ *
+ * Copyright (C) 2015 Rafa? Mi?ecki <[email protected]>
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+
+/dts-v1/;
+
+#include "bcm47081.dtsi"
+
+/ {
+	compatible = "buffalo,wzr-900dhp", "brcm,bcm47081", "brcm,bcm4708";
+	model = "Buffalo WZR-900DHP (BCM47081)";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+
+	memory {
+		reg = <0x00000000 0x08000000>;
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		restart {
+			label = "Reset";
+			linux,code = <KEY_RESTART>;
+			gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
+		};
+	};
+};
Signature · 1 line
1.8.4.5
author
#2 lore raw

PATCH v2 1/1 ARM: BCM5301X: Add DT for Buffalo WZR-900DHP

Signed-off-by Rafa? Mi?ecki <[email protected]>

---
V2: Drop earlyprintk from bootargs

---
 arch/arm/boot/dts/Makefile                        |  3 +-
 arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts | 37 +++++++++++++++++++++++
 2 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts
arch/arm/boot/dts/Makefile +2 -1
index ff4a5ae..0de664e 100644
@@ -61,7 +61,8 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \
 	bcm4708-netgear-r6250.dtb \
 	bcm4708-netgear-r6300-v2.dtb \
 	bcm47081-asus-rt-n18u.dtb \
-	bcm47081-buffalo-wzr-600dhp2.dtb
+	bcm47081-buffalo-wzr-600dhp2.dtb \
+	bcm47081-buffalo-wzr-900dhp.dtb
 dtb-$(CONFIG_ARCH_BCM_63XX) += bcm963138dvt.dtb
 dtb-$(CONFIG_ARCH_BCM_CYGNUS) += bcm911360_entphn.dtb \
 	bcm911360k.dtb \
arch/arm/boot/dts/bcm47081-buffalo-wzr-900dhp.dts new file +37 -0
new file mode 100644
index 0000000..7d6868a
@@ -0,0 +1,37 @@
+/*
+ * Broadcom BCM470X / BCM5301X ARM platform code.
+ * DTS for Buffalo WZR-900DHP
+ *
+ * Copyright (C) 2015 Rafa? Mi?ecki <[email protected]>
+ *
+ * Licensed under the GNU/GPL. See COPYING for details.
+ */
+
+/dts-v1/;
+
+#include "bcm47081.dtsi"
+
+/ {
+	compatible = "buffalo,wzr-900dhp", "brcm,bcm47081", "brcm,bcm4708";
+	model = "Buffalo WZR-900DHP (BCM47081)";
+
+	chosen {
+		bootargs = "console=ttyS0,115200";
+	};
+
+	memory {
+		reg = <0x00000000 0x08000000>;
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		restart {
+			label = "Reset";
+			linux,code = <KEY_RESTART>;
+			gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
+		};
+	};
+};
Signature · 1 line
1.8.4.5
author
#3 lore raw

PATCH v2 1/2 ARM: BCM5301X: Enable earlyprintk on tested devices

In reply to Rafał Miłecki
Signed-off-by Rafa? Mi?ecki <[email protected]>

---
V2: Typo in commit message: s/BCM5310X/BCM5301X/

---
 arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts  | 2 +-
 arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts       | 2 +-
 arch/arm/boot/dts/bcm4708-netgear-r6250.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts +1 -1
index b359c1e..ce083a5 100644
@@ -16,7 +16,7 @@
 	model = "Buffalo WZR-1750DHP (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts +1 -1
index 946c728..f57f213 100644
@@ -16,7 +16,7 @@
 	model = "Luxul XWC-1000 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm4708-netgear-r6250.dts +1 -1
index f18c9d9..0a5f561 100644
@@ -16,7 +16,7 @@
 	model = "Netgear R6250 V1 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts +1 -1
index 0ee85ea..4d87219 100644
@@ -16,7 +16,7 @@
 	model = "Asus RT-N18U (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts +1 -1
index db9131e..362f914 100644
@@ -16,7 +16,7 @@
 	model = "Buffalo WZR-600DHP2 (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
Signature · 1 line
1.8.4.5
#4 lore raw

PATCH v2 1/2 ARM: BCM5301X: Enable earlyprintk on tested devices

Quoted 4 lines · Rafa? Mi?ecki
Signed-off-by Rafa? Mi?ecki <[email protected]>

---
V2: Typo in commit message: s/BCM5310X/BCM5301X/
---

In this pull request Arnd said that enabling early printk is a bad idea:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/304438.html

Hauke

Quoted 73 lines
 arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts  | 2 +-
 arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts       | 2 +-
 arch/arm/boot/dts/bcm4708-netgear-r6250.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts        | 2 +-
 arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
arch/arm/boot/dts/bcm4708-buffalo-wzr-1750dhp.dts +1 -1
index b359c1e..ce083a5 100644
@@ -16,7 +16,7 @@
 	model = "Buffalo WZR-1750DHP (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm4708-luxul-xwc-1000.dts +1 -1
index 946c728..f57f213 100644
@@ -16,7 +16,7 @@
 	model = "Luxul XWC-1000 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm4708-netgear-r6250.dts +1 -1
index f18c9d9..0a5f561 100644
@@ -16,7 +16,7 @@
 	model = "Netgear R6250 V1 (BCM4708)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm47081-asus-rt-n18u.dts +1 -1
index 0ee85ea..4d87219 100644
@@ -16,7 +16,7 @@
 	model = "Asus RT-N18U (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dts +1 -1
index db9131e..362f914 100644
@@ -16,7 +16,7 @@
 	model = "Buffalo WZR-600DHP2 (BCM47081)";
 
 	chosen {
-		bootargs = "console=ttyS0,115200";
+		bootargs = "console=ttyS0,115200 earlyprintk";
 	};
 
 	memory {
maintainer
#6 lore raw

PATCH v2 1/2 ARM: BCM5301X: Enable earlyprintk on tested devices

In reply to Hauke Mehrtens
Quoted 9 lines · On Tuesday 20 January 2015 22:11:59 Hauke Mehrtens wrote:
Quoted 4 lines · Rafa? Mi?ecki
Signed-off-by Rafa? Mi?ecki <[email protected]>

---
V2: Typo in commit message: s/BCM5310X/BCM5301X/
---

In this pull request Arnd said that enabling early printk is a bad idea:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/304438.html

To clarify my comment from back then: earlycon support for ARM did *not* make it into 3.19, although I think it works on x86, arm64 and mips.

I hope this gets resolved for 3.20.

Arnd