sonypi: Stop setting acpi_device_name/class()
Rafael J. Wysocki
maintainerPATCH 1/1 sonypi: Stop setting acpi_device_name/class()
From: "Rafael J. Wysocki" <[email protected]>
The driver sets acpi_device_name() and acpi_device_class() which are never read afterward, so make it stop doing that.
No intentional functional impact.
This will facilitate the removal of device_name and device_class from struct acpi_device_pnp in the future.
--- drivers/char/sonypi.c | 2 -- 1 file changed, 2 deletions(-)
drivers/char/sonypi.c +0 -2
@@ -1125,8 +1125,6 @@ static int sonypi_acpi_probe(struct platform_device *pdev)return -ENODEV ; sonypi_acpi_device = device; -strscpy (acpi_device_name (device),"Sony laptop hotkeys" ); -strscpy (acpi_device_class (device),"sony/hotkey" );return 0 ; }
Signature · 1 line
2.51.0
Quoted 7 lines · Rafael J. Wysocki
The driver sets
acpi_device_name()andacpi_device_class()which are never read afterward, so make it stop doing that.No intentional functional impact.
This will facilitate the removal of
device_nameanddevice_classfrom structacpi_device_pnpin the future.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Rafael J. Wysocki
The driver sets
acpi_device_name()andacpi_device_class()which are never read afterward, so make it stop doing that.No intentional functional impact.
This will facilitate the removal of
device_nameanddevice_classfrom structacpi_device_pnpin the future.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Ilpo Järvinen
maintainerQuoted 9 lines · Rafael J. Wysocki
The driver sets
acpi_device_name()andacpi_device_class()which are never read afterward, so make it stop doing that.No intentional functional impact.
This will facilitate the removal of
device_nameanddevice_classfrom structacpi_device_pnpin the future.[...]
Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.
FYI [if applicable to your patch], as per Linus' policy change, also fixes are mostly routed through for-next unless the fix is for a commit introduced in the most recent cycle or is clearly a regression fix.
The list of commits applied:
[1/1] sonypi: Stop setting acpi_device_name/class()
commit: ec0a9831c71593ada1c6831724575e840efc7600
--
i.