Fix gianfar netdriver oops when using bootp...

PATCH In review Gerhard Jaeger 2 participants 6 messages Dec 1, 2004 – Dec 3, 2004 Network drivers

lore

Share & tools

lore

Gerhard Jaeger

author

2004-12-01 16:32 UTC #0 lore raw

PATCH 1/1 Fix gianfar netdriver oops when using bootp...

Hi,

this patch fixes an issue, that occurs on my MPC8541CDS, when trying to use bootp to get the IP parameters. It seems, that the patch only cures the symptom but obviously not the cause ;)

Signed-off-by Gerhard Jaeger <[email protected]>

drivers/net/gianfar.c renamed from drivers/net/gianfar.c.orig +3 -0

@@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
 	struct gfar_private *priv = netdev_priv(dev);
 	int result = 0;
 
+	if( !priv->mii_info->phyinfo )
+		return;
+
 	/* Delay to give the PHY a chance to change the
 	 * register state */
 	msleep(1);

Kumar Gala

2004-12-01 22:19 UTC #1 lore raw

There is some belief that the following patch should fix the issue:

http://linux.bkbits.net:8080/linux-2.5/[email protected]?=20
nav=3Dindex.html|ChangeSet@-3d

I would be interested to know if this helps w/o your patch.

- kumar

Quoted 3 lines · Gerhard Jaeger

Hi,
this patch fixes an issue, that occurs on my MPC8541CDS, when trying =

Quoted 7 lines

use bootp to get the IP parameters. It seems, that the patch only =20
cures
the symptom but obviously not the cause ;)
Signed-off-by Gerhard Jaeger <[email protected]>
--- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0 =

2004-11-15 =20

Quoted 13 lines

02:26:34.000000000 +0100
+++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01 =20
17:00:19.000000000 +0100
@@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data) =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv(dev);
=A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
=A0
 +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo )
 +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
+
=A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to change the =A0=A0=A0=A0=A0=A0=A0=A0 * register state */ =A0=A0=A0=A0=A0=A0=A0 msleep(1);

Gerhard Jaeger

author

2004-12-02 08:07 UTC #2 lore raw

Hi,

Quoted 3 lines · Kumar Gala

There is some belief that the following patch should fix the issue:
=20
http://linux.bkbits.net:8080/linux-2.5/[email protected]? nav=3Dindex.html|=

ChangeSet@-3d

Quoted 2 lines

=20
I would be interested to know if this helps w/o your patch.

I'd like to cross-check this, but are you sure, you're referencing the corr= ect
changeset? Currently I only got:
Error 500
Unable to find revision 1.2249.2.2

Gerhard

Quoted 15 lines

=20
- kumar
=20
On Dec 1, 2004, at 10:07 AM, Gerhard Jaeger wrote:
=20
Quoted 10 lines
Hi,
this patch fixes an issue, that occurs on my MPC8541CDS, when trying to
use bootp to get the IP parameters. It seems, that the patch only =20
cures
the symptom but obviously not the cause ;)
Signed-off-by Gerhard Jaeger <[email protected]>
--- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0 2004-11=

=2D15 =20

Quoted 15 lines

Quoted 7 lines
02:26:34.000000000 +0100
+++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01 =20
17:00:19.000000000 +0100
@@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data) =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv(dev);
=A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
=A0
Quoted 6 lines
 +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo )
 +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
+
=A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to change the =A0=A0=A0=A0=A0=A0=A0=A0 * register state */ =A0=A0=A0=A0=A0=A0=A0 msleep(1);
=20
=20

Kumar Gala

2004-12-02 08:14 UTC #3 lore raw

Fun with mailers. Try this url:

http://tinyurl.com/6skww

- kumar

Quoted 31 lines · Gerhard Jaeger

Hi,
Quoted 3 lines · Kumar Gala
There is some belief that the following patch should fix the issue:
http://linux.bkbits.net:8080/linux-2.5/[email protected]?=20
nav=3Dindex.html|ChangeSet@-3d
Quoted 2 lines
I would be interested to know if this helps w/o your patch.
I'd like to cross-check this, but are you sure, you're referencing the=20=
correct
changeset? Currently I only got:
Error 500
Unable to find revision 1.2249.2.2
Gerhard
Quoted 8 lines
- kumar
Quoted 3 lines · Gerhard Jaeger
Hi,
this patch fixes an issue, that occurs on my MPC8541CDS, when=20
trying to
Quoted 1 line
Quoted 1 line
=A0 use bootp to get the IP parameters. It seems, that the patch=20=
only=A0

Quoted 13 lines

Quoted 6 lines
Quoted 6 lines
cures
=A0 the symptom but obviously not the cause ;)
Signed-off-by Gerhard Jaeger <[email protected]>
--- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0=20=
2004-11-15=A0
Quoted 5 lines
Quoted 5 lines
02:26:34.000000000 +0100
=A0 +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01=A0 17:00:19.000000000 +0100
=A0 @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data) =A0 =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D =

netdev_priv(dev);

Quoted 6 lines

Quoted 6 lines
Quoted 6 lines
=A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
=A0 =A0
=A0 +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo ) =A0 +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return; =A0 +
=A0 =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to =

change the

Quoted 4 lines

Quoted 4 lines
Quoted 2 lines
=A0 =A0=A0=A0=A0=A0=A0=A0=A0 * register state */
=A0 =A0=A0=A0=A0=A0=A0=A0 msleep(1);

Gerhard Jaeger

author

2004-12-02 08:25 UTC #4 lore raw

Quoted 3 lines · Kumar Gala

Fun with mailers. Try this url:
=20
http://tinyurl.com/6skww

Thanks that works (I mean the URL ;)
I have not tested, but this might will work, as I noticed, that when addidi= onally
CONFIG_RARP is enabled, there are also no problems.

Anyway, I'll test ASAP and will tell you the results.

Thanx so far,
Gerhard

Quoted 16 lines

=20
- kumar
=20
On Dec 2, 2004, at 2:07 AM, Gerhard Jaeger wrote:
=20
Quoted 11 lines
Hi,
Quoted 3 lines · Kumar Gala
There is some belief that the following patch should fix the issue:
http://linux.bkbits.net:8080/linux-2.5/[email protected]?=20
nav=3Dindex.html|ChangeSet@-3d
Quoted 2 lines
I would be interested to know if this helps w/o your patch.
I'd like to cross-check this, but are you sure, you're referencing the=

=20

Quoted 23 lines

Quoted 23 lines
correct
changeset? Currently I only got:
Error 500
Unable to find revision 1.2249.2.2
Gerhard
Quoted 8 lines
- kumar
Quoted 3 lines · Gerhard Jaeger
Hi,
this patch fixes an issue, that occurs on my MPC8541CDS, when=20
trying to
Quoted 1 line
Quoted 1 line
=A0 use bootp to get the IP parameters. It seems, that the patch=20
only=A0
Quoted 5 lines
Quoted 5 lines
cures
=A0 the symptom but obviously not the cause ;)
Signed-off-by Gerhard Jaeger <[email protected]>

Quoted 7 lines

Quoted 7 lines
Quoted 1 line
Quoted 1 line
--- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig=A0=A0=A0=A0=20
2004-11-15=A0
Quoted 5 lines
Quoted 5 lines
02:26:34.000000000 +0100
=A0 +++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c=A0 2004-12-01=A0 17:00:19.000000000 +0100
=A0 @@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data) =A0 =A0=A0=A0=A0=A0=A0=A0 struct gfar_private *priv =3D netdev_priv=

(dev);

Quoted 6 lines

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
=A0=A0=A0=A0=A0=A0=A0 int result =3D 0;
=A0 =A0
=A0 +=A0=A0=A0=A0=A0=A0 if( !priv->mii_info->phyinfo ) =A0 +=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 return;
=A0 +
=A0 =A0=A0=A0=A0=A0=A0=A0 /* Delay to give the PHY a chance to chan=

ge the

Quoted 6 lines

Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
=A0 =A0=A0=A0=A0=A0=A0=A0=A0 * register state */
=A0 =A0=A0=A0=A0=A0=A0=A0 msleep(1);
=20
=20

Gerhard Jaeger

author

2004-12-03 11:35 UTC #5 lore raw

Hi,

Quoted 10 lines · Gerhard Jaeger

Quoted 3 lines · Kumar Gala
Fun with mailers. Try this url:
http://tinyurl.com/6skww
Thanks that works (I mean the URL ;)
I have not tested, but this might will work, as I noticed, that when addidionally CONFIG_RARP is enabled, there are also no problems.
Anyway, I'll test ASAP and will tell you the results.

I've now applied this ipconfig patch and removed my piece of code and:
it works - so ignore my patch ;)

Thanx,
Gerhard

Quoted 11 lines

Thanx so far,
Gerhard
Quoted 7 lines
- kumar
Quoted 4 lines · Gerhard Jaeger
Hi,
Quoted 1 line · Kumar Gala
There is some belief that the following patch should fix the iss=

ue:

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
http://linux.bkbits.net:8080/linux-2.5/[email protected]?
nav=3Dindex.html|ChangeSet@-3d
Quoted 1 line
I would be interested to know if this helps w/o your patch.
I'd like to cross-check this, but are you sure, you're referencing =

the

Quoted 40 lines

Quoted 40 lines
Quoted 40 lines
correct
changeset? Currently I only got:
Error 500
Unable to find revision 1.2249.2.2
Gerhard
Quoted 6 lines
- kumar
Quoted 3 lines · Gerhard Jaeger
Hi,
this patch fixes an issue, that occurs on my MPC8541CDS, when
trying to
Quoted 1 line
Quoted 1 line
use bootp to get the IP parameters. It seems, that the patch
only=20
Quoted 6 lines
Quoted 6 lines
cures
the symptom but obviously not the cause ;)
Signed-off-by Gerhard Jaeger <[email protected]>
--- linux-2.6.10-rc2-mm4/drivers/net/gianfar.c.orig =20
2004-11-15=20
Quoted 11 lines
Quoted 11 lines
02:26:34.000000000 +0100
+++ linux-2.6.10-rc2-mm4/drivers/net/gianfar.c 2004-12-01=20
17:00:19.000000000 +0100
@@ -1477,6 +1477,9 @@ static void gfar_phy_change(void *data)
         struct gfar_private *priv =3D netdev_priv(dev);

        int result =3D 0;

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
=20
+ if( !priv->mii_info->phyinfo )
+ return;
+
         /* Delay to give the PHY a chance to change the
          * register state */

         msleep(1);

--=20
Gerhard Jaeger [email protected]
SYSGO AG Embedded and Real-Time Software
www.sysgo.com | www.elinos.com | www.osek.de | www.imerva.com