Skip to contentSkip to conversation

RDMA/efa: get rid of create_user_ah

PATCH Superseded Yajun Deng 2 participants 2 messages Mar 8, 2022 – Mar 9, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yajun Deng

author
#0 lore raw

PATCH 3/9 RDMA/efa: get rid of create_user_ah

There is no create_user_ah in ib_device_ops, remove it.

---
 drivers/infiniband/hw/efa/efa_main.c  | 2 +-
 drivers/infiniband/hw/efa/efa_verbs.c | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/infiniband/hw/efa/efa_main.c +1 -1
index 94b94cca4870..b2f3832cd305 100644
@@ -361,7 +361,7 @@ static const struct ib_device_ops efa_dev_ops = {
 	.alloc_ucontext = efa_alloc_ucontext,
 	.create_cq = efa_create_cq,
 	.create_qp = efa_create_qp,
-	.create_user_ah = efa_create_ah,
+	.create_ah = efa_create_ah,
 	.dealloc_pd = efa_dealloc_pd,
 	.dealloc_ucontext = efa_dealloc_ucontext,
 	.dereg_mr = efa_dereg_mr,
drivers/infiniband/hw/efa/efa_verbs.c +5 -0
index ecfe70eb5efb..44269eb18780 100644
@@ -1959,6 +1959,11 @@ int efa_create_ah(struct ib_ah *ibah,
 	struct efa_ah *ah = to_eah(ibah);
 	int err;
 
+	if (!udata) {
+		err = -EOPNOTSUPP;
+		goto err_out;
+	}
+
 	if (!(init_attr->flags & RDMA_CREATE_AH_SLEEPABLE)) {
 		ibdev_dbg(&dev->ibdev,
 			  "Create address handle is not supported in atomic context\n");
Signature · 1 line
2.25.1
reviewer
#1 lore raw
Quoted 26 lines · Yajun Deng

There is no create_user_ah in ib_device_ops, remove it.

---
 drivers/infiniband/hw/efa/efa_main.c  | 2 +-
 drivers/infiniband/hw/efa/efa_verbs.c | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/infiniband/hw/efa/efa_main.c +1 -1
index 94b94cca4870..b2f3832cd305 100644
@@ -361,7 +361,7 @@ static const struct ib_device_ops efa_dev_ops = {
 	.alloc_ucontext = efa_alloc_ucontext,
 	.create_cq = efa_create_cq,
 	.create_qp = efa_create_qp,
-	.create_user_ah = efa_create_ah,
+	.create_ah = efa_create_ah,
 	.dealloc_pd = efa_dealloc_pd,
 	.dealloc_ucontext = efa_dealloc_ucontext,
 	.dereg_mr = efa_dereg_mr,
drivers/infiniband/hw/efa/efa_verbs.c +0 -0
index ecfe70eb5efb..44269eb18780 100644

drivers/infiniband/hw/efa/efa_verbs.c int efa_create_ah(struct ib_ah *ibah, · line 1966

Quoted 8 lines
drivers/infiniband/hw/efa/efa_verbs.c +5 -0
@@ -1959,6 +1959,11 @@ int efa_create_ah(struct ib_ah *ibah,
 	struct efa_ah *ah = to_eah(ibah);
 	int err;
 
+	if (!udata) {
+		err = -EOPNOTSUPP;
+		goto err_out;
+	}
+

This part is not needed, kverbs flows are blocked for EFA.

Thanks