x86/apic: Skip pv ipi test if hcall not available
PATCH 1/1 x86/apic: Skip pv ipi test if hcall not available
From: Suraj Jitindar Singh <[email protected]>
The test in x86/apic.c named test_pv_ipi is used to test for a kernel bug where a guest making the hcall KVM_HC_SEND_IPI can trigger an out of bounds access.
If the host doesn't implement this hcall then the out of bounds access cannot be triggered.
Detect the case where the host doesn't implement the KVM_HC_SEND_IPI hcall and skip the test when this is the case, as the test doesn't apply.
Output without patch:
FAIL: PV IPIs testing
With patch:
SKIP: PV IPIs testing: h-call not available
--- x86/apic.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
x86/apic.c +11 -0
@@ -8,6 +8,8 @@#include "atomic.h" #include "fwcfg.h" +#include <linux/kvm_para.h> +#define MAX_TPR 0xfstatic void test_lapic_existence (void )
@@ -638,6 +640,15 @@ static void test_pv_ipi(void)unsigned long a0 =0xFFFFFFFF , a1 =0 , a2 =0xFFFFFFFF , a3 =0x0 ; asmvolatile ("vmcall" :"=a" (ret) :"a" (KVM_HC_SEND_IPI ),"b" (a0),"c" (a1),"d" (a2),"S" (a3)); +/* +* Detect the case where the hcall is not implemented by the hypervisor and +* skip this test if this is the case. Is the hcall isn't implemented then +* the bug that this test is trying to catch can't be triggered. +*/ +if (ret == -KVM_ENOSYS ) { +report_skip ("PV IPIs testing: h-call not available" ); +return ; + }report ("PV IPIs testing" , !ret); }
Signature · 1 line
2.15.3.AMZN
Quoted 42 lines · Suraj Jitindar Singh
From: Suraj Jitindar Singh <[email protected]>
The test in
x86/apic.cnamedtest_pv_ipiis used to test for a kernel bug where a guest making the hcallKVM_HC_SEND_IPIcan trigger an out of bounds access.If the host doesn't implement this hcall then the out of bounds access cannot be triggered.
Detect the case where the host doesn't implement the
KVM_HC_SEND_IPIhcall and skip the test when this is the case, as the test doesn't apply.Output without patch:
FAIL: PV IPIs testingWith patch:
SKIP: PV IPIs testing: h-call not availableSigned-off-by Suraj Jitindar Singh <[email protected]>--- x86/apic.c | 11 +++++++++++ 1 file changed, 11 insertions(+)x86/apic.c +3
-0@@ -8,6 +8,8 @@#include "atomic.h" #include "fwcfg.h" +#include <linux/kvm_para.h> +#define MAX_TPR 0xfstatic void test_lapic_existence (void )@@ -638,6 +640,15 @@ static void test_pv_ipi(void)unsigned long a0 =0xFFFFFFFF , a1 =0 , a2 =0xFFFFFFFF , a3 =0x0 ; asmvolatile ("vmcall" :"=a" (ret) :"a" (KVM_HC_SEND_IPI ),"b" (a0),"c" (a1),"d" (a2),"S" (a3)); +/*
x86/apic.c static void test_pv_ipi(void) · line 653
Quoted 10 lines
x86/apic.c +8
-0+* Detect the case where the hcall is not implemented by the hypervisor and +* skip this test if this is the case. Is the hcall isn't implemented then +* the bug that this test is trying to catch can't be triggered. +*/ +if (ret == -KVM_ENOSYS ) { +report_skip ("PV IPIs testing: h-call not available" ); +return ; + }report ("PV IPIs testing" , !ret); }
Should we be checking CPUID bit (KVM_FEATURE_PV_SEND_IPI) instead?
Signature · 1 line
Vitaly
Hi,
Quoted 57 lines · Vitaly Kuznetsov
Quoted 55 lines · Suraj Jitindar Singh
From: Suraj Jitindar Singh <[email protected]>
The test in
x86/apic.cnamedtest_pv_ipiis used to test for a kernel
bug where a guest making the hcallKVM_HC_SEND_IPIcan trigger an out of
bounds access.If the host doesn't implement this hcall then the out of bounds access
cannot be triggered.Detect the case where the host doesn't implement the
KVM_HC_SEND_IPI
hcall and skip the test when this is the case, as the test doesn't apply.Output without patch:
FAIL: PV IPIs testingWith patch:
SKIP: PV IPIs testing: h-call not availableSigned-off-by Suraj Jitindar Singh <[email protected]>--- x86/apic.c | 11 +++++++++++ 1 file changed, 11 insertions(+)x86/apic.c +4
-0@@ -8,6 +8,8 @@#include "atomic.h" #include "fwcfg.h" +#include <linux/kvm_para.h> +#define MAX_TPR 0xfstatic void test_lapic_existence (void )@@ -638,6 +640,15 @@ static void test_pv_ipi(void)unsigned long a0 =0xFFFFFFFF , a1 =0 , a2 =0xFFFFFFFF , a3 =0x0 ; asmvolatile ("vmcall" :"=a" (ret) :"a" (KVM_HC_SEND_IPI ),"b" (a0),"c" (a1),"d" (a2),"S" (a3)); +/* +* Detect the case where the hcall is not implemented by the hypervisor and
+ * skip this test if this is the case. Is the hcall isn't
implemented then
+ * the bug that this test is trying to catch can't be
triggered.
+ */
Quoted 9 lines
x86/apic.c static void test_pv_ipi(void) · line 653
Quoted 6 lines
x86/apic.c +4
-0+if (ret == -KVM_ENOSYS ) { +report_skip ("PV IPIs testing: h-call not available" ); +return ; + }report ("PV IPIs testing" , !ret); }Should we be checking CPUID bit (
KVM_FEATURE_PV_SEND_IPI) instead?
That's also an option. It will produce the same result.
Would that be the preferred approach or is the method used in the current patch ok?
Quoted 70 lines · Suraj Jitindar Singh
Hi,
Quoted 57 lines · Vitaly Kuznetsov
Quoted 55 lines · Suraj Jitindar Singh
From: Suraj Jitindar Singh <[email protected]>
The test in
x86/apic.cnamedtest_pv_ipiis used to test for a kernel
bug where a guest making the hcallKVM_HC_SEND_IPIcan trigger an out of
bounds access.If the host doesn't implement this hcall then the out of bounds access
cannot be triggered.Detect the case where the host doesn't implement the
KVM_HC_SEND_IPI
hcall and skip the test when this is the case, as the test doesn't apply.Output without patch:
FAIL: PV IPIs testingWith patch:
SKIP: PV IPIs testing: h-call not availableSigned-off-by Suraj Jitindar Singh <[email protected]>--- x86/apic.c | 11 +++++++++++ 1 file changed, 11 insertions(+)x86/apic.c +4
-0@@ -8,6 +8,8 @@#include "atomic.h" #include "fwcfg.h" +#include <linux/kvm_para.h> +#define MAX_TPR 0xfstatic void test_lapic_existence (void )@@ -638,6 +640,15 @@ static void test_pv_ipi(void)unsigned long a0 =0xFFFFFFFF , a1 =0 , a2 =0xFFFFFFFF , a3 =0x0 ; asmvolatile ("vmcall" :"=a" (ret) :"a" (KVM_HC_SEND_IPI ),"b" (a0),"c" (a1),"d" (a2),"S" (a3)); +/* +* Detect the case where the hcall is not implemented by the hypervisor and
+ * skip this test if this is the case. Is the hcall isn't
implemented then
+ * the bug that this test is trying to catch can't be
triggered.
+ */Quoted 9 lines
x86/apic.c static void test_pv_ipi(void) · line 653
Quoted 6 lines
x86/apic.c +4
-0+if (ret == -KVM_ENOSYS ) { +report_skip ("PV IPIs testing: h-call not available" ); +return ; + }report ("PV IPIs testing" , !ret); }Should we be checking CPUID bit (
KVM_FEATURE_PV_SEND_IPI) instead?
Quoted 2 lines
That's also an option. It will produce the same result.
Generally yes, but CPUID announcement has its own advantages: when a feature bit is set we know the hypercall *must* exist so -KVM_ENOSYS would be a bug (think of a theoretical situation when the hypercall starts to return -KVM_ENOSYS erroneously - how do we catch this?)
Quoted 2 lines
Would that be the preferred approach or is the method used in the current patch ok?
I'm not insisting, let's leave it up to Paolo :-)
Signature · 1 line
Vitaly
Quoted 71 lines · Suraj Jitindar Singh
Hi,
Quoted 57 lines · Vitaly Kuznetsov
Quoted 55 lines · Suraj Jitindar Singh
From: Suraj Jitindar Singh <[email protected]>
The test in
x86/apic.cnamedtest_pv_ipiis used to test for a kernel
bug where a guest making the hcallKVM_HC_SEND_IPIcan trigger an out of
bounds access.If the host doesn't implement this hcall then the out of bounds access
cannot be triggered.Detect the case where the host doesn't implement the
KVM_HC_SEND_IPI
hcall and skip the test when this is the case, as the test doesn't apply.Output without patch:
FAIL: PV IPIs testingWith patch:
SKIP: PV IPIs testing: h-call not availableSigned-off-by Suraj Jitindar Singh <[email protected]>--- x86/apic.c | 11 +++++++++++ 1 file changed, 11 insertions(+)x86/apic.c +4
-0@@ -8,6 +8,8 @@#include "atomic.h" #include "fwcfg.h" +#include <linux/kvm_para.h> +#define MAX_TPR 0xfstatic void test_lapic_existence (void )@@ -638,6 +640,15 @@ static void test_pv_ipi(void)unsigned long a0 =0xFFFFFFFF , a1 =0 , a2 =0xFFFFFFFF , a3 =0x0 ; asmvolatile ("vmcall" :"=a" (ret) :"a" (KVM_HC_SEND_IPI ),"b" (a0),"c" (a1),"d" (a2),"S" (a3)); +/* +* Detect the case where the hcall is not implemented by the hypervisor and
+ * skip this test if this is the case. Is the hcall isn't
implemented then
+ * the bug that this test is trying to catch can't be
triggered.
+ */Quoted 9 lines
x86/apic.c static void test_pv_ipi(void) · line 653
Quoted 6 lines
x86/apic.c +4
-0+if (ret == -KVM_ENOSYS ) { +report_skip ("PV IPIs testing: h-call not available" ); +return ; + }report ("PV IPIs testing" , !ret); }Should we be checking CPUID bit (
KVM_FEATURE_PV_SEND_IPI) instead?
Quoted 4 lines
That's also an option. It will produce the same result.
Would that be the preferred approach or is the method used in the current patch ok?
Btw, is it amazon using pv ipis? I don't think. I suspect there is an extra hardware assistant to benefit broadcast ipis in amazon.
Wanpeng