tools/xenstore: fix event sending in introduce_domain()
PATCH 1/1 tools/xenstore: fix event sending in introduce_domain()
Commit fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain") introduced a potential NULL dereference in case of Xenstore live update.
Fix that by adding an appropriate check.
Coverity-Id: 1504572
--- tools/xenstore/xenstored_domain.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
tools/xenstore/xenstored_domain.c +5 -3
@@ -493,9 +493,11 @@ static struct domain *introduce_domain(const void *ctx,/* Now domain belongs to its connection. */ talloc_steal (domain->conn, domain); -/* Notify the domain that xenstore is available */ - interface->connection =XENSTORE_CONNECTED ; -xenevtchn_notify (xce_handle, domain->port); +if (!restore) { +/* Notify the domain that xenstore is available */ + interface->connection =XENSTORE_CONNECTED ; +xenevtchn_notify (xce_handle, domain->port); + }if (!is_master_domain && !restore) fire_watches(NULL, ctx, "@introduceDomain", NULL,
Signature · 1 line
2.35.3
Quoted 9 lines · Juergen Gross
Commit
fc2b57c9af46("xenstored: send an evtchn notification onintroduce_domain") introduced a potential NULL dereference in case of Xenstore live update.Fix that by adding an appropriate check.
Coverity-Id: 1504572
Fixes fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain")Signed-off-by Juergen Gross <[email protected]>
just looked at the Coverity report too.
CC'ing the others involved in the original patch just so they're aware it was broken.
~Andrew
Quoted 23 lines
--- tools/xenstore/xenstored_domain.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)tools/xenstore/xenstored_domain.c +5
-3@@ -493,9 +493,11 @@ static struct domain *introduce_domain(const void *ctx,/* Now domain belongs to its connection. */ talloc_steal (domain->conn, domain); -/* Notify the domain that xenstore is available */ - interface->connection =XENSTORE_CONNECTED ; -xenevtchn_notify (xce_handle, domain->port); +if (!restore) { +/* Notify the domain that xenstore is available */ + interface->connection =XENSTORE_CONNECTED ; +xenevtchn_notify (xce_handle, domain->port); + }if (!is_master_domain && !restore) fire_watches(NULL, ctx, "@introduceDomain", NULL,
Hi Andrew,
Quoted 10 lines · Andrew Cooper
Quoted 9 lines · Juergen Gross
Commit
fc2b57c9af46("xenstored: send an evtchn notification onintroduce_domain") introduced a potential NULL dereference in case of Xenstore live update.Fix that by adding an appropriate check.
Coverity-Id: 1504572
Fixes fc2b57c9af46 ("xenstored: send an evtchn notification on introduce_domain")Signed-off-by Juergen Gross <[email protected]>
Committed.
Quoted 2 lines
Reviewed-by Andrew Cooper <[email protected]> seeing as I've
b4 will end up to pick "seeing as I've":
42sh> b4 am [email protected]
Looking up https://lore.kernel.org/r/21392cc6-55b6-647e-08eb-c818d6229603%40srcf.net
Grabbing thread from lore.kernel.org/all/21392cc6-55b6-647e-08eb-c818d6229603%40srcf.net/t.mbox.gz Analyzing 2 messages in the thread
Checking attestation on all messages, may take a moment...
---
✓ [PATCH] tools/xenstore: fix event sending in introduce_domain()
+ Reviewed-by: Andrew Cooper <[email protected]> seeing as I've
---
✓ Signed: DKIM/suse.com
---
Total patches: 1
---
Base: applies clean to current tree
git am
./20220525_jgross_tools_xenstore_fix_event_sending_in_introduce_domain.mbx
I don't think this is fixable in b4 because we allow to have additional information after the tag (e.g. # arm).
So would you be able to avoid adding words after the tags that are not meant to committed? This would reduce the amount of manual work when committing.
Cheers,
Signature · 1 line
Julien Grall