Skip to contentSkip to conversation

mtest01: fix max_pids formula

PATCH New Jan Stancek 2 participants 3 messages May 3, 2017

lore
Share & tools
lore

Jan Stancek

author
#0 lore raw

PATCH 1/1 mtest01: fix max_pids formula

Values returned by sysinfo() are in multiple of mem_unit bytes.

Signed-off-by Jan Stancek <[email protected]>
---
 testcases/kernel/mem/mtest01/mtest01.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
testcases/kernel/mem/mtest01/mtest01.c +2 -1
index f3fba044c529..6225d7d7b671 100644
@@ -152,7 +152,8 @@ int main(int argc, char *argv[])
 	total_free = sstats.freeram + sstats.freeswap;
 	/* Total Free Pre-Test RAM */
 	pre_mem = sstats.mem_unit * total_free;
-	max_pids = total_ram / (unsigned long)FIVE_HUNDRED_MB + 10;
+	max_pids = total_ram * sstats.mem_unit
+		/ (unsigned long)FIVE_HUNDRED_MB + 10;
 
 	if ((pid_list = malloc(max_pids * sizeof(pid_t))) == NULL)
 		tst_brkm(TBROK | TERRNO, NULL, "malloc failed.");
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 mtest01: fix max_pids formula

Hi!

Quoted 12 lines

Values returned by sysinfo() are in multiple of mem_unit bytes.

Signed-off-by Jan Stancek <[email protected]>
---
 testcases/kernel/mem/mtest01/mtest01.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
testcases/kernel/mem/mtest01/mtest01.c +0 -0
index f3fba044c529..6225d7d7b671 100644

testcases/kernel/mem/mtest01/mtest01.c int main(int argc, char *argv[]) · line 156

Quoted 6 lines
testcases/kernel/mem/mtest01/mtest01.c +2 -1
@@ -152,7 +152,8 @@ int main(int argc, char *argv[])
 	total_free = sstats.freeram + sstats.freeswap;
 	/* Total Free Pre-Test RAM */
 	pre_mem = sstats.mem_unit * total_free;
-	max_pids = total_ram / (unsigned long)FIVE_HUNDRED_MB + 10;
+	max_pids = total_ram * sstats.mem_unit
+		/ (unsigned long)FIVE_HUNDRED_MB + 10;

Looks OK.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH 1/1 mtest01: fix max_pids formula

----- Original Message -----

Quoted 8 lines

Hi!

Quoted 7 lines

Values returned by sysinfo() are in multiple of mem_unit bytes.

Signed-off-by Jan Stancek <[email protected]>
---
 testcases/kernel/mem/mtest01/mtest01.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 14 lines

testcases/kernel/mem/mtest01/mtest01.c int main(int argc, char *argv[]) · line 156

Quoted 12 lines
testcases/kernel/mem/mtest01/mtest01.c +2 -1
index f3fba044c529..6225d7d7b671 100644
@@ -152,7 +152,8 @@ int main(int argc, char *argv[])
 	total_free = sstats.freeram + sstats.freeswap;
 	/* Total Free Pre-Test RAM */
 	pre_mem = sstats.mem_unit * total_free;
-	max_pids = total_ram / (unsigned long)FIVE_HUNDRED_MB + 10;
+	max_pids = total_ram * sstats.mem_unit
+		/ (unsigned long)FIVE_HUNDRED_MB + 10;

Looks OK.

Pushed.

Regards,
Jan