Skip to contentSkip to conversation

kasan, mm: fix build issue with asmlinkage

PATCH In review Valdis Klētnieks 3 participants 3 messages Nov 26, 2020 – Nov 30, 2020 KASAN

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kasan, mm: fix build issue with asmlinkage

commit 2df573d2ca4c1ce6ea33cb7849222f771e759211

Author: Andrey Konovalov <[email protected]>
Date:   Tue Nov 24 16:45:08 2020 +1100

kasan: shadow declarations only for software modes

introduces a build failure when it removed an include for linux/pgtable.h It actually only needs linux/linkage.h

Test builds on both x86_64 and arm build cleanly

Fixes 2df573d2ca4c ("kasan: shadow declarations only for software modes")

---

include/linux/kasan.h +1 -0
index 83860aa4e89c..5e0655fb2a6f 100644
@@ -12,6 +12,7 @@ struct task_struct;
 
 #ifdef CONFIG_KASAN
 
+#include <linux/linkage.h>
 #include <asm/kasan.h>
 
 /* kasan_data struct is used in KUnit tests for KASAN expected failures */
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Valdis Klētnieks

commit 2df573d2ca4c1ce6ea33cb7849222f771e759211

Author: Andrey Konovalov <[email protected]>
Date:   Tue Nov 24 16:45:08 2020 +1100

kasan: shadow declarations only for software modes

Quoted 7 lines

introduces a build failure when it removed an include for linux/pgtable.h It actually only needs linux/linkage.h

Test builds on both x86_64 and arm build cleanly

Fixes 2df573d2ca4c ("kasan: shadow declarations only for software modes")

Probably want to add

for more context, too.

Thanks,
-- Marco

Quoted 19 lines

---

include/linux/kasan.h +1 -1
index 83860aa4e89c..5e0655fb2a6f 100644
@@ -12,6 +12,7 @@ struct task_struct;
 
 #ifdef CONFIG_KASAN
 
+#include <linux/linkage.h>
 #include <asm/kasan.h>
 
 /* kasan_data struct is used in KUnit tests for KASAN expected failures */
 
 
--

You received this message because you are subscribed to the Google Groups "kasan-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/35126.1606402815%40turing-police.

Reviewed-by
#2 lore raw
Quoted 16 lines · Marco Elver
Quoted 6 lines · Valdis Klētnieks

commit 2df573d2ca4c1ce6ea33cb7849222f771e759211

Author: Andrey Konovalov <[email protected]>
Date:   Tue Nov 24 16:45:08 2020 +1100

kasan: shadow declarations only for software modes

Quoted 7 lines

introduces a build failure when it removed an include for linux/pgtable.h It actually only needs linux/linkage.h

Test builds on both x86_64 and arm build cleanly

Fixes 2df573d2ca4c ("kasan: shadow declarations only for software modes")
Quoted 7 lines

Probably want to add

for more context, too.

Thank you, Valdis!