mm/hugetlb: Simplify the calculation of variables
Subsystems (2)
PATCH 1/1 mm/hugetlb: Simplify the calculation of variables
Fix the following coccicheck warnings:
./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to !A || B.
Reported-by Abaci Robot <[email protected]>
Signed-off-by Jiapeng Zhong <[email protected]>
--- mm/hugetlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
mm/hugetlb.c +1 -2
@@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h) mpol_allowed =policy_nodemask_current (gfp_mask);for_each_node_mask (node, cpuset_current_mems_allowed) { -if (!mpol_allowed || - (mpol_allowed &&node_isset (node, *mpol_allowed))) +if (!mpol_allowed ||node_isset (node, *mpol_allowed)) nr += array[node]; }
Signature · 1 line
1.8.3.1
Hi:
Quoted 17 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to !A || B.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>--- mm/hugetlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)mm/hugetlb.c +0
-0
mm/hugetlb.c static unsigned int allowed_mems_nr(struct hstate *h) · line 3373
Quoted 9 lines
mm/hugetlb.c +1
-2@@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h) mpol_allowed =policy_nodemask_current (gfp_mask);for_each_node_mask (node, cpuset_current_mems_allowed) { -if (!mpol_allowed || - (mpol_allowed &&node_isset (node, *mpol_allowed))) +if (!mpol_allowed ||node_isset (node, *mpol_allowed)) nr += array[node]; }
I'm gonna do this too. :)
Reviewed-by Miaohe Lin <[email protected]>
Quoted 10 lines · Jiapeng Zhong
Fix the following coccicheck warnings:
./mm/hugetlb.c:3372:20-22: WARNING !A || A && B is equivalent to !A || B.
Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Zhong <[email protected]>--- mm/hugetlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks,
Reviewed-by Mike Kravetz <[email protected]>
Signature · 1 line
Mike Kravetz
Quoted 16 lines
mm/hugetlb.c +1
-2@@ -3367,8 +3367,7 @@ static unsigned int allowed_mems_nr(struct hstate *h) mpol_allowed =policy_nodemask_current (gfp_mask);for_each_node_mask (node, cpuset_current_mems_allowed) { -if (!mpol_allowed || - (mpol_allowed &&node_isset (node, *mpol_allowed))) +if (!mpol_allowed ||node_isset (node, *mpol_allowed)) nr += array[node]; }