afs: Fix fileserver probe RTT handling
Subsystems (2)
David Howells
maintainerPATCH 1/1 afs: Fix fileserver probe RTT handling
Hi Linus,
Could you apply this patch, please?
Thanks,
David
---
The fileserver probing code attempts to work out the best fileserver to use for a volume by retrieving the RTT calculated by AF_RXRPC for the probe call sent to each server and comparing them. Sometimes, however, no RTT estimate is available and rxrpc_kernel_get_srtt() returns false, leading good fileservers to be given an RTT of UINT_MAX and thus causing the rotation algorithm to ignore them.
Fix afs_select_fileserver() to ignore rxrpc_kernel_get_srtt()'s return value and just take the estimated RTT it provides - which will be capped at 1 second.
Fixes 1d4adfaf6574 ("rxrpc: Make rxrpc_kernel_get_srtt() indicate validity")
Signed-off-by David Howells <[email protected]>
Reviewed-by Marc Dionne <[email protected]>
Tested-by Marc Dionne <[email protected]>
--- fs/afs/fs_probe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/afs/fs_probe.c +2 -2
@@ -167,8 +167,8 @@ void afs_fileserver_probe_result(struct afs_call *call)clear_bit (AFS_SERVER_FL_HAS_FS64 , &server->flags); } -if (rxrpc_kernel_get_srtt (call->net->socket, call->rxcall, &rtt_us) && - rtt_us < server->probe.rtt) { +rxrpc_kernel_get_srtt (call->net->socket, call->rxcall, &rtt_us); +if (rtt_us < server->probe.rtt) { server->probe.rtt = rtt_us; server->rtt = rtt_us; alist->preferred = index;