arm64: tegra: Enable built-in RTC on Jetson AGX Thor
Subsystems (2)
Thierry Reding
maintainerPATCH 1/1 arm64: tegra: Enable built-in RTC on Jetson AGX Thor
From: Thierry Reding <[email protected]>
The built-in RTC is mostly useful for testing suspend/resume cycles.
--- arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +6 -0
@@ -13,6 +13,12 @@ chosen { stdout-path = "serial0:115200n8"; }; + bus@0 { + rtc@c2c0000 { + status = "okay"; + }; + }; + gpio-keys { compatible = "gpio-keys";
Signature · 1 line
2.55.0
Jon Hunter
maintainerQuoted 14 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The built-in RTC is mostly useful for testing suspend/resume cycles.
Signed-off-by Thierry Reding <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +0
-0
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi chosen { · line 21
Quoted 9 lines
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +6
-0@@ -13,6 +13,12 @@ chosen { stdout-path = "serial0:115200n8"; }; + bus@0 { + rtc@c2c0000 { + status = "okay"; + }; + }; +
Any reason we should not just enable in tegra264.dtsi by default? I see that we do that for tegra234.
Jon
Signature · 1 line
nvpublic
Thierry Reding
maintainerQuoted 20 lines · Jon Hunter
Quoted 18 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The built-in RTC is mostly useful for testing suspend/resume cycles.
Signed-off-by Thierry Reding <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +2
-0@@ -13,6 +13,12 @@ chosen { stdout-path = "serial0:115200n8"; }; + bus@0 { + rtc@c2c0000 {
Quoted 8 lines
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi chosen { · line 21
Quoted 4 lines
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +4
-0+ status = "okay"; + }; + }; +Any reason we should not just enable in
tegra264.dtsiby default? I see that we do that for tegra234.
This is more of a development type of option and not everybody may want to have it enabled, especially since it's not always hooked up to do anything useful. We commonly use it on the devkit for suspend/resume testing, so it's useful there, but even then there's usually another RTC on a PMIC or something that's considered the primary one.
So in production I suspect people may not want to enable the built-in RTC. If we enabled it by default, then people would have to explicitly disable it again.
I don't feel very strongly either way, and I could easily be swayed.
Thierry
Quoted 36 lines · Thierry Reding
Quoted 20 lines · Jon Hunter
Quoted 18 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The built-in RTC is mostly useful for testing suspend/resume cycles.
Signed-off-by Thierry Reding <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +2
-0@@ -13,6 +13,12 @@ chosen { stdout-path = "serial0:115200n8"; }; + bus@0 { + rtc@c2c0000 {Quoted 8 lines
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi chosen { · line 21
Quoted 4 lines
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +4
-0+ status = "okay"; + }; + }; +Any reason we should not just enable in
tegra264.dtsiby default? I see that we do that for tegra234.This is more of a development type of option and not everybody may want to have it enabled, especially since it's not always hooked up to do anything useful. We commonly use it on the devkit for suspend/resume testing, so it's useful there, but even then there's usually another RTC on a PMIC or something that's considered the primary one.
Quoted 5 lines
So in production I suspect people may not want to enable the built-in RTC. If we enabled it by default, then people would have to explicitly disable it again.
I don't feel very strongly either way, and I could easily be swayed.
I would be good to get this added. I don't have strong feelings either way. So ...
Thanks!
Jon
Signature · 1 line
nvpublic
Quoted 42 lines · Jon Hunter
Quoted 40 lines · Thierry Reding
Quoted 20 lines · Jon Hunter
Quoted 18 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The built-in RTC is mostly useful for testing suspend/resume cycles.
Signed-off-by Thierry Reding <[email protected]>--- arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +2
-0@@ -13,6 +13,12 @@ chosen { stdout-path = "serial0:115200n8"; }; + bus@0 { + rtc@c2c0000 {Quoted 8 lines
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi chosen { · line 21
Quoted 4 lines
arch/arm64/boot/dts/nvidia/tegra264-p4071-0000+p3834.dtsi +4
-0+ status = "okay"; + }; + }; +Any reason we should not just enable in
tegra264.dtsiby default? I see that we do that for tegra234.This is more of a development type of option and not everybody may want to have it enabled, especially since it's not always hooked up to do anything useful. We commonly use it on the devkit for suspend/resume testing, so it's useful there, but even then there's usually another RTC on a PMIC or something that's considered the primary one.
So in production I suspect people may not want to enable the built-in RTC. If we enabled it by default, then people would have to explicitly disable it again.
Quoted 7 lines
Quoted 1 line
I don't feel very strongly either way, and I could easily be swayed.
I would be good to get this added. I don't have strong feelings either way. So ...
Tested-by Jon Hunter <[email protected]>Acked-by Jon Hunter <[email protected]>
Applied, thanks.
Thierry