Skip to contentSkip to conversation

clk: samsung: mark PM functions as __maybe_unused

PATCH In review Sylwester Nawrocki 2 participants 2 messages Dec 4, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 clk: samsung: mark PM functions as __maybe_unused

From: Arnd Bergmann <[email protected]>

The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume functions are now unused when CONFIG_PM is disabled:

drivers/clk/samsung/clk-exynos-clkout.c:219:12: error: 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
219 | static int exynos_clkout_resume(struct device *dev)

      |            ^~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk-exynos-clkout.c:210:12: error: 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
  210 | static int exynos_clkout_suspend(struct device *dev)
      |            ^~~~~~~~~~~~~~~~~~~~~

Mark them as __maybe_unused to shut up the otherwise harmless warning.

Fixes 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module driver")

---
v2: add proper changelog text

#1 lore raw
Quoted 17 lines · Sylwester Nawrocki

From: Arnd Bergmann <[email protected]>

The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume functions are now unused when CONFIG_PM is disabled:

drivers/clk/samsung/clk-exynos-clkout.c:219:12: error:
'exynos_clkout_resume' defined but not used [-Werror=unused-function]
219 | static int exynos_clkout_resume(struct device *dev)

       |            ^~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk-exynos-clkout.c:210:12: error:
'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
   210 | static int exynos_clkout_suspend(struct device *dev)
       |            ^~~~~~~~~~~~~~~~~~~~~

Mark them as __maybe_unused to shut up the otherwise harmless warning.

Quoted 8 lines
Fixes 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module

driver")

---
v2: add proper changelog text

Indeed this should go via samsung soc tree...

Best regards,
Krzysztof