sound: sscape: add missing include of asm/io.h
PATCH 1/1 sound: sscape: add missing include of asm/io.h
The soundscape driver uses the ISA inb/outb functions declared in asm/io.h, so it needs to include this header to avoid a build error:
sscape.c: In function 'sscape_write_unsafe':
sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
sound/isa/sscape.c +1 -0
@@ -23,6 +23,7 @@#include <linux/init.h> #include <linux/err.h> +#include <linux/io.h> #include <linux/isa.h> #include <linux/delay.h> #include <linux/firmware.h>
At Wed, 28 Jan 2015 15:54:04 +0100,
Quoted 9 lines · Arnd Bergmann
The soundscape driver uses the ISA inb/outb functions declared in
asm/io.h, so it needs to include this header to avoid a build error:
sscape.c: In function 'sscape_write_unsafe':
sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]Signed-off-by Arnd Bergmann <[email protected]>
Could you correct asm/io.h with linux/io.h in subject and description to match with the actual change?
thanks,
Takashi
Quoted 14 lines
sound/isa/sscape.c +1
-0@@ -23,6 +23,7 @@#include <linux/init.h> #include <linux/err.h> +#include <linux/io.h> #include <linux/isa.h> #include <linux/delay.h> #include <linux/firmware.h>
PATCH 1/1 sound: sscape: add missing include of linux/io.h
The soundscape driver uses the ISA inb/outb functions declared in linux/io.h, so it needs to include this header to avoid a build error:
sscape.c: In function 'sscape_write_unsafe':
sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]
---
Sorry about messing up the patch description the first time. I'm cleaning out old patches from a randconfig build tree and I found this one was still needed but did not inspect the changelog closely enough.
sound/isa/sscape.c +1 -0
@@ -23,6 +23,7 @@#include <linux/init.h> #include <linux/err.h> +#include <linux/io.h> #include <linux/isa.h> #include <linux/delay.h> #include <linux/firmware.h>
Takashi Iwai
AppliedRe: [PATCH] sound: sscape: add missing include of linux/io.h
At Wed, 28 Jan 2015 16:04:46 +0100,
Quoted 5 lines · Arnd Bergmann
The soundscape driver uses the ISA inb/outb functions declared in
linux/io.h, so it needs to include this header to avoid a build error:
Quoted 8 lines
sscape.c: In function 'sscape_write_unsafe':
sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]Signed-off-by Arnd Bergmann <[email protected]>---
Sorry about messing up the patch description the first time. I'm cleaning out old patches from a randconfig build tree and I found this one was still needed but did not inspect the changelog closely enough.
Thanks, applied.
Takashi
Quoted 14 lines
sound/isa/sscape.c +1
-0@@ -23,6 +23,7 @@#include <linux/init.h> #include <linux/err.h> +#include <linux/io.h> #include <linux/isa.h> #include <linux/delay.h> #include <linux/firmware.h>