Skip to contentSkip to conversation

cpuidle: teo: Exclude cpuidle overhead from computations

PATCH New Rafael J. Wysocki 1 participant 1 message Nov 12, 2019 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuidle: teo: Exclude cpuidle overhead from computations

From: Rafael J. Wysocki <[email protected]>

One purpose of the computations in teo_update() is to determine whether or not the (saved) time till the next timer event and the measured idle duration fall into the same "bin", so avoid using values that include the cpuidle overhead to obtain the latter.

---
 drivers/cpuidle/governors/teo.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/cpuidle/governors/teo.c +8 -1
Index: linux-pm/drivers/cpuidle/governors/teo.c
===================================================================
@@ -130,7 +130,14 @@ static void teo_update(struct cpuidle_dr
 	} else {
 		u64 lat_ns = drv->states[dev->last_state_idx].exit_latency_ns;
 
-		measured_ns = cpu_data->time_span_ns;
+		/*
+		 * The computations below are to determine whether or not the
+		 * (saved) time till the next timer event and the measured idle
+		 * duration fall into the same "bin", so use last_residency_ns
+		 * for that instead of time_span_ns which includes the cpuidle
+		 * overhead.
+		 */
+		measured_ns = dev->last_residency_ns;
 		/*
 		 * The delay between the wakeup and the first instruction
 		 * executed by the CPU is not likely to be worst-case every