bonding: do not clear curr_active_slave prematurely when releasing all slaves
Subsystems (3)
PATCH 1/1 bonding: do not clear curr_active_slave prematurely when releasing all slaves
When releasing all slaves during bond destruction (all == true), __bond_release_one() unconditionally clears bond->curr_active_slave to NULL in every iteration.
If a backup slave is released before the active slave, bond_alb_deinit_slave() triggers rlb_teach_disabled_mac_on_primary(), which increments the active slave dev promiscuity counter and sets bond_info->primary_is_promisc = 1.
Because bond->curr_active_slave was prematurely cleared to NULL when releasing the backup slave, the subsequent iteration releasing the active slave evaluates oldcurrent as NULL, so bond_change_active_slave(bond, NULL) is skipped. Consequently, bond_alb_handle_active_change() is never called to decrement the promiscuity counter, permanently leaking promiscuous mode on the physical device after bond teardown.
When oldcurrent == slave, bond_change_active_slave(bond, NULL) already sets bond->curr_active_slave to NULL. We only need to avoid selecting a new active slave when all == true. Replace the if (all) branch with if (!all && oldcurrent == slave).
---
Cc: Jay Vosburgh <[email protected]>
--- drivers/net/bonding/bond_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/bonding/bond_main.c +1 -3
@@ -2517,9 +2517,7 @@ static int __bond_release_one(struct net_device *bond_dev,bond_alb_deinit_slave (bond, slave); } -if (all) { -RCU_INIT_POINTER (bond->curr_active_slave,NULL ); - }else if (oldcurrent == slave) { +if (!all && oldcurrent == slave) {/* Note that we hold RTNL over this sequence, so there * is no concern that another slave add/remove event * will interfere.
Signature · 1 line
2.55.0.970.g62bdec98f9-goog
Quoted 16 lines · Eric Dumazet
When releasing all slaves during bond destruction (all == true),
__bond_release_one()unconditionally clearsbond->curr_active_slaveto NULL in every iteration.If a backup slave is released before the active slave,
bond_alb_deinit_slave()triggersrlb_teach_disabled_mac_on_primary(), which increments the active slave dev promiscuity counter and setsbond_info->primary_is_promisc= 1.Because
bond->curr_active_slavewas prematurely cleared to NULL when releasing the backup slave, the subsequent iteration releasing the active slave evaluates oldcurrent as NULL, sobond_change_active_slave(bond, NULL)is skipped. Consequently,bond_alb_handle_active_change()is never called to decrement the promiscuity counter, permanently leaking promiscuous mode on the physical device after bond teardown.
Quoted 7 lines
When oldcurrent == slave,
bond_change_active_slave(bond, NULL)already setsbond->curr_active_slaveto NULL. We only need to avoid selecting a new active slave when all == true. Replace the if (all) branch with if (!all && oldcurrent == slave).Fixes 0896341a44bf ("bonding: fix bond_release_all inconsistencies")Signed-off-by Eric Dumazet <[email protected]>
Complicated failure path, but looks correct.
-J
Quoted 24 lines
---
Cc: Jay Vosburgh <[email protected]>
---drivers/net/bonding/bond_main.c| 4 +---1 file changed, 1 insertion(+), 3 deletions(-)drivers/net/bonding/bond_main.c +1
-3@@ -2517,9 +2517,7 @@ static int __bond_release_one(struct net_device *bond_dev,bond_alb_deinit_slave (bond, slave); } -if (all) { -RCU_INIT_POINTER (bond->curr_active_slave,NULL ); - }else if (oldcurrent == slave) { +if (!all && oldcurrent == slave) {/* Note that we hold RTNL over this sequence, so there * is no concern that another slave add/remove event * will interfere. Signature · 1 line
2.55.0.970.g62bdec98f9-goog
---
-Jay Vosburgh, [email protected]
Quoted 34 lines · Eric Dumazet
When releasing all slaves during bond destruction (all == true),
__bond_release_one()unconditionally clearsbond->curr_active_slaveto NULL in every iteration.If a backup slave is released before the active slave,
bond_alb_deinit_slave()triggersrlb_teach_disabled_mac_on_primary(), which increments the active slave dev promiscuity counter and setsbond_info->primary_is_promisc= 1.Because
bond->curr_active_slavewas prematurely cleared to NULL when releasing the backup slave, the subsequent iteration releasing the active slave evaluates oldcurrent as NULL, sobond_change_active_slave(bond, NULL)is skipped. Consequently,bond_alb_handle_active_change()is never called to decrement the promiscuity counter, permanently leaking promiscuous mode on the physical device after bond teardown.When oldcurrent == slave,
bond_change_active_slave(bond, NULL)already setsbond->curr_active_slaveto NULL. We only need to avoid selecting a new active slave when all == true. Replace the if (all) branch with if (!all && oldcurrent == slave).Fixes 0896341a44bf ("bonding: fix bond_release_all inconsistencies")Signed-off-by Eric Dumazet <[email protected]>---
Cc: Jay Vosburgh <[email protected]>--- drivers/net/bonding/bond_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/net/bonding/bond_main.c +0
-0
drivers/net/bonding/bond_main.c static int __bond_release_one(struct net_device *bond_dev, · line 2523
Quoted 10 lines
drivers/net/bonding/bond_main.c +1
-3@@ -2517,9 +2517,7 @@ static int __bond_release_one(struct net_device *bond_dev,bond_alb_deinit_slave (bond, slave); } -if (all) { -RCU_INIT_POINTER (bond->curr_active_slave,NULL ); - }else if (oldcurrent == slave) { +if (!all && oldcurrent == slave) {/* Note that we hold RTNL over this sequence, so there * is no concern that another slave add/remove event * will interfere.
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 31 Aug 2026 20:30:42 +0000 you wrote:
When releasing all slaves during bond destruction (all == true),
__bond_release_one()unconditionally clearsbond->curr_active_slaveto NULL in every iteration.If a backup slave is released before the active slave,
bond_alb_deinit_slave()triggersrlb_teach_disabled_mac_on_primary(), which increments the active slave dev promiscuity counter and setsbond_info->primary_is_promisc= 1.[...]
Here is the summary with links:
- [net] bonding: do not clear curr_active_slave prematurely when releasing all slaves
https://git.kernel.org/netdev/net/c/af602c7aa5fe
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html