Skip to contentSkip to conversation

dmaengine: Add Synopsys eDMA IP core driver

RFC Superseded Gustavo Pimentel 1 participant 1 message Jan 21, 2019

Subsystems (2)

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

RFC v3 1/7 dmaengine: Add Synopsys eDMA IP core driver

Quoted 11 lines · Andy Shevchenko
Quoted 8 lines · Gustavo Pimentel
Quoted 5 lines · Jose Abreu

Review

Quoted 1 line · Gustavo Pimentel
(quoted diff) +1 -0
+	/* Free irqs */

But devm will automatically free it, no ?

Yes, it shouldn't be there. I'll remove it.

It depends. If the driver is using tasklets it must free it explicitly like this.

In this driver I'm not using tasklets.

Quoted 2 lines

P.S. devm_*_irq() is quite doubtful to have in the first place.

For curiosity, why?

Quoted 2 lines