Skip to contentSkip to conversation

drm/panel-simple: fix the warnings for the Evervision VGG644804

PATCH Applied Michael Walle 2 participants 3 messages May 20, 2025 – Jun 5, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel-simple: fix the warnings for the Evervision VGG644804

The panel lacked the connector type which causes a warning. Adding the connector type reveals wrong bus_flags and bits per pixel. Fix all of it.

Fixes 1319f2178bdf ("drm/panel-simple: add Evervision VGG644804 panel entry")
---
 drivers/gpu/drm/panel/panel-simple.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +3 -2
index 82ee2f12b8d2..0a3b26bb4d73 100644
@@ -2198,13 +2198,14 @@ static const struct display_timing evervision_vgg644804_timing = {
 static const struct panel_desc evervision_vgg644804 = {
 	.timings = &evervision_vgg644804_timing,
 	.num_timings = 1,
-	.bpc = 8,
+	.bpc = 6,
 	.size = {
 		.width = 115,
 		.height = 86,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
-	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
 static const struct display_timing evervision_vgg804821_timing = {
Signature · 1 line
2.39.5
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 21 lines · Michael Walle

The panel lacked the connector type which causes a warning. Adding the connector type reveals wrong bus_flags and bits per pixel. Fix all of it.

Fixes 1319f2178bdf ("drm/panel-simple: add Evervision VGG644804 panel entry")
---
  drivers/gpu/drm/panel/panel-simple.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +1 -1
index 82ee2f12b8d2..0a3b26bb4d73 100644
@@ -2198,13 +2198,14 @@ static const struct display_timing evervision_vgg644804_timing = {
  static const struct panel_desc evervision_vgg644804 = {
  	.timings = &evervision_vgg644804_timing,
  	.num_timings = 1,
-	.bpc = 8,
+	.bpc = 6,
  	.size = {

drivers/gpu/drm/panel/panel-simple.c static const struct display_timing evervision_vgg644804_timing = { · line 2211

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +2 -1
  		.width = 115,
  		.height = 86,
  	},
  	.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
-	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
  };
 
  static const struct display_timing evervision_vgg804821_timing = {
maintainer Applied
#2 lore raw
In reply to Michael Walle

Hi,

Quoted 5 lines · Michael Walle

The panel lacked the connector type which causes a warning. Adding the connector type reveals wrong bus_flags and bits per pixel. Fix all of it.

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)

[1/1] drm/panel-simple: fix the warnings for the Evervision VGG644804

      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/5dc1ea903588a73fb03b3a3e5a041a7c63a4bccd
Signature · 1 line
Neil